Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger #3114

ncalagar · 2018-05-21T21:01:05Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-05-21T21:02:42Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-05-21T21:03:18Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2158

AutorestCI · 2018-05-21T21:03:49Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2700

AutorestCI · 2018-05-21T21:08:00Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1921

ms-premp · 2018-05-21T22:04:27Z

Thanks @ncalagar .. this looks good to me.

anuchandy · 2018-05-23T00:43:05Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-05-31/consumption.json

+            }
+          }
+        }
+      }


even though this is not a pagable operation, adding following annotation

"x-ms-pageable": { "nextLinkName": null }

will ensure the generator flatten the value field, thus generated method will have List as return type instead of a model type that composes list.

Sure, applied the change

anuchandy · 2018-05-23T00:46:22Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-05-31/consumption.json

+      }
+    }
+  },
+  "paths": {


why we don't have other operations described in this api version such as usageDetails (those are supported in the previous api version)?

@anuchandy We are not releasing new version for usageDetails and other APIs yet... A new version for those APIs will come in later.
Simply put the call to new api-version for other APIs will fail as they do not exist. So there is no need to have them in new version of swagger, unless we actually have a new version for those APIs.

@ms-premp - you can add new APis to existing api-version also. I am not sure if i understand spinning up a new api-version for this api unless you are thinking this is in preview (in which case the api-version should be marked preview)

Thanks @ravbhatnagar ... We decided to use the new version for this API since, we do have some additional changes coming to few existing APIs and therefore we will need a new version anyway.
By first week of June, we will hopefully have changes to this swagger with updates to existing APIs.

…pecs; branch 'master' of https://github.com/Azure/azure-rest-api-specs

AutorestCI · 2018-05-23T19:03:30Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1332

ms-premp · 2018-05-23T21:15:47Z

@ravbhatnagar we need ARM review for this API. This is a new resource being added to Consumption RP.

ravbhatnagar · 2018-05-25T18:39:57Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-05-31/consumption.json

+          "type": "string",
+          "readOnly": true
+        },
+        "grain": {


can we please make this as an enum. would be easier to write code against

Done, thanks for suggestion

ravbhatnagar · 2018-05-25T18:40:13Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-05-31/consumption.json

+          "type": "string",
+          "readOnly": true
+        },
+        "chargeType": {


ravbhatnagar · 2018-05-25T18:40:35Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-05-31/consumption.json

+                "format": "decimal",
+                "readOnly": true
+              },
+              "bound": {


done. Thanks

ravbhatnagar · 2018-05-25T18:49:05Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-05-31/consumption.json

+      }
+    }
+  },
+  "paths": {


@ms-premp - you can add new APis to existing api-version also. I am not sure if i understand spinning up a new api-version for this api unless you are thinking this is in preview (in which case the api-version should be marked preview)

ms-premp · 2018-05-25T19:02:18Z

Thanks @ravbhatnagar ... We decided to use the new version for this API since, we do have some additional changes coming to few existing APIs and therefore we will need a new version anyway.
By first week of June, we will hopefully have changes to this swagger with updates to existing APIs.

ravbhatnagar · 2018-05-29T21:01:51Z

Looks good!

ms-premp · 2018-05-29T21:44:44Z

Thanks @ravbhatnagar ..
@anuchandy please see, if this is looks good for swagger release as well.

anuchandy · 2018-05-30T06:50:54Z

@ms-premp merging this, thanks!

…g new Forecast api swagger (#3114) * Forecast Api swagger * consumption readme file update for the new swagger version * addressing review comment on adding nextLink * fixing build error * Addressed feedback on enum and fixed a typo

* One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fix build errors Fix build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114) * Forecast Api swagger * consumption readme file update for the new swagger version * addressing review comment on adding nextLink * fixing build error * Addressed feedback on enum and fixed a typo * Stop using unobscured credentials * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix go tag for storage management plane 2018-03-02 api version (#3156) * Refactoring Job Definitions (#3116) * MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version. * Add specs for machine learning services provider (#3135) * Add specs for machine learning services provider * Added python config to readme * Added repo generation for Python * Addressed feedback * Address more comments * Adding Security RP API swagger (#3144) * Reverted methods in vpn gateways. (#3163) * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit d1c40f7. * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit 2c1261e. * Update readme.md file Update readme.md file

Update servicelinker.json

Forecast Api swagger

25b0d14

azuresdkci assigned anuchandy May 21, 2018

azuresdkci requested a review from anuchandy May 21, 2018 21:02

consumption readme file update for the new swagger version

b837fe7

AutorestCI mentioned this pull request May 21, 2018

[AutoPR consumption/resource-manager] Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger Azure/azure-sdk-for-go#1882

Merged

anuchandy reviewed May 23, 2018

View reviewed changes

ncalagar added 2 commits May 23, 2018 11:26

Merge branch 'master' of https://github.com/ncalagar/azure-rest-api-s…

8ee660a

…pecs; branch 'master' of https://github.com/Azure/azure-rest-api-specs

addressing review comment on adding nextLink

75834e9

fixing build error

a407660

AutorestCI mentioned this pull request May 23, 2018

[AutoPR consumption/resource-manager] Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger Azure/azure-sdk-for-ruby#1310

Merged

anuchandy removed their assignment May 24, 2018

anuchandy requested a review from ravbhatnagar May 24, 2018 02:03

anuchandy self-assigned this May 24, 2018

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 24, 2018

ravbhatnagar reviewed May 25, 2018

View reviewed changes

ncalagar added 2 commits May 25, 2018 13:06

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

3663051

Addressed feedback on enum and fixed a typo

eadf281

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2018

anuchandy approved these changes May 30, 2018

View reviewed changes

anuchandy merged commit bb24e36 into Azure:master May 30, 2018

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #3114 from Azure/servicelinker-addsecret

25b4714

Update servicelinker.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger #3114

Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger #3114

ncalagar commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

ms-premp commented May 21, 2018

anuchandy May 23, 2018

ncalagar May 23, 2018

anuchandy May 23, 2018

ms-premp May 23, 2018

ravbhatnagar May 25, 2018

ms-premp May 29, 2018

AutorestCI commented May 23, 2018 •

edited

Loading

ms-premp commented May 23, 2018

ravbhatnagar May 25, 2018

ncalagar May 25, 2018

ravbhatnagar May 25, 2018

ncalagar May 25, 2018

ravbhatnagar May 25, 2018

ncalagar May 25, 2018

ravbhatnagar May 25, 2018

ms-premp commented May 25, 2018

ravbhatnagar commented May 29, 2018

ms-premp commented May 29, 2018

anuchandy commented May 30, 2018

Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger #3114

Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger #3114

Conversation

ncalagar commented May 21, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented May 21, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 21, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 21, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 21, 2018 • edited Loading

Automation for azure-sdk-for-go

ms-premp commented May 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 23, 2018 • edited Loading

Automation for azure-sdk-for-ruby

ms-premp commented May 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-premp commented May 25, 2018

ravbhatnagar commented May 29, 2018

ms-premp commented May 29, 2018

anuchandy commented May 30, 2018

ncalagar commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 21, 2018 •

edited

Loading

AutorestCI commented May 23, 2018 •

edited

Loading