Kamboj prjwl/release network microsoft.network 2024 05 01 #31095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-03-01 to stable/2024-05-01.
* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
* Swagger changes for expressroute site failover simulation * Fixing some checks * Correcting parameter name in stop json * Changing error schema * Adding arm id format for uris * Adding suppressions
* Added location headers to 202 responses for ipGroups and virtualRouters. * Added location header to vr peering delete examples * Ran prettier on 2024-05-01 examples
…workInterface (#30692) * [Network] - Adding DefaultOutboundConnectivityEnabled property in networkInterface * address prettier check
* add private only feature to azure bastion service * fix Swagger PrettierCheck * fix the swagger PrettierCheck * modify the api version * modify file name --------- Co-authored-by: Leo Liu (from Dev Box) <[email protected]>
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
This was referenced Oct 18, 2024
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
* fixing model errors * more fixes * more fixes * prettier checks * prettier --------- Co-authored-by: Prajjwal Kamboj <[email protected]>
GuptaVertika
approved these changes
Nov 13, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azc run |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
GuptaVertika
deleted the
kamboj-prjwl/release-network-Microsoft.Network-2024-05-01
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.