-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPAM, VNV, update Security Admin and Vnet specs #30560
Add IPAM, VNV, update Security Admin and Vnet specs #30560
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
All the changes are from these 2 PRs which have been reviewed and approved by ARM reviewer: |
...ification/network/resource-manager/Microsoft.Network/stable/2024-05-01/ipAddressManager.json
Show resolved
Hide resolved
@tadelesh could help on the Go SDK breaking change. |
in this pr, some base resource refs have been changed which cause go sdk breaking. @sssharma24 did you get approval from breaking change review board? |
@tadelesh the sdk go check actually passed and these changes have already been approved for preview versions as well. this is mostly just merging it to the stable |
could you
actually, i did not see the breaking change review in the private pr |
this is the main PR in priv repo with most changes and the breaking change benign tag #29998 |
thanks for the info, i approved go breaking changes. |
59bd02e
into
Azure:kamboj-prjwl/release-network-Microsoft.Network-2024-05-01
* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.