-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Comments - use plain English and fix Capitalization #28917
Merged
curiekim0
merged 2 commits into
Azure:curiekim0-databricks-Microsoft.Databricks-2024-05-01
from
curiekim0:addressComments
Apr 30, 2024
Merged
Address Comments - use plain English and fix Capitalization #28917
curiekim0
merged 2 commits into
Azure:curiekim0-databricks-Microsoft.Databricks-2024-05-01
from
curiekim0:addressComments
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛ |
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
accessconnector.json | 2024-05-01(5ae6979) | 2023-05-01(main) |
accessconnector.json | 2024-05-01(5ae6979) | 2022-10-01-preview(main) |
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.1) | new version | base version |
---|---|---|
package-2024-05-01 | package-2024-05-01(5ae6979) | package-2024-05-01(curiekim0-databricks-Microsoft.Databricks-2024-05-01) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'connectorName' should be defined with a 'pattern' restriction. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L37 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L78 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L104 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L116 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L197 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L216 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L228 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L343 |
XmsParameterLocation |
The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L402 |
XmsParameterLocation |
The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L409 |
Use the latest version v5 of managedidentity.json. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L322 |
|
Use the latest version v5 of types.json. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L326 |
|
Schema should have a description or title. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L340 |
|
Use the latest version v5 of managedidentity.json. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L379 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L403 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L410 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Databricks/stable/2024-05-01/accessconnector.json#L417 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛
PR Summary pending [Detail]
️⌛
Automated merging requirements met pending [Detail]
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=426853&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️🔄
azure-sdk-for-python inProgress [Detail]
️🔄
azure-sdk-for-js inProgress [Detail]
️🔄
azure-resource-manager-schemas inProgress [Detail]
️🔄
azure-powershell inProgress [Detail]
Generated ApiView
|
curiekim0
merged commit Apr 30, 2024
e4fd468
into
Azure:curiekim0-databricks-Microsoft.Databricks-2024-05-01
13 of 20 checks passed
madhura-np
pushed a commit
that referenced
this pull request
May 7, 2024
* Adds base for updating Microsoft.Databricks from version preview/2023-09-15-preview to version 2024-05-01 * Updates readme * Updates API version in new specs and examples * Add swagger spec for default storage firewall (#28152) * Add custom npip boolean parameter (#28286) * Add custom npip boolean parameter * modify npip paramter name * Force deletion change (#28414) * modify retainUCData parameter name * ucdata to forcedeletion * add default value for Force Deletion (#28418) * fix merge errors (#28423) * add access connector (#28445) * add access connector to the 20240501 version and add referedBy property * Create sdk-suppressions.yaml * fix WorkspaceNoPublicIPBooleanParameter type (#28582) * Update sdk-suppressions.yaml * Address Comments - use plain English and fix Capitalization (#28917) * capitalize Azure Databricks Access Connector * modify to Access Connector * undo breaking of SystemAssigned and UserAssigned (#28918) * modify type to commontype (#28939) * modify subscriptionId format in examples (#28951) * modify commontype reference to be direct (#28954) * remove required parameter in workspacenNoPublicIpBooleanpParameter (#28967) * add back the required parameter and remove default (#28968) --------- Co-authored-by: kazrael2119 <[email protected]>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
* Adds base for updating Microsoft.Databricks from version preview/2023-09-15-preview to version 2024-05-01 * Updates readme * Updates API version in new specs and examples * Add swagger spec for default storage firewall (Azure#28152) * Add custom npip boolean parameter (Azure#28286) * Add custom npip boolean parameter * modify npip paramter name * Force deletion change (Azure#28414) * modify retainUCData parameter name * ucdata to forcedeletion * add default value for Force Deletion (Azure#28418) * fix merge errors (Azure#28423) * add access connector (Azure#28445) * add access connector to the 20240501 version and add referedBy property * Create sdk-suppressions.yaml * fix WorkspaceNoPublicIPBooleanParameter type (Azure#28582) * Update sdk-suppressions.yaml * Address Comments - use plain English and fix Capitalization (Azure#28917) * capitalize Azure Databricks Access Connector * modify to Access Connector * undo breaking of SystemAssigned and UserAssigned (Azure#28918) * modify type to commontype (Azure#28939) * modify subscriptionId format in examples (Azure#28951) * modify commontype reference to be direct (Azure#28954) * remove required parameter in workspacenNoPublicIpBooleanpParameter (Azure#28967) * add back the required parameter and remove default (Azure#28968) --------- Co-authored-by: kazrael2119 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.