Add custom npip boolean parameter #28286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
|
PR validation pipeline restarted successfully. This comment will be populated with the 'Swagger Validation Report' |
|
PR validation pipeline restarted successfully. This comment will be populated with the 'Swagger Generation Artifacts' report |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
This was referenced Mar 15, 2024
Draft
msaranga
approved these changes
Mar 21, 2024
...ification/databricks/resource-manager/Microsoft.Databricks/stable/2024-05-01/databricks.json
Outdated
Show resolved
Hide resolved
curiekim0
merged commit de827f7
into
Azure:curiekim0-databricks-Microsoft.Databricks-2024-05-01
2 of 18 checks passed
madhura-np
pushed a commit
that referenced
this pull request
May 7, 2024
* Adds base for updating Microsoft.Databricks from version preview/2023-09-15-preview to version 2024-05-01 * Updates readme * Updates API version in new specs and examples * Add swagger spec for default storage firewall (#28152) * Add custom npip boolean parameter (#28286) * Add custom npip boolean parameter * modify npip paramter name * Force deletion change (#28414) * modify retainUCData parameter name * ucdata to forcedeletion * add default value for Force Deletion (#28418) * fix merge errors (#28423) * add access connector (#28445) * add access connector to the 20240501 version and add referedBy property * Create sdk-suppressions.yaml * fix WorkspaceNoPublicIPBooleanParameter type (#28582) * Update sdk-suppressions.yaml * Address Comments - use plain English and fix Capitalization (#28917) * capitalize Azure Databricks Access Connector * modify to Access Connector * undo breaking of SystemAssigned and UserAssigned (#28918) * modify type to commontype (#28939) * modify subscriptionId format in examples (#28951) * modify commontype reference to be direct (#28954) * remove required parameter in workspacenNoPublicIpBooleanpParameter (#28967) * add back the required parameter and remove default (#28968) --------- Co-authored-by: kazrael2119 <[email protected]>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
* Adds base for updating Microsoft.Databricks from version preview/2023-09-15-preview to version 2024-05-01 * Updates readme * Updates API version in new specs and examples * Add swagger spec for default storage firewall (Azure#28152) * Add custom npip boolean parameter (Azure#28286) * Add custom npip boolean parameter * modify npip paramter name * Force deletion change (Azure#28414) * modify retainUCData parameter name * ucdata to forcedeletion * add default value for Force Deletion (Azure#28418) * fix merge errors (Azure#28423) * add access connector (Azure#28445) * add access connector to the 20240501 version and add referedBy property * Create sdk-suppressions.yaml * fix WorkspaceNoPublicIPBooleanParameter type (Azure#28582) * Update sdk-suppressions.yaml * Address Comments - use plain English and fix Capitalization (Azure#28917) * capitalize Azure Databricks Access Connector * modify to Access Connector * undo breaking of SystemAssigned and UserAssigned (Azure#28918) * modify type to commontype (Azure#28939) * modify subscriptionId format in examples (Azure#28951) * modify commontype reference to be direct (Azure#28954) * remove required parameter in workspacenNoPublicIpBooleanpParameter (Azure#28967) * add back the required parameter and remove default (Azure#28968) --------- Co-authored-by: kazrael2119 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.