Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New GA Version #26953

Merged
merged 16 commits into from
Jan 10, 2024

commiting changes

25687e6
Select commit
Loading
Failed to load commit list.
Merged

Adding New GA Version #26953

commiting changes
25687e6
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff failed Jan 10, 2024 in 3m 17s

~[NotRequired_Staging] Swagger LintDiff failed

ppe/LintDiff: 144 Errors, 371 Warnings
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2022-09-01-preview package-2022-09-01-preview(25687e6) package-2022-09-01-preview(main)
package-2024-04-01 package-2024-04-01(25687e6) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3384		 RPC-Policy-V1-03
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/preview/2022-09-01-preview/azuresphere.json#L3303		 RPC-Policy-V1-03
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3093
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3055
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3052
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3049


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L4189
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L4124
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L4112
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3811
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3799
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3675
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3531
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3519
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3499
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3463
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3434
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3434
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3422
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3411
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3375
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3266
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L3243
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2796
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2771
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2765
❌ ConsistentPatchProperties The property 'properties.deviceGroupId' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2757
❌ PatchPropertiesCorrespondToPutProperties deviceGroupId property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2710
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2676
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2670
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2592
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Devices' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2475
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2386
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2358
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2352
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2275
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L2223
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1918
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1883
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1802
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1796
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1726
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1484
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1449
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1376
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1370
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1308
❌ ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1166
❌ ParametersInPost $skip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1166
❌ ParametersInPost $top is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1166
❌ ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1166
❌ ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1104
❌ ParametersInPost $skip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1104
❌ ParametersInPost $top is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1104
❌ ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1104
❌ ParametersInPost $maxpagesize is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AzureSphere/stable/2024-04-01/azuresphere.json#L1033
View more details on openapi-pipeline-app