Merge master in to keyvault_preview

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,8 +1,8 @@
-This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process. 
+This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
 
 ### PR information
 - [ ] The title of the PR is clear and informative.
-- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).
+- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).
 - [ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
 - [ ] If applicable, the PR references the bug/issue that it fixes.
 - [ ] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).
@@ -11,5 +11,5 @@ This checklist is used to make sure that common issues in a pull request are add
 - [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).
 - [ ] My spec meets the review criteria:
   - [ ] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).
-  - [ ] The spec follows the guidelines described in the [Swagger checklist](../documentation/swagger-checklist.md) document.
-  - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR. 
+  - [ ] The spec follows the guidelines described in the [Swagger checklist](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md) document.
+  - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.

.travis.yml

@@ -5,6 +5,7 @@ services:
   - docker
 env:
   matrix:
+    - MODE=branchStrategy
     - MODE=syntax
     - MODE=python
     - MODE=node
@@ -30,6 +31,7 @@ matrix:
     - env: MODE=azurebot PR_ONLY=true
     - env: MODE=liveValidation PR_ONLY=true
     - env: MODE=java
+    - env: MODE=ruby
     - env: MODE=go
     - env: MODE=node
 before_install:
@@ -66,6 +68,11 @@ script:
     if [[ $MODE == 'java' ]]; then
       $DOCKER_CMD Azure/azure-libraries-for-java -v
     fi
+  - >-
+    if [[ $MODE == 'branchStrategy' ]]; then
+      # Check to ensure CI is not executing for a PR against the master branch in the private repository
+      ! [[ $TRAVIS_PULL_REQUEST != 'false' && $TRAVIS_REPO_SLUG == 'Azure/azure-rest-api-specs-pr' && $TRAVIS_BRANCH == 'master' ]]
+    fi
   - >-
     if [[ $MODE == 'syntax' ]]; then
       npm test -- test/syntax.js

CODEOWNERS

@@ -0,0 +1,101 @@
+/specification/advisor/ @daschult @davidwa-msft @kejiun @prasanna-padmanabhan @vladbarosan @xiaoyu-huang
+/specification/analysisservices/ @athipp @daschult @erickson-doug @michael-falk @shihying @taiwu @vladbarosan @ziyuanms
+/specification/apimanagement/ @darrelmiller @daschult @dmakwana @himanshumisra1 @jihochang @kedarjoshi @lukaszstem @maboja-msft @owolabi2 @promoisha @sethmanheim @solankisamir @vitaliykurokhtin @vladbarosan
+/specification/appinsights/ @d3r3kk @frankguodongchen @vladbarosan
+/specification/applicationinsights/ @alexeldeib @d3r3kk @daschult @frankguodongchen @jpiyali @owolabi2 @tiffanyachen @yanivid3
+/specification/asazure/ @athipp @erickson-doug
+/specification/authorization/ @darshanhs90 @daschult @stankovski @tfitzmac @vivsriaus
+/specification/automation/ @anatolib @bmanikm @chandrasekarsrinivasan @d1v38om83r @daschult @developertommy @francisco-gamino @kunyuchen @miaromero @mikekinsman @murilogr @najams @tiffanyachen @vivlingaiah @vladbarosan @vrdmr
+/specification/azsadmin/ @daschult @deathly809
+/specification/azurestack/ @deathly809
+/specification/azurestackadmin/ @deathly809
+/specification/batch/ @brnleehng @chandrasekarsrinivasan @daschult @jihochang @kiwidev @matthchr @murilogr @tfitzmac @vladbarosan @xingwu1
+/specification/batchai/ @alexanderyukhanov @daschult @jihochang
+/specification/billing/ @daschult @panda-wang @shawns1 @tiffanyachen @vladbarosan @wilcobmsft
+/specification/cdn/ @camsoper @csmengwan @daschult @erickson-doug @injyzarif @prakharsharma10 @shawns1 @stankovski @vladbarosan
+/specification/cognitiveservices/ @areddish @ashku-ms @chandrasekarsrinivasan @daniel-ms @daschult @davidlicig @eisber @felixwa @gmainar @jihochang @lebronj @luiscabrer @murilogr @omarelhariry137 @pcostantini @q3blend @ro-joowan @shakao @stefanvalianu @sudhansu88 @tiffanyachen @v-sodsou @vladbarosan @xiaojinghe
+/specification/commerce/ @brjohnstmsft @bryanla @daschult @pargall @vladbarosan
+/specification/common-types/ @vladbarosan
+/specification/compute/ @bganapa @brendandburns @brjohnstmsft @carissasun @chandrasekarsrinivasan @daschult @deepakrajendranmsft @dlepow @dmakwana @evgenyagafonchikov @gatneil @gbowerman @himanshumisra1 @huangpf @hyonholee @koralski @lukaszstem @maboja-msft @mboersma @murilogr @nepomuceno @nkuchta @pratnala @priydes @sethmanheim @shawns1 @stankovski @sudhansu88 @tbombach @thraka @tiffanyachen @vinatara @vladbarosan @wangjun198389 @waynekuo @yolo3301
+/specification/consumption/ @daschult @kc786 @kjeur @ms-premp @panda-wang @sandeepnl @v-anpasi @vladbarosan
+/specification/containerinstance/ @daschult @francisco-gamino @jluk @samkreter @xizhamsft @yolo3301
+/specification/containerregistry/ @daschult @djyou @jihochang @mmacy @ro-joowan @vladbarosan
+/specification/containerservices/ @daschult @mboersma @vladbarosan
+/specification/cosmos-db/ @daschult @dmakwana @molly-moen @vladbarosan
+/specification/customer-insights/ @daschult @tjlvtao @vladbarosan
+/specification/databricks/ @jeffpang
+/specification/datacatalog/ @daschult @maxlims
+/specification/datafactory/ @bgold09 @chandrasekarsrinivasan @chinadragon0515 @daschult @eva-xiao @fan130 @fhljys @gadongji @haoqian-ms @haricr @hvermis @jihochang @milantomic6 @murilogr @najian @nicolaszhang @peshen @sharmm @tiffanyachen @wenbof @wezou2 @wuchunchunt19 @xiaoyinglj @yuanliu-ms @zhangyd2015
+/specification/datalake-analytics/ @brjohnstmsft @daschult @jihochang @matt1883 @ro-joowan @stankovski @vladbarosan
+/specification/datalake-store/ @brjohnstmsft @daschult @jihochang @ro-joowan @stankovski @vladbarosan
+/specification/datamigration/ @daschult @hitenjava @tiffanyachen
+/specification/deploymentmanager/ @netrock
+/specification/deviceprovisioningservices/ @kvish @mikekinsman @montgomp
+/specification/devtestlabs/ @ajay-arora @daschult @iouri-s @ryanvog @steved0x
+/specification/dns/ @daschult @karravi-msft @mikhailtryakhov @nkindberg @owolabi2 @stankovski @tbombach @vladbarosan @vladrai
+/specification/documentdb/ @dmakwana
+/specification/domainservices/ @daschult @jihochang
+/specification/eventgrid/ @cpjagan @daschult @djyou @kalyanaj @scottholden
+/specification/eventhub/ @biberli @daschult @gmainar @jihochang @sazeesha @sethmanheim @tiffanyachen @v-ajnava @vladbarosan
+/specification/features/ @stankovski
+/specification/graphrbac/ @brjohnstmsft @darshanhs90 @daschult @himanshumisra1 @lukaszstem @maboja-msft @mmacy @ppathan @sethmanheim @stankovski @vladbarosan
+/specification/gsm/ @jeffrey-ace
+/specification/hanaonazure/ @daschult @jovillas @pakdliu @tiffanyachen
+/specification/hdinsight/ @daschult @pulkittomar @vladbarosan @wawon-msft
+/specification/insights/ @gucalder @vladbarosan
+/specification/intune/ @daschult @stankovski @vrmurthy01
+/specification/iothub/ @brjohnstmsft @daschult @jihochang @kvish @mastermanu @rajeevmv @rkmanda @ssankar1984 @vishal-gandhi @xscript
+/specification/keyvault/ @brjohnstmsft @daschult @dragav @jihochang @msfcolombo @rijethma @schaabs @seanbamsft @tiffanyachen @vladbarosan
+/specification/locationbasedservices/ @daschult @jcookit @jp94
+/specification/logic/ @brjohnstmsft @daschult @daviburg @pankajsn @shimedh @stankovski @steved0x @tbombach @tonytang-microsoft-com @vladbarosan
+/specification/machinelearning/ @brjohnstmsft @daschult @ericwill-msft @garyericson @nonstatic2014 @ragargms @tudordid @vladbarosan
+/specification/machinelearningcompute/ @daschult @shutchings
+/specification/machinelearningexperimentation/ @daschult @ragargms
+/specification/management/ @muazmian
+/specification/managementgroups/ @rajshah11
+/specification/managementpartner/ @jeffrey-ace
+/specification/marketplaceordering/ @daschult @prbansa @tiffanyachen
+/specification/mediaservices/ @brianblum @brjohnstmsft @daschult @jonpayne @vladbarosan
+/specification/migrate/ @amandeeps @ronehr
+/specification/mobileengagement/ @brjohnstmsft @daschult @guperrot @mehrdadmzfr @pshrosbree @stankovski
+/specification/monitor/ @asafst @daschult @davmc @gucalder @jihochang @johnkemnetz @micongjie @pkamath13 @ro-joowan @shriku11 @tiffanyachen @vladbarosan
+/specification/msi/ @daschult @varunkch @vladbarosan
+/specification/mysql/ @daschult @jihochang @qingqingyuan @rahulgouthamdotgs @sasankv-ms @suna-ms @tiffanyachen @vladbarosan
+/specification/network/ @ajinkyapotdarvjti @akshaysngupta @allanbomsft @anavinahar @ankurchoubeymsft @azhao155 @bganapa @brjohnstmsft @chandrasekarsrinivasan @daschult @dedhar @deepakrajendranmsft @dihan0604 @dmakwana @evgenyagafonchikov @georgewallace @gimotwanmsft @gmainar @henry416 @himanshumisra1 @irrogozh @jihochang @jobatzil @kagamsft @lamchester @lukaszstem @maboja-msft @manjushachava @mattreatmsft @mikhailtryakhov @murilogr @nilambari @number213 @pacort @pashukl @priyanag @ritwikbasu @ro-joowan @rupalivohra @sethmanheim @skomarag @stankovski @sudhansu88 @tfitzmac @vinatara @vinayada1 @vladbarosan
+/specification/notificationhubs/ @amolr @daschult @smithab @stankovski
+/specification/operationalinsights/ @alexeldeib @chandrasekarsrinivasan @daschult @murilogr @sw47 @vladbarosan @xizhamsft
+/specification/operationsmanagement/ @daschult @dashimi16
+/specification/policyinsights/ @bulentelmaci @tiffanyachen
+/specification/postgresql/ @daschult @himanshumisra1 @jihochang @lukaszstem @maboja-msft @qingqingyuan @rahulgouthamdotgs @revas89 @sasankv-ms @sethmanheim @suna-ms @tiffanyachen @vladbarosan
+/specification/powerbidedicated/ @daschult @selasagi @tarostok
+/specification/powerbiembedded/ @daschult @mattmazzola @minewiskan
+/specification/powerbipremium/ @michael-falk
+/specification/provisioningservices/ @daschult @francisco-gamino @kvish @montgomp
+/specification/recoveryservices/ @daschult @dragonfly91 @sonathan @vladbarosan
+/specification/recoveryservicesbackup/ @daschult @dheerendrarathor @dragonfly91 @gmainar @markgalioto @vladbarosan
+/specification/recoveryservicessiterecovery/ @avneeshrai @bsiva @daschult @dmakwana @himanshumisra1 @lukaszstem @maboja-msft @mikekinsman @mukum @sethmanheim @sudhansu88 @vladbarosan
+/specification/redis/ @alfantp @brjohnstmsft @daschult @siddharthchatrolams @stankovski @steved0x @tiffanyachen @timlovellsmith @vladbarosan
+/specification/relay/ @daschult @gmainar @sethmanheim @v-ajnava @vladbarosan
+/specification/remoteapp/ @amarsi @calexan
+/specification/reservations/ @corquiri @daschult
+/specification/resourcehealth/ @daschult @himanshumisra1 @lukaszstem @maboja-msft @rajithanitc @sankalpsoni @sethmanheim @vladbarosan
+/specification/resources/ @bganapa @brjohnstmsft @chandrasekarsrinivasan @chidmdxx @cyl3392207 @daschult @everfor @grzegorzzygmunt @jaredmoo @jihochang @luanshixia @mjfrb @muazmian @murilogr @pilor @rajshah11 @sendhil @stankovski @tbombach @tfitzmac @tudordid @vivsriaus @vladbarosan @wenwu449 @wilcobmsft @zjpjack
+/specification/scheduler/ @daschult @derek1ee @pinwang81 @stankovski @tudordid
+/specification/search/ @brjohnstmsft @daschult @seansaleh @tiffanyachen @tudordid @vladbarosan
+/specification/servermanagement/ @daschult @r22016 @steved0x
+/specification/service-map/ @daschult @daveirwin1
+/specification/servicebus/ @brjohnstmsft @daschult @gmainar @himanshumisra1 @jihochang @lukaszstem @maboja-msft @sazeesha @sethmanheim @sudhansu88 @tiffanyachen @v-ajnava @vladbarosan
+/specification/servicefabric/ @daschult @jihochang @juhacket @ro-joowan @samedder @vipulm-msft @vladbarosan
+/specification/siterecovery/ @avneeshrai
+/specification/sql/ @akromm @btasdoven @chandrasekarsrinivasan @daschult @dnayantara @emgu-ms @ferno-ms @gmainar @jaredmoo @jcyang75 @jiahli @jiawang003 @jugeorge @kisantia @kosta-bizetic @maboja-msft @markobender @mihymel @mmacy @murilogr @nathannfan @payiazure @pixia @ro-joowan @sarvesh-s @scottholden @stankovski @tiffanyachen @tomapaunovic @tudordid @vladbarosan @vsporeddy @yaakoviyun @yiwuti @zhensun-sql
+/specification/storage/ @bganapa @bingosummer @blueww @brjohnstmsft @daschult @emgerner-msft @jasonyang-msft @robinsh @stankovski @tudordid @vladbarosan
+/specification/storageimportexport/ @daschult @leoz-ms @renashahmsft
+/specification/storsimple/ @manaas-microsoft
+/specification/storsimple8000series/ @daschult @dmakwana @himanshumisra1 @lukaszstem @maboja-msft @manaas-microsoft @sethmanheim @vladbarosan
+/specification/streamanalytics/ @atpham256 @daschult @vladbarosan
+/specification/subscription/ @daschult @wilcobmsft
+/specification/subscriptions/ @stankovski
+/specification/timeseriesinsights/ @daschult @sandshadow @vladbarosan @yeskarthik
+/specification/trafficmanager/ @allencal @brjohnstmsft @daschult @hrkulkarmsft @tbombach @vladbarosan
+/specification/visualstudio/ @amaljg @daschult @gmainar @himanshumisra1 @lukaszstem @maboja-msft @niblak @sethmanheim
+/specification/web/ @csmengwan @daschult @ericsten-msft @gmainar @hforeste @lukaszstem @michimune @mikekinsman @mn263 @naveedaz @nking92 @shcummin @stankovski @stevenernst131 @tiffanyachen @vladbarosan @zooba

README.md

@@ -33,17 +33,19 @@ The structure of the directory should strictly follow these rules:
 
 1. **Profile**: The profile holder contains the profiles' definition MD files. these files will contain information and references to the snapshots of the RPs' Resource types or Dataplane API versions that represent a specific profile.
 
-2. **Specification**: This folder the is root folder for all Specs (Management and Dataplane) related docs.
+1. **Specification**: This folder the is root folder for all Specs (Management and Dataplane) related docs.
 
-3. **<RP-Name>** Folders - each RP will have a separate folder
+1. **{RP-Name} Folders** - each RP will have a separate folder
 
-4. **'resource-manager' and 'data-plane' Folders**: the RPs can put specs in one of two categories: `resource-manager` (for ARM resources) and `data-plane` (for everything else) . The autorest configuration file (`readme.md`) for the RP should be inside this folder
+1. **'resource-manager' and 'data-plane' Folders**: the RPs can put specs in one of two categories: `resource-manager` (for ARM resources) and `data-plane` (for everything else) . The autorest configuration file (`readme.md`) for the RP should be inside this folder
 
-4. **API versions**: this folder will be the direct child of the category folder. there will be one such folder per resource type or dataplane service version. This folder will contain the OpenAPI validation Specs (Swaggers previously) and the examples folder.
+1. **'preview' and 'stable' Folders**: Varying levels of stability exist in our repository. Each API Version folder should be categorized as either still accepting breaking changes, or no longer accepting breaking changes. This is not a direct analog for whether or not an API Version has the "-preview" suffix or not. SDKs that are generated from 'preview' folder items should indicate to their customers in the most idiomatic way that breaking changes may still be coming.
 
-6. **Examples**: the example folder will contain the x-ms-examples files. it will reside under the APIs or Resources' version folders as different APIs or Resource types version can have different examples.
+1. **API versions**: this folder will be the direct child of the category folder. there will be one such folder per resource type or dataplane service version. This folder will contain the OpenAPI validation Specs (Swaggers previously) and the examples folder.
 
-7. **Notes**:
+1. **Examples**: the example folder will contain the x-ms-examples files. it will reside under the APIs or Resources' version folders as different APIs or Resource types version can have different examples.
+
+1. **Notes**:
     - folder names should be singular (ie, 'profile' not 'profiles' ) -- this removes ambiguity for some non-english speakers.
     - generic folder names should be lower-case
     - proper-name/product name/namespace folders can be PascalCased (ie, "KeyVault")
@@ -57,31 +59,37 @@ The structure should appear like so:
 |    +---automation
 |    |   \---resource-manager
 |    |       \---Microsoft.Automation
-|    |           \---2015-10-31
-|    |               \---examples
+|    |           \---stable
+|    |               \---2015-10-31
+|    |                   \---examples
 |    +---batch
 |    |   +---data-plane
 |    |   |   \---Microsoft.Batch
-|    |   |       +---2015-12-01.2.2
-|    |   |       +---2016-02-01.3.0
-|    |   |       +---2016-07-01.3.1
-|    |   |       +---2017-01-01.4.0
-|    |   |       |   \---examples
-|    |   |       \---2017-05-01.5.0
+|    |   |       +---stable
+|    |   |       |   +---2015-12-01.2.2
+|    |   |       |   +---2016-02-01.3.0
+|    |   |       |   +---2016-07-01.3.1
+|    |   |       |   +---2017-01-01.4.0
+|    |   |       |       \---examples
+|    |   |       \---preview
+|    |   |           \---2017-05-01.5.0
 |    |   \---resource-manager
 |    |       \---Microsoft.Batch
-|    |           +---2015-12-01
-|    |           +---2017-01-01
-|    |           |   \---examples
+|    |           +---stable
+|    |           |   +---2015-12-01
+|    |           |   +---2017-01-01
+|    |           |       \---examples
 |    |           \---2017-05-01
 |    |               \---examples
 |    +---billing
 |        \---resource-manager
 |            \---Microsoft.Billing
-|                +---2017-02-27-preview
-|                |   \---examples
-|                \---2017-04-24-preview
-|                    \---examples
+|                \---stable
+|                |   +---2017-02-27-preview
+|                |       \---examples
+|                +---preview
+|                    \---2017-04-24-preview
+|                        \---examples
 \--- readme.md
 ```