Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master in to keyvault_preview #2681

Merged
merged 96 commits into from
Mar 16, 2018

Conversation

RandalliLama
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

alexeldeib and others added 30 commits February 23, 2018 08:44
* Add purge to management plane API

* Adding purge status operation

* Change purge statue to enum

* capitalize response status
* Remove internal schena column

* Fix row schema
…e#2416)

* Initial addition of favorites and locations API

* Complete web test locations API

- favor 'web test' names/descriptions over 'synthetic monitor' as web test is more customer-centric naming
- create example data for the web test api

* Spelling update

* Updated parameters for favorite API

* Add favorites API and examples

- ensure tests run against the applicationinsights folder successfully

* Add collectionFormat to comma-separated tags list parameter for favorites
- generating API in CSharp generated errors

* Enum for favorite type should be set to modelAsString as further favorite types are possible in future.

* Update suppressions to include specific instances I need suppressed (no global suppressions where possible).

* Suppress some noisey test warnings from API specifications from my peers.

* PR suggestions

- Remove x-ms-pageable annotation from our list operation, in the service code we never paganate our data.
- Add x-ms-enum annotation to one enum data type where it was missing.
…e#2457)

* Added the missing API discovered in ARM_RP_Fundamentals to the respective API version swagger and review comments

* added tag for 2014-09
…hange for new biz model (Azure#2414)

* Add new version for mysql and pgsql

* Correct readme version

* Correct create properties parameter

* Correct PG namespace and some other comment

* Update Examples folder to examples

* Correct property name cases in the examples

* Corrected the ServerResult objects in CRUD samples

* Correct property values for server response in samples

* make createtime and lastmodifiedtime for logfileproperties to readonly
…zure#2523)

* Swagger specs for all existing versions of Microsoft.PolicyInsights

* Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending)

* Fix $top in examples; fix casing in examples

* Fix two more instances of $top type in examples

* Fix metadata examples by adding content type header and changing the body to a single string

* Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions

* Fix remaining examples with bad casings

* Fix additionalParameters definition; fix duplicate paths

* Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle)
* Add "Classic Account" ARM resource.

* 1. Change classic account property name from "userPrincipalName" to "principalName"
2. Add examples

* Fix API version in examples.

* Add example links.

* ClassicAccount->BillingAccount

* Removing "uuid" - billing account name may be a concatenation of uuid and additional keys.

* Remove unused parameters.

* 1. Add new version to readme.md
2. Fix validation warnings

* Fix descriptions.

* Fix type mismatch error.

* Adding missing parameter in example.

* Fix ms-examples name.
* Compute spec change for zone resilient images

* Address feedback from the previous iteration
…#2520)

* update swaggers for azure database and elastic pool operation

* update ListDatabaseOperations and ListElasticPoolOperations examples

* Only update the swagger for elastic pool operations

* end

* remove two not needed folders. Fix the error in ListElasticPoolOperation

* Update the cancel operations swagger on database and pool, and corresponding examples

* fix indentation in cancelOperations.json and cancelPoolOperations.json
…rget (Azure#2531)

* Copy over 2017-11-15-preview folder in preparation for adding 2018-03-15-preview api version.

* Update Azure Database Migration Service to add Managed Instance as target
…client level argument Azure#2565 (Azure#2566)

* [Monitor] Make all attributes of EventData class readonly (Azure#2254)

* [Monitor] Fixing issue with metricnamespace specification as client level argument Azure#2565
This is part of a planned refactoring that will split the Azure Search .NET
data plane SDK into separate packages.
Please note this is not a GA API and has been deprecated for a while.
There is no current user for it.
* Adding preview/stable to the example layout.

* Fixing formatting
* Default string modeled as parameter for auto generation to work correctly

* Adding CheckNameAvailability and listUpgradeNotifications into swagger for redis

* Fixing code review comments

* remove "/" at end for list apis

* Name change for notification

* Fixing code review comments in PR

* Fixing examples that are breaking the build
…ition (Azure#2563)

* Swagger specs for all existing versions of Microsoft.PolicyInsights

* Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending)

* Fix $top in examples; fix casing in examples

* Fix two more instances of $top type in examples

* Fix metadata examples by adding content type header and changing the body to a single string

* Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions

* Fix remaining examples with bad casings

* Fix additionalParameters definition; fix duplicate paths

* Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle)

* Change group name for operations path, and rename response type definition

* Change group name for operations path, and rename response type definition (old API versions)
* Copy the 2017-03-01 files

* 2018-01-01 specific changes

revert x-ms-enum and update description

* 202 on create or update, network status and backend flatten

202 on create or update, networkstatus backend flatten

Head for ApiRevision

* Fix ValidationRegex of Ids and length

* Fix the TagResource contract

* Make PUT operation on portalsettings resources ARM-compliant

Fix examples

* Removed x-ms-client-flatten

* NextLinkName and fix Check Entity Exist

* Bring back default responses and fix examples
* CDN in all languages in conf

* Review from Node and Amar

* Use "net" in tag and not "csharp"

* Remove wrong C# comment from Readme

* Update Ruby to match real repo

* Fix Ruby folder
marstr and others added 17 commits March 14, 2018 14:40
* Updating Travis to enforce branch strategy

* Fixing some typos

* One more shot

* Negating logic
* Refactor sql readme.md

- Rename schema-* to package-pure-* in order to follow convention for python multi-version
- Rename package-2017-10-preview to package-composite-v1. The reasons for this are explained in package-2017-03-01-preview tag. The next tag that I add in the near future will be package-composite-v2, which will represent a breaking change & major version bump for clients.
- Improved description of various sections
- Whitespace/header consistency

* Added package-pure-2017-10 including Go support

* Commented on Go api-versions

* Removed bad python section

* Fixed typo in 2017-10 go package
…zure#2617)

* Add more enum values for Identity/type in generic resource swagger

Resource types like "Microsoft.Compute/VirtualMachines" have more than
one enum value for Identity/type. Updating generic resource swagger so
it is up-to-date.

* Revert changes in swagger spec for 2017 API Version
… API (Azure#2655) (Azure#2662)

* [Monitor] Make all attributes of EventData class readonly (Azure#2254)

* [Monitor] Fixing issue with metricnamespace specification as client level argument Azure#2565

* [Monitor] Fixing incorrect specification of top parameter for Metrics API (Azure#2655)
* Cleaning up branchStrategy messaging

* Fixing typo
* Improve Microsoft.Insights schema generation

- Case of microsoft.insights updated to Microsoft.Insights throughout
- Added schema tag to readme.md to limit the input files

* Properly move folder to update case of name
…#2542)

* adding DPS camelCase changes, IoT Hub camelCase changes, basic sku

* adding 2018-01-22 changes for dps and iothub
…Azure#2272)

* Adding preview version of Event Hubs Cluster to Azure REST API specs.

* Adding capacity property to EH Cluster examples.

* Differentiating update semantics with patch semantics.

* RP-Cluster API: Revamping namespaces enumeration in cluster.

* Adding cluster sku property bag and moving capacity to sku. Also adding metricId property to the custom properties bag.

* RP-Cluster: Modifiying EHCluster references to Cluster references. Adding changes to readme file as well.

* RP-Cluster: Adding Event Hubs operations API to Cluster swagger.

* RP-Cluster: Removing leftover EHNamespaces definitions.

* Cluster: Distinguishing between Cluster and Configuration clients in operation ids.
* [AKS] update list of supported VM sizes

* Sync up ACS VM sizes with AKS sizes
* Adding API Specs for Long Term Retention V2

This change adds the swagger documentation for the Long Term Retention V2 feature along with examples for each of the APIs.. This includes the following APIs:

Get an LTR Backup
Get all LTR Backups under a database
Get all LTR Backups under a server
Get all LTR Backups under a location
Delete an LTR Backup
Set a database's LTR Policy
Get a database's LTR Policy

* Remove empty properties and update retention description

This update is a response to the few comments that Anu left on the PR. It removes an empty properties entry and updates the retention descriptions to explain that they use an ISO 8601 standard.

* Description and Entity Name Changes

Made some slight changes to the entity names to better align with LTR V1 and added some better descriptors to some property descriptions.

* Fixing Incorrect Description

 The weekOfYear parameter is not in an ISO 8601 format, it is just an integer between 1 and 52. Fixing that accordingly.

* Remove Conflicting Definitions

Need to remove backupLongTermRetentionPolicies so it doesn't conflict with the new backupLongTermRetentionPolicies.

* Remove Reference to backupLongTermRetentionPolicies.json

Need to remove the reference to backupLongTermRetentionPolicies.json in the readme.

* Update ResourceId

Updated the resource ID for longTermRetentionBackups so servers and databases are now longTermRetentionServers and longTermRetentionDatabases, respectively. This better aligns with REST.

* Re-Adding LongTermRetentionPolicyGet.json

LongTermRetentionPolicyGet.json was accidentally deleted in the last commit.

* Fix Travis CI Errors

Made some changes to the examples to fix the Travis CI errors.

* Updating more references to BackupLongTermRetentionPolic(y|ies)

* Re-adding backupLongTermRetentionPolicies.json

* removing .travis.yml that was accidentally added

* Revert "removing .travis.yml that was accidentally added"

This reverts commit 3b80fa0.

* Revert "Re-adding backupLongTermRetentionPolicies.json"

This reverts commit b98cf6c.

* undoing accidental .travis.yml

* Fixing errors in model PR_ONLY=true Travis CI run

* Fixing another Travis CI error

* Removing .travis.yml from the change and changing LongTermRetentionPolicy to BackupLongTermRetentionPolicy to keep it consistent

* resetting backupLongTermRetentionPolicies.json

* Update more references of LongTermRetentionPolicy to BackupLongTermRetentionPolicy

* updating readme.md comment
@RandalliLama RandalliLama requested a review from schaabs March 16, 2018 18:43
@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2203

This file will be used to automatically request PR reviews from SMEs on
the service teams. It is autogenerated based on previous PR submitters.
@AutorestCI
Copy link

AutorestCI commented Mar 16, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

Vlad Barosan and others added 2 commits March 16, 2018 12:25
* Add Go tag for api management, api version 2018-01-01

* Generate go to preview path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.