-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aks fleet 2023 06 15 preview patchasync from 0615 #25131
Fix aks fleet 2023 06 15 preview patchasync from 0615 #25131
Conversation
Hi @serbrech, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
fleets.json | 2022-09-02-preview(a020f70) | 2022-09-02-preview(main) |
fleets.json | 2023-03-15-preview(a020f70) | 2023-03-15-preview(main) |
Rule | Message |
---|---|
1011 - AddingResponseCode |
The new version adds a response code '202'. New: fleet/preview/2023-03-15-preview/fleets.json#L767:11 |
1044 - XmsLongRunningOperationChanged |
The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: fleet/preview/2023-03-15-preview/fleets.json#L706:7 Old: fleet/preview/2023-03-15-preview/fleets.json#L706:7 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) | new version | base version |
---|---|---|
package-2023-03-preview | package-2023-03-preview(a020f70) | package-2023-03-preview(dev-aks-fleet-2023-06-15-preview) |
package-2022-09-preview | package-2022-09-preview(a020f70) | package-2022-09-preview(dev-aks-fleet-2023-06-15-preview) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2022-09-02-preview/fleets.json#L270 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2022-09-02-preview/fleets.json#L666 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2023-03-15-preview/fleets.json#L273 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2023-03-15-preview/fleets.json#L669 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2023-03-15-preview/fleets.json#L1054 |
Schema should have a description or title. Location: fleet/preview/2023-03-15-preview/fleets.json#L1688 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @serbrech! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
480cf1e
to
053658d
Compare
Hi @serbrech! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
Hi @serbrech! The automation detected breaking changes in this pull request. As a result, it added the
|
* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * [Fleet][Dev] API 0615 changes (#25020) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * sync with ADO repo * exclude unneeded file changes * revert tsp config * revert helpers.tsp * remove package files * remove package files * add known word containerd * format * remove .npmrc * revert custom word * revert package-lock.json * re-generate json * add example * add example * fix read-only fields * fix read-only fields * re-generate json with latest compiler * add custom word back * re-generate json * restore config * add examples * add examples * add examples * add examples * add examples * add examples * prettier * fix examples * git ignore * review commoents * fix examples * make node image selection optional * fix warnings * fix warnings * fix warnings * fix docs * revert package changes * compile * fix tspconfig (#25031) * [Fleet][readmes] Dev aks fleet 2023 06 15 preview readmes (#25033) * update readmes * fix readme mistake * fix operationid warnings (#25109) * tsp format (#25111) * Fix aks fleet 2023 06 15 preview patchasync from 0615 (#25131) * do the breaking change only from 0615 * fix patch * compile to get examples * remove sample * fix member upate operation (#25134) * revert extension removal (#25189) * generate with type spec v0.47.0 (#25484) --------- Co-authored-by: Stéphane Erbrech <[email protected]>
fix patch to only change to async from 0615-preview