Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet][Dev] API 0615 changes #25020

Merged
merged 42 commits into from
Jul 28, 2023
Merged

[Fleet][Dev] API 0615 changes #25020

merged 42 commits into from
Jul 28, 2023

Conversation

zman-ms
Copy link
Contributor

@zman-ms zman-ms commented Jul 27, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@openapi-workflow-bot
Copy link

Hi, @zman-ms! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

    • @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Jul 27, 2023
    @openapi-workflow-bot
    Copy link

    Hi @zman-ms! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh
    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @zman-ms! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

    ACTION ITEM ALTERNATIVE C: Report false positive.
    If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
    This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

    @azure-sdk azure-sdk mentioned this pull request Jul 27, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Jul 27, 2023
    Closed
    This was referenced Jul 27, 2023
    Closed
    Closed
    @zman-ms zman-ms force-pushed the zman/fleet-api-0615-changes branch from 742ab44 to e45040c Compare July 27, 2023 21:05
    @serbrech
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 25020 in repo Azure/azure-rest-api-specs

    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jul 27, 2023
    @serbrech serbrech added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 28, 2023
    @zman-ms zman-ms merged commit 36e9ac6 into dev-aks-fleet-2023-06-15-preview Jul 28, 2023
    @zman-ms zman-ms deleted the zman/fleet-api-0615-changes branch July 28, 2023 00:14
    ms-henglu pushed a commit that referenced this pull request Aug 25, 2023
    @zman-ms @serbrech
    [Fleet] API 2023-06-15-preview (#25027)
    802fc0a 
    * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview

* Updates readme

* Updates API version in new specs and examples

* [Fleet][Dev] API 0615 changes (#25020)

* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview

* Updates readme

* Updates API version in new specs and examples

* sync with ADO repo

* exclude unneeded file changes

* revert tsp config

* revert helpers.tsp

* remove package files

* remove package files

* add known word containerd

* format

* remove .npmrc

* revert custom word

* revert package-lock.json

* re-generate json

* add example

* add example

* fix read-only fields

* fix read-only fields

* re-generate json with latest compiler

* add custom word back

* re-generate json

* restore config

* add examples

* add examples

* add examples

* add examples

* add examples

* add examples

* prettier

* fix examples

* git ignore

* review commoents

* fix examples

* make node image selection optional

* fix warnings

* fix warnings

* fix warnings

* fix docs

* revert package changes

* compile

* fix tspconfig (#25031)

* [Fleet][readmes] Dev aks fleet 2023 06 15 preview readmes (#25033)

* update readmes
* fix readme mistake

* fix operationid warnings (#25109)

* tsp format (#25111)

* Fix aks fleet 2023 06 15 preview patchasync from 0615 (#25131)

* do the breaking change only from 0615

* fix patch

* compile to get examples

* remove sample

* fix member upate operation (#25134)

* revert extension removal (#25189)

* generate with type spec v0.47.0 (#25484)

---------

Co-authored-by: Stéphane Erbrech <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @serbrech serbrech serbrech approved these changes

    @palma21 palma21 Awaiting requested review from palma21

    @weinong weinong Awaiting requested review from weinong

    @alvinli222 alvinli222 Awaiting requested review from alvinli222

    @matthchr matthchr Awaiting requested review from matthchr

    @circy9 circy9 Awaiting requested review from circy9

    Assignees
    No one assigned
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @zman-ms @serbrech @AzureRestAPISpecReview