Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 03 cred scan fix - Examples Only #24357

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Jun 8, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @solankisamir Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the API Management label Jun 8, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/apimanagement/armapimanagement https://apiview.dev/Assemblies/Review/53d5f79374f94274b1a344cdea12aad3
    JavaScript @azure/arm-apimanagement https://apiview.dev/Assemblies/Review/4760fff684ed4d6abfae7a0cc77d634d

    @solankisamir
    Copy link
    Member Author

    @v-jiaodi a gentle ping on this

    @v-jiaodi v-jiaodi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 12, 2023
    @weidongxu-microsoft weidongxu-microsoft merged commit 381d174 into release-Microsoft.ApiManagement-2023-03-01-preview Jun 12, 2023
    @weidongxu-microsoft weidongxu-microsoft deleted the 2023-03-cred-scan branch June 12, 2023 05:18
    live1206 pushed a commit that referenced this pull request Jun 25, 2023
    * Adds base for updating Microsoft.ApiManagement from version preview/2022-09-01-preview to version 2023-03-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * feat(apim): Provide capability to use custom hostname for Configuration API v2 (#23785)
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * feat(rp): Added flags to enable/disable portals (#23799)
    
    * feat(rp): Added flags to enable/disable portals
    
    * update default
    
    * feat(apim): Provide capability to disable legacy configuration API  (#23786)
    
    * feat(apim): Provide capability to disable legacy configuration API
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Update sample
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Fix type definition
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Switch to enum
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Update samples
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    ---------
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * feat(apim): Add new tracing API (#23800)
    
    * Add new tracing api
    
    * Remove TODOs descriptions
    
    * Improve descriptions
    
    * Fix dot
    
    * Add missing examples
    
    * prettier fixes
    
    * Fix model and semantic problems
    
    * Remove get prefix in post operations
    
    * Use list prefix
    
    * Fix PR comments
    
    * feat(apim): Add ability to create and update new OData api (#23849)
    
    * Add odata api definitions
    
    * add api usage example
    
    * fix file reference
    
    * address comments
    
    ---------
    
    Co-authored-by: rkolesnikov <[email protected]>
    
    * migration contract (#23983)
    
    * 2023 03 cred scan fix - Examples Only (#24357)
    
    * remove-sas-signature
    
    * update example
    
    * 2023-03-01-preview arm review feedback (#24404)
    
    * move to v5 subscription contract
    
    * move to v5 for rg and api-version
    
    * cred scan
    
    * default is true
    
    * uuid in examples
    
    * change from boolean to enums
    
    * fix default value
    
    ---------
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    Co-authored-by: Tom Kerkhove <[email protected]>
    Co-authored-by: Harun Reşit <[email protected]>
    Co-authored-by: Rafał Mielowski <[email protected]>
    Co-authored-by: Roman Kolesnikov <[email protected]>
    Co-authored-by: rkolesnikov <[email protected]>
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    * Adds base for updating Microsoft.ApiManagement from version preview/2022-09-01-preview to version 2023-03-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * feat(apim): Provide capability to use custom hostname for Configuration API v2 (Azure#23785)
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * feat(rp): Added flags to enable/disable portals (Azure#23799)
    
    * feat(rp): Added flags to enable/disable portals
    
    * update default
    
    * feat(apim): Provide capability to disable legacy configuration API  (Azure#23786)
    
    * feat(apim): Provide capability to disable legacy configuration API
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Update sample
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Fix type definition
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Switch to enum
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * Update samples
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    ---------
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    
    * feat(apim): Add new tracing API (Azure#23800)
    
    * Add new tracing api
    
    * Remove TODOs descriptions
    
    * Improve descriptions
    
    * Fix dot
    
    * Add missing examples
    
    * prettier fixes
    
    * Fix model and semantic problems
    
    * Remove get prefix in post operations
    
    * Use list prefix
    
    * Fix PR comments
    
    * feat(apim): Add ability to create and update new OData api (Azure#23849)
    
    * Add odata api definitions
    
    * add api usage example
    
    * fix file reference
    
    * address comments
    
    ---------
    
    Co-authored-by: rkolesnikov <[email protected]>
    
    * migration contract (Azure#23983)
    
    * 2023 03 cred scan fix - Examples Only (Azure#24357)
    
    * remove-sas-signature
    
    * update example
    
    * 2023-03-01-preview arm review feedback (Azure#24404)
    
    * move to v5 subscription contract
    
    * move to v5 for rg and api-version
    
    * cred scan
    
    * default is true
    
    * uuid in examples
    
    * change from boolean to enums
    
    * fix default value
    
    ---------
    
    Signed-off-by: Tom Kerkhove <[email protected]>
    Co-authored-by: Tom Kerkhove <[email protected]>
    Co-authored-by: Harun Reşit <[email protected]>
    Co-authored-by: Rafał Mielowski <[email protected]>
    Co-authored-by: Roman Kolesnikov <[email protected]>
    Co-authored-by: rkolesnikov <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    2023-03-01-preview APIM 2023-03-01-preview PRs API Management Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants