Update workspaceRP swagger with automation result #24333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier
|
Hi, @ZhidaLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @ZhidaLiu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| machineLearningServices.json | 2023-06-01-preview(a566c92) | 2023-04-01(main) |
| machineLearningServices.json | 2023-06-01-preview(a566c92) | 2023-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 27 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L73:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L265:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L310:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L386:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L428:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L662:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1056:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1276:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1321:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1461:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1503:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1552:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1594:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1636:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1773:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundNetworkDependenciesEndpoints' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1823:5 |
|
The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'WorkspaceUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'WorkspacePropertiesUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'DiagnoseRequestProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'DiagnoseWorkspaceParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnection' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnectionProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'PrivateEndpoint' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
|
The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionState' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1978:3 |
The following breaking changes are detected by comparison with the latest preview version:
Only 27 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L37:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L73:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L268:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L316:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L392:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L434:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L668:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1120:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1391:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1436:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1576:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1618:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1667:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1709:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1751:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1888:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1938:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules/{ruleName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1986:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/provisionManagedNetwork' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2152:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundNetworkDependenciesEndpoints' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2215:5 |
|
| The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
|
| The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
|
| The new version is missing a definition that was found in the old version. Was 'WorkspaceUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
|
| The new version is missing a definition that was found in the old version. Was 'WorkspacePropertiesUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DiagnoseRequestProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DiagnoseWorkspaceParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
|
| The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnection' removed or renamed? New: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L942:3 Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L2395:3 |
️⚠️LintDiff: 3 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-preview-2023-06 | package-preview-2023-06(a566c92) | package-preview-2023-06(release-machinelearningservices-Microsoft.MachineLearningServices-2023-06-01-preview) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json#L2483 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json#L3506 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json#L3544 |
The following errors/warnings exist before current PR submission:
Only 27 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @ZhidaLiu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
The LintDiff Error seems wrong, I don't see any difference between the PUT body and 200 response schema. |
This was referenced Jun 7, 2023
|
@ZhidaLiu Please reach out to Azure Breaking Changes Reviewers [email protected] to get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers. |
ms-zhenhua
added
ARMSignedOff
The IValue don't have a schema and that's the point of letting it become a user-defined schema, so basically they can put as many layer as they want like this: "metadata" : { |
Update the suppression, thanks |
|
@ms-zhenhua I updated the swagger with your comment considered, but for the additionalProperties and the metadata schema, I think they are by design and reflect what we expected in our service-side code, unless you can provide a way to describe those types without changing our service-side design. Please help take a look and approve if it was fine. |
ZhidaLiu
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @ZhidaLiu, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
Is this added in this new API version only? You should fix the location header for 202. Also do you have a plan/workitem for fixing the bad pattern from existing API? Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1053 in dea1aae. [](commit_id = dea1aae, deletion_comment = False) |
zizw123
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Nope this is already exist in the older API version here, I will create a work item to update the behavior on server side |
ZhidaLiu
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Remove suppression review tag as suppression is removed |
Please have a work item for future plan to make the change in future version, you should make back-comp update on service side and take the suggested changes for your API in next version. |
zizw123
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Task 2470537: Update Metadata and new connection credential to avoid additional properties thanks, here is the work item to track on the additional property change on the server side |
zedy-wj
added
the
Approved-OkToMerge
live1206
approved these changes
Jun 14, 2023
live1206
merged commit 513739d
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-06-01-preview
11 tasks
rkmanda
pushed a commit
that referenced
this pull request
Jun 27, 2023
…to add version preview/2023-06-01-preview (#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (#24295) * update EnableNodePublicIp for computeInstance of MLC (#24231) Co-authored-by: Bingchen Li <[email protected]> * Update workspaceRP swagger with automation result (#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d8. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (#24532) --------- Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…to add version preview/2023-06-01-preview (Azure#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (Azure#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (Azure#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (Azure#24295) * update EnableNodePublicIp for computeInstance of MLC (Azure#24231) Co-authored-by: Bingchen Li <[email protected]> * Update workspaceRP swagger with automation result (Azure#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d8. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (Azure#24532) --------- Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.