[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2023-06-01-preview #24049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview/2023-04-01-preview to version 2023-06-01-preview
|
Hi, @erjms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| machineLearningServices.json | 2023-06-01-preview(3024939) | 2023-04-01(main) |
| machineLearningServices.json | 2023-06-01-preview(3024939) | 2023-04-01-preview(main) |
| mfe.json | 2023-06-01-preview(3024939) | 2023-04-01(main) |
| mfe.json | 2023-06-01-preview(3024939) | 2023-04-01-preview(main) |
| registries.json | 2023-06-01-preview(3024939) | 2023-04-01(main) |
| registries.json | 2023-06-01-preview(3024939) | 2023-04-01-preview(main) |
| workspaceFeatures.json | 2023-06-01-preview(3024939) | 2023-04-01(main) |
| workspaceFeatures.json | 2023-06-01-preview(3024939) | 2023-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 15 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L73:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L265:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L310:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L386:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L428:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L662:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1056:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1276:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1321:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1461:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1503:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1552:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1594:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-04-01/machineLearningServices.json#L1636:5 |
The following breaking changes are detected by comparison with the latest preview version:
Only 15 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L37:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L73:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L268:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L316:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L392:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L434:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L668:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1120:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1391:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1436:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1576:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1618:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1667:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1709:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-04-01-preview/machineLearningServices.json#L1751:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 28 Errors, 162 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-preview-2023-06 | package-preview-2023-06(3024939) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 15 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
The resource name parameter 'computeName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L531 |
RPC-Uri-V1-05 |
|
200 response for a synchronous POST operation must have a response schema specified. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L532 |
|
|
The resource name parameter 'computeName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L813 |
RPC-Uri-V1-05 |
|
200 response for a synchronous POST operation must have a response schema specified. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/machineLearningServices.json#L814 |
|
|
$skip is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7648 |
RPC-Post-V1-05 |
|
filters is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7648 |
RPC-Post-V1-05 |
|
featureWindowStart is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7648 |
RPC-Post-V1-05 |
|
featureWindowEnd is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7648 |
RPC-Post-V1-05 |
|
Query parameter includeJobInstructions should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L8983 |
RPC-Get-V1-08 |
|
Query parameter includeLabelCategories should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L8983 |
RPC-Get-V1-08 |
|
200 response for a synchronous POST operation must have a response schema specified. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L9208 |
|
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L9257 |
RPC-Post-V1-03 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L19344 |
|
|
Operations API path must follow the schema provided in the common types. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json#L45 |
RPC-Operations-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json#L195 |
RPC-Async-V1-07 |
The following errors/warnings exist before current PR submission:
Only 15 items are listed, please refer to log for more details.
️❌Avocado: 15 Errors, 1 Warnings failed [Detail]
Only 15 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.MachineLearningServices/locations/{}/Quotas is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.MachineLearningServices/workspaces/skus is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2022-01-01-preview/workspaceSkus.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/Microsoft.MachineLearningServices/workspaces/{}/linkedWorkspaces is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-04-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/Microsoft.MachineLearningServices/workspaces/{}/linkedWorkspaces/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-04-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/linkedWorkspaces is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-05-15-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/linkedWorkspaces/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-05-15-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/services is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/services/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/datasets is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/datasets/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/linkedServices is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/linkedServices/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/computes/{}/updateSchedules is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/featuresets/{}/versions/{}/getFeature is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.MachineLearningServices/workspaces/{}/featuresets/{}/versions/{}/listFeatures is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @erjms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced May 18, 2023
* Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @erjms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
erjms
removed
WaitForARMFeedback
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Sounds good, there's a lot error in the lintDiff, you should still see if there's anything you can fix as of the current version, only for those you couldn't fix you can leave the fix and track them in next version |
zizw123
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Many of the errors are pre-existing from previous API versions and are not introduced by this PR. For example, the following
We do not understand why it is getting flagged as a new error here. Nevertheless, we did evaluate all of the errors, and determined that the remaining ones cannot be fixed in this version, either because fixing would introduce unplanned breaking changes (as would be the case with the pre-existing errors) or would require significant changes to the service (e.g., to fix the url query parameter errors). This is why we have committed to fixing in the next API version instead of this one. I provided links to our tasks to track these fixes in this comment: |
erjms
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-henglu
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run unifiedPipeline |
|
Pull request contains merge conflicts. |
ms-henglu
approved these changes
Jun 23, 2023
…chineLearningServices-2023-06-01-preview
|
Hi @erjms! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
raych1
added
the
Approved-SdkBreakingChange-Go
|
Approving Avocado failure based on this comment from Erik Roopesh Manda here is a comment from a previous API version detailing why some of the avocado errors were suppressed: |
rkmanda
deleted the
release-machinelearningservices-Microsoft.MachineLearningServices-2023-06-01-preview
branch
This was referenced Jun 27, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…to add version preview/2023-06-01-preview (Azure#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (Azure#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (Azure#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (Azure#24295) * update EnableNodePublicIp for computeInstance of MLC (Azure#24231) Co-authored-by: Bingchen Li <[email protected]> * Update workspaceRP swagger with automation result (Azure#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d8. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (Azure#24532) --------- Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.