Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostgreSQL] New api version 2023-03-01-preview - Migrations API property update, enum values update. Network property changes ported. #24087

Conversation

ambrahma
Copy link
Member

@ambrahma ambrahma commented May 22, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • [X ] new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. Added fix for network property update from the earlier version to new api version 2023-03-01-preview for which SDK is not yet published.

  3. Migrations api enum property values are being updated from Enabled / Disabled to True / False.

  4. Added 2 new string properties to SecretParameters object for Migrations api.

Added breaking change review => Scenario 23568995: [PostgreSQL] Breaking changes - Add changes to new preview api version for which there is no SDK yet

  1. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  2. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. ASAP
  3. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ambrahma Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 22, 2023

    Swagger Validation Report

    ️❌BreakingChange: 26 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    Capabilities.json 2023-03-01-preview(9a40c23) 2023-03-01-preview(main)
    FlexibleServers.json 2023-03-01-preview(9a40c23) 2023-03-01-preview(main)
    Migrations.json 2023-03-01-preview(9a40c23) 2023-03-01-preview(main)
    Rule Message
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Capabilities.json#L388:11
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Capabilities.json#L388:11
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L416:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L410:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L428:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L422:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L450:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L444:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L462:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L456:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L481:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L475:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L567:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L561:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L579:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L573:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L596:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L590:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L608:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L602:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Enabled, Disabled' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L627:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L621:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L416:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L410:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L428:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L422:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L450:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L444:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L462:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L456:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L481:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L475:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L567:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L561:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L579:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L573:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L596:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L590:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L608:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L602:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'True, False' from the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L627:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L621:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L986:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L985:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L997:9
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L1001:9
    1045 - AddedOptionalProperty The new version has a new optional property 'network' that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L578:7
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L582:7
    1045 - AddedOptionalProperty The new version has a new optional property 'sourceServerUsername' that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L658:7
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L652:7
    1045 - AddedOptionalProperty The new version has a new optional property 'targetServerUsername' that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L658:7
    Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L652:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-flexibleserver-2023-03-01-preview package-flexibleserver-2023-03-01-preview(9a40c23) package-flexibleserver-2023-03-01-preview(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L38
    ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L38
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L90
    ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L170
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Capabilities.json#L38
    ⚠️ GetInOperationName 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Capabilities.json#L42
    ⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L222
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L576
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L52
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L52
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L110
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L110
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L156
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L156
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L208
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L208
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L253
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L253
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L303
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L303
    ⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L717
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/Migrations.json#L886
    ️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
    Rule Message
    MULTIPLE_DEFAULT_TAGS The readme file has more than one default tag.
    readme: specification/postgresql/resource-manager/readme.md
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 22, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/postgresql/armpostgresqlflexibleservers - Approved - 4.0.0-beta.1
    +	Field `IsBaseline`, `TierName` of struct `StorageTierCapability` has been removed
    +	Field `SupportedServerVersions` of struct `FlexibleServerEditionCapability` has been removed
    +	Field `SupportedStorageMB` of struct `StorageEditionCapability` has been removed
    +	Field `SupportedVcores` of struct `ServerVersionCapability` has been removed
    +	Struct `CapabilityProperties` has been removed
    +	Struct `HyperscaleNodeEditionCapability` has been removed
    +	Struct `NodeTypeCapability` has been removed
    +	Struct `StorageMBCapability` has been removed
    +	Struct `VcoreCapability` has been removed
    +	Type of `CapabilitiesListResult.Value` has been changed from `[]*CapabilityProperties` to `[]*FlexibleServerCapability`
    +	Type of `FastProvisioningEditionCapability.SupportedStorageGb` has been changed from `*int64` to `*int32`
    +	Type of `FlexibleServerEditionCapability.Status` has been changed from `*string` to `*CapabilityStatus`
    +	Type of `ServerVersionCapability.Status` has been changed from `*string` to `*CapabilityStatus`
    +	Type of `StorageEditionCapability.Status` has been changed from `*string` to `*CapabilityStatus`
    +	Type of `StorageTierCapability.Iops` has been changed from `*int64` to `*int32`
    +	Type of `StorageTierCapability.Status` has been changed from `*string` to `*CapabilityStatus`
    +	`IdentityTypeSystemAssigned` from enum `IdentityType` has been removed

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 737ebd8. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.PostgreSql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerKeyType Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerKeyType.SystemAssigned.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.GeoSyncReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.Secondary.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.SyncReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.WalReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.PostgreSql/Debug/netstandard2.0/Azure.ResourceManager.PostgreSql.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 737ebd8. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes]
      info	[Changelog] change log generation failed!!!
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 737ebd8. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/postgresql/armpostgresql [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/postgresql/armpostgresqlflexibleservers [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `*ClientFactory.NewPostgreSQLManagementClient() *PostgreSQLManagementClient`
      info	[Changelog] - New function `*ClientFactory.NewServerCapabilitiesClient() *ServerCapabilitiesClient`
      info	[Changelog] - New function `NewFlexibleServerClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FlexibleServerClient, error)`
      info	[Changelog] - New function `*FlexibleServerClient.BeginStartLtrBackup(context.Context, string, string, LtrBackupRequest, *FlexibleServerClientBeginStartLtrBackupOptions) (*runtime.Poller[FlexibleServerClientStartLtrBackupResponse], error)`
      info	[Changelog] - New function `*FlexibleServerClient.TriggerLtrPreBackup(context.Context, string, string, LtrPreBackupRequest, *FlexibleServerClientTriggerLtrPreBackupOptions) (FlexibleServerClientTriggerLtrPreBackupResponse, error)`
      info	[Changelog] - New function `NewLogFilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LogFilesClient, error)`
      info	[Changelog] - New function `*LogFilesClient.NewListByServerPager(string, string, *LogFilesClientListByServerOptions) *runtime.Pager[LogFilesClientListByServerResponse]`
      info	[Changelog] - New function `NewLtrBackupOperationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LtrBackupOperationsClient, error)`
      info	[Changelog] - New function `*LtrBackupOperationsClient.Get(context.Context, string, string, string, *LtrBackupOperationsClientGetOptions) (LtrBackupOperationsClientGetResponse, error)`
      info	[Changelog] - New function `*LtrBackupOperationsClient.NewListByServerPager(string, string, *LtrBackupOperationsClientListByServerOptions) *runtime.Pager[LtrBackupOperationsClientListByServerResponse]`
      info	[Changelog] - New function `NewMigrationsClient(azcore.TokenCredential, *arm.ClientOptions) (*MigrationsClient, error)`
      info	[Changelog] - New function `*MigrationsClient.Create(context.Context, string, string, string, string, MigrationResource, *MigrationsClientCreateOptions) (MigrationsClientCreateResponse, error)`
      info	[Changelog] - New function `*MigrationsClient.Delete(context.Context, string, string, string, string, *MigrationsClientDeleteOptions) (MigrationsClientDeleteResponse, error)`
      info	[Changelog] - New function `*MigrationsClient.Get(context.Context, string, string, string, string, *MigrationsClientGetOptions) (MigrationsClientGetResponse, error)`
      info	[Changelog] - New function `*MigrationsClient.NewListByTargetServerPager(string, string, string, *MigrationsClientListByTargetServerOptions) *runtime.Pager[MigrationsClientListByTargetServerResponse]`
      info	[Changelog] - New function `*MigrationsClient.Update(context.Context, string, string, string, string, MigrationResourceForPatch, *MigrationsClientUpdateOptions) (MigrationsClientUpdateResponse, error)`
      info	[Changelog] - New function `PossibleStorageAutoGrowValues() []StorageAutoGrow`
      info	[Changelog] - New function `NewPostgreSQLManagementClient(azcore.TokenCredential, *arm.ClientOptions) (*PostgreSQLManagementClient, error)`
      info	[Changelog] - New function `*PostgreSQLManagementClient.CheckMigrationNameAvailability(context.Context, string, string, string, MigrationNameAvailabilityResource, *PostgreSQLManagementClientCheckMigrationNameAvailabilityOptions) (PostgreSQLManagementClientCheckMigrationNameAvailabilityResponse, error)`
      info	[Changelog] - New function `NewServerCapabilitiesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServerCapabilitiesClient, error)`
      info	[Changelog] - New function `*ServerCapabilitiesClient.NewListPager(string, string, *ServerCapabilitiesClientListOptions) *runtime.Pager[ServerCapabilitiesClientListResponse]`
      info	[Changelog] - New struct `AdminCredentials`
      info	[Changelog] - New struct `BackupSettings`
      info	[Changelog] - New struct `BackupStoreDetails`
      info	[Changelog] - New struct `DbServerMetadata`
      info	[Changelog] - New struct `FlexibleServerCapability`
      info	[Changelog] - New struct `LogFile`
      info	[Changelog] - New struct `LogFileListResult`
      info	[Changelog] - New struct `LogFileProperties`
      info	[Changelog] - New struct `LtrBackupOperationResponseProperties`
      info	[Changelog] - New struct `LtrBackupRequest`
      info	[Changelog] - New struct `LtrBackupResponse`
      info	[Changelog] - New struct `LtrPreBackupRequest`
      info	[Changelog] - New struct `LtrPreBackupResponse`
      info	[Changelog] - New struct `LtrPreBackupResponseProperties`
      info	[Changelog] - New struct `LtrServerBackupOperation`
      info	[Changelog] - New struct `LtrServerBackupOperationList`
      info	[Changelog] - New struct `MigrationNameAvailabilityResource`
      info	[Changelog] - New struct `MigrationResource`
      info	[Changelog] - New struct `MigrationResourceForPatch`
      info	[Changelog] - New struct `MigrationResourceListResult`
      info	[Changelog] - New struct `MigrationResourceProperties`
      info	[Changelog] - New struct `MigrationResourcePropertiesForPatch`
      info	[Changelog] - New struct `MigrationSecretParameters`
      info	[Changelog] - New struct `MigrationStatus`
      info	[Changelog] - New struct `MigrationSubStateDetails`
      info	[Changelog] - New struct `ServerSKU`
      info	[Changelog] - New struct `ServerSKUCapability`
      info	[Changelog] - New struct `StorageMbCapability`
      info	[Changelog] - New field `GeoBackupEncryptionKeyStatus`, `GeoBackupKeyURI`, `GeoBackupUserAssignedIdentityID`, `PrimaryEncryptionKeyStatus` in struct `DataEncryption`
      info	[Changelog] - New field `Reason`, `ServerCount`, `Status`, `SupportedTier` in struct `FastProvisioningEditionCapability`
      info	[Changelog] - New field `DefaultSKUName`, `Reason`, `SupportedServerSKUs` in struct `FlexibleServerEditionCapability`
      info	[Changelog] - New field `Network` in struct `ServerPropertiesForUpdate`
      info	[Changelog] - New field `Reason` in struct `ServerVersionCapability`
      info	[Changelog] - New field `AutoGrow`, `Iops`, `IopsTier` in struct `Storage`
      info	[Changelog] - New field `DefaultStorageSizeMb`, `Reason`, `SupportedStorageMb` in struct `StorageEditionCapability`
      info	[Changelog] - New field `Reason` in struct `StorageTierCapability`
      info	[Changelog] - New field `TenantID` in struct `UserAssignedIdentity`
      info	[Changelog]
      info	[Changelog] Total 21 breaking change(s), 188 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 737ebd8. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 737ebd8. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      Server Error
      HttpError: Server Error
          at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@[email protected][email protected]/node_modules/@octokit/request/dist-node/index.js:86:21
          at processTicksAndRejections (node:internal/process/task_queues:96:5)
          at async workflowPkgUpdatePR (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:377:9)
          at async Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:63:5)
          at async workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:216:9)
          at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:98:13)
          at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:191:13)
          at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️postgresql [View full logs
      error	Fatal error: Server Error
      error	The following packages are still pending:
      error		postgresql
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 737ebd8. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.postgresql.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.postgresql.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the PostgreSQL label May 22, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 22, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
    Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers https://apiview.dev/Assemblies/Review/8f752a3e8e7345cda0f5c703312e65b9
    Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/aab7b65e4d9b4d54a6092881a6e4fc3e
    .Net Azure.ResourceManager.PostgreSql https://apiview.dev/Assemblies/Review/813c0e343c1e44a0a4451be0dc5ebc0a

    @openapi-workflow-bot
    Copy link

    Hi @ambrahma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @ambrahma ambrahma changed the title {PostgreSQL] Port network property fix from api version 2022-12-01 to 2023-03-01-p… [PostgreSQL] Port network property fix from api version 2022-12-01 to 2023-03-01-p… May 22, 2023
    @ambrahma ambrahma changed the title [PostgreSQL] Port network property fix from api version 2022-12-01 to 2023-03-01-p… [PostgreSQL] New api version 2023-03-01-preview - Migrations API property update, enum values update. Network property chages ported. May 22, 2023
    @ambrahma ambrahma marked this pull request as ready for review May 22, 2023 14:39
    @ambrahma
    Copy link
    Member Author

    Hi @ambrahma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Added breaking change review => Scenario 23568995: [PostgreSQL] Breaking changes - Add changes to new preview api version for which there is no SDK yet

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 22, 2023
    @ankhyk ankhyk added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023
    @ankhyk ankhyk removed the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023
    @ambrahma ambrahma changed the title [PostgreSQL] New api version 2023-03-01-preview - Migrations API property update, enum values update. Network property chages ported. [PostgreSQL] New api version 2023-03-01-preview - Migrations API property update, enum values update. Network property changes ported. May 23, 2023
    @openapi-workflow-bot
    Copy link

    Hi @ambrahma, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 23, 2023
    @ankhyk
    Copy link
    Contributor

    ankhyk commented May 23, 2023

    @konrad-jamrozik can we approve the Avocado error?

    @konrad-jamrozik
    Copy link

    @konrad-jamrozik Konrad Jamrozik FTE can we approve the Avocado error?

    Avocado provides guidance how to address failures it reported, here:

    @ambrahma can you follow the guidance provided above and if you think it is incorrect or doesn't apply, clarify why? Thanks!

    @ambrahma
    Copy link
    Member Author

    @konrad-jamrozik Konrad Jamrozik FTE can we approve the Avocado error?

    Avocado provides guidance how to address failures it reported, here:

    @ambrahma can you follow the guidance provided above and if you think it is incorrect or doesn't apply, clarify why? Thanks!

    Guidance says that I need to consult API review team (which is essentially a group I need to join and get approval) to take up this change. I am worried how long will this take overall for approval etc. The fixes in this PR are required for SDK release for api version 2023-03-01-preview and I do not want to miss current cycle. I am also checking with my team if this is ok and what will be implications for the end users who would already be using the same SDK for different services?

    @ambrahma
    Copy link
    Member Author

    ambrahma commented May 24, 2023

    @konrad-jamrozik Konrad Jamrozik FTE can we approve the Avocado error?

    Avocado provides guidance how to address failures it reported, here:

    @ambrahma can you follow the guidance provided above and if you think it is incorrect or doesn't apply, clarify why? Thanks!

    Guidance says that I need to consult API review team (which is essentially a group I need to join and get approval) to take up this change. I am worried how long will this take overall for approval etc. The fixes in this PR are required for SDK release for api version 2023-03-01-preview and I do not want to miss current cycle. I am also checking with my team if this is ok and what will be implications for the end users who would already be using the same SDK for different services?

    hi @konrad-jamrozik , I have started another PR #24142 for this folder structure change. Basically we want to make sure that same python SDK gets generated for both postgresql single server and postgresql flexible server. This is to avoid downstream issues like letting customers know that there is separate (python SDK) package created for postgresql flexible server vs single server. Also then we need to worry about consuming multiple packages for CLI as currently even our CLI releases are couple together. Moreover currently MySQL single server and MySQL flexible servers are also using same packages. This would be a bigger item. Hence requesting you to allow this current PR to be merged manually, while the issues get ironed out in another PR. Also this will ensure that we do not miss the deadline for the current SDK release and make packages and CLI available to our end users as per our commitments

    @xiaoxuqi-ms
    Copy link
    Member

    Hi @konrad-jamrozik , thanks for reviewing this pr, however, the multiple tag is not introduced in this pr, we support both single server and flexible server so we have two tags for both scenario. Could you kindly help to approve this avocado errors? Many thanks.

    @konrad-jamrozik
    Copy link

    @rkmanda @weshaggard can you advise with priority?

    @weshaggard
    Copy link
    Member

    @ambrahma I'm going to merge your PR but please continue your work on fixing the errors otherwise this will continue to come up and eventually end up blocking you.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-FixRequiredOnFailure PostgreSQL resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants