[PostgreSQL] Fix S360 violations for postgresql flexible servers api version 2022-12-01 #24062

ambrahma · 2023-05-19T05:39:13Z

Fix S360 violations for postgresql flexible servers api version 2022-12-01

Breaking change review: https://msazure.visualstudio.com/One/_workitems/edit/23531356

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- [X ] update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
[X ] I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…o be part of read operation, as this field is returned for replica servers

openapi-workflow-bot · 2023-05-19T05:39:16Z

Hi, @ambrahma Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-05-19T05:39:17Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
FlexibleServers.json	2023-03-01-preview(7114320)	2023-03-01-preview(main)
FlexibleServers.json	2022-12-01(7114320)	2022-12-01(main)

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L514:9 Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L513:9
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'tenantId' that was not found in the old version. New: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L897:7 Old: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L897:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'tenantId' that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L814:7 Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L812:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.2)	new version	base version
package-flexibleserver-2022-12-01	package-flexibleserver-2022-12-01(7114320)	package-flexibleserver-2022-12-01(main)
package-flexibleserver-2023-03-01-preview	package-flexibleserver-2023-03-01-preview(7114320)	package-flexibleserver-2023-03-01-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ProvisioningStateSpecifiedForLROPut	200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L38
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L38
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L90
`❌` ProvisioningStateSpecifiedForLROPatch	200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L170
`❌` ProvisioningStateSpecifiedForLROPut	200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L38
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L38
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L87
`❌` ProvisioningStateSpecifiedForLROPatch	200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L167
⚠️ ProvisioningStateSpecifiedForLRODelete	200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L222
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.DBforPostgreSQL/preview/2023-03-01-preview/FlexibleServers.json#L580
⚠️ ProvisioningStateSpecifiedForLRODelete	200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L219
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L572

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-19T05:39:18Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 15589d6. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.PostgreSql [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.PostgreSql.1.2.0-alpha.20230524.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerKeyType Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerKeyType.SystemAssigned.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.GeoSyncReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.Secondary.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.SyncReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.WalReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.PostgreSql/Debug/netstandard2.0/Azure.ResourceManager.PostgreSql.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0]

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 15589d6. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'FirewallRule' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from FirewallRule
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'Server' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Server
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   | Batch/Error | Failure during batch task - {"tag":"package-flexibleserver-2023-03-01-preview"}  -- Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'FirewallRule' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from FirewallRule
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'Server' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Server
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   | Batch/Error | Failure during batch task - {"tag":"package-flexibleserver-2023-03-01-preview"}  -- Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 15589d6. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-postgresqlflexibleserver [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 15589d6. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/postgresql/armpostgresql [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/postgresql/armpostgresqlflexibleservers [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - `IdentityTypeSystemAssigned` from enum `IdentityType` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Network` in struct `ServerPropertiesForUpdate`
info	[Changelog] - New field `TenantID` in struct `UserAssignedIdentity`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 2 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 15589d6. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 15589d6. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️postgresql [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 15589d6. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.postgresql.DefaultTag [View full logs]

Az.PostgreSql.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.postgresql.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-19T05:39:19Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/postgresql/armpostgresqlflexibleservers	https://apiview.dev/Assemblies/Review/feefedd8c8d449cd9a755ca8b05ed5f3
.Net	Azure.ResourceManager.PostgreSql	https://apiview.dev/Assemblies/Review/21c9787b890a4231ac96cf200554c092
Java	azure-resourcemanager-postgresqlflexibleserver	https://apiview.dev/Assemblies/Review/aca5fb4d5b3f402bb89a43bf26a11c8c

openapi-workflow-bot · 2023-05-19T06:59:04Z

The automation detected this Pull Request introduces breaking changes to an existing API version and hence it added the NewApiVersionRequired label. This means you cannot proceed with merging this PR until you complete one of the following action items:

- A) Submit a new PR instead of this one, or modify this PR, so that it introduces a new API version instead of introducing breaking changes to an existing API version. The automation will remove the label once it detects there are no more breaking changes.
- B) OR you can request an approval of the breaking changes, get it reviewed, and approved. The reviewer will add Approved-BreakingChange label if they approve.

For additional guidance, please see https://aka.ms/NewApiVersionRequired

… PUT. Add missing sourceServerResourceId in response for replica operation

openapi-workflow-bot · 2023-05-22T06:47:15Z

Hi @ambrahma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

…into ambrahma/fix-s360-postrgresql-flexible-server-2022-12-01

ambrahma · 2023-05-23T09:19:11Z

azp /run

ambrahma · 2023-05-23T09:20:12Z

/azp run

azure-pipelines · 2023-05-23T09:20:21Z

Azure Pipelines successfully started running 1 pipeline(s).

ankhyk · 2023-05-23T09:32:56Z

@msyyc please take a look at python SDK breaking change

msyyc · 2023-05-24T02:12:15Z

Python generation failure is not caused by this PR and will be fixed by #24087.

…l flexible servers api version 2022-12-01 (#2817) Create to sync Azure/azure-rest-api-specs#24062 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/postgresql?expand=1)

Fix S360 - Allow sourceServerResourceId as one of the field allowed t…

1936b2b

…o be part of read operation, as this field is returned for replica servers

ghost added the PostgreSQL label May 19, 2023

AzureRestAPISpecReview added the resource-manager label May 19, 2023

Allow tenantId to be passed and returned for identity

1007f39

AzureRestAPISpecReview added the NewApiVersionRequired label May 19, 2023

ambrahma added 2 commits May 19, 2023 14:41

Update tenantId as read only property

307a170

Fix S360 for replicaCapacity returned only in response but not set in…

3665051

… PUT. Add missing sourceServerResourceId in response for replica operation

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed NewApiVersionRequired labels May 22, 2023

ambrahma marked this pull request as ready for review May 22, 2023 07:01

openapi-assignment-bot bot assigned ankhyk May 22, 2023

ambrahma assigned pradeepkintali and QingqingYuan2 May 22, 2023

ambrahma added 2 commits May 22, 2023 12:33

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

7e270b0

…into ambrahma/fix-s360-postrgresql-flexible-server-2022-12-01

Fix S360 breaking change in new version 2023-03-01-preview

7114320

ambrahma unassigned QingqingYuan2 and pradeepkintali May 22, 2023

ambrahma requested a review from QingqingYuan2 May 22, 2023 14:24

ambrahma requested review from pradeepkintali and DaeunYim May 22, 2023 14:24

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 22, 2023

ankhyk added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023

ankhyk approved these changes May 23, 2023

View reviewed changes

ankhyk removed the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023

ankhyk added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 24, 2023

ArcturusZhang approved these changes May 24, 2023

View reviewed changes

ArcturusZhang merged commit 15589d6 into main May 24, 2023

ArcturusZhang deleted the ambrahma/fix-s360-postrgresql-flexible-server-2022-12-01 branch May 24, 2023 07:10

openapi-pipeline-app bot added the CI-BreakingChange-Go label May 24, 2023

myc2h6o mentioned this pull request May 31, 2023

azurerm_postgresql_flexible_server - fix identity hashicorp/terraform-provider-azurerm#21979

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PostgreSQL] Fix S360 violations for postgresql flexible servers api version 2022-12-01 #24062

[PostgreSQL] Fix S360 violations for postgresql flexible servers api version 2022-12-01 #24062

ambrahma commented May 19, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 19, 2023

openapi-pipeline-app bot commented May 19, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 19, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented May 19, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 19, 2023

openapi-workflow-bot bot commented May 22, 2023

ambrahma commented May 23, 2023

ambrahma commented May 23, 2023

azure-pipelines bot commented May 23, 2023

ankhyk commented May 23, 2023

msyyc commented May 24, 2023 •

edited

Loading

[PostgreSQL] Fix S360 violations for postgresql flexible servers api version 2022-12-01 #24062

[PostgreSQL] Fix S360 violations for postgresql flexible servers api version 2022-12-01 #24062

Conversation

ambrahma commented May 19, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 19, 2023

openapi-pipeline-app bot commented May 19, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 19, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented May 19, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented May 19, 2023

openapi-workflow-bot bot commented May 22, 2023

ambrahma commented May 23, 2023

ambrahma commented May 23, 2023

azure-pipelines bot commented May 23, 2023

ankhyk commented May 23, 2023

msyyc commented May 24, 2023 • edited Loading

ambrahma commented May 19, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 19, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 19, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 19, 2023 •

edited

Loading

msyyc commented May 24, 2023 •

edited

Loading