add event trigger for Container Jobs 2023-04-01-preview #23724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @tdaroly Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/957f3f2e737f28ec77ad15e9ab74596907df254a/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/cross-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Schema violation: Array is too short (0), minimum 1\n - file:///mnt/vss/_work/1/cross-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json:791:6 ($.definitions.Job.required)\nFATAL: swagger-document/individual/schema-validator - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.\n" |
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2023-04 | package-preview-2023-04(957f3f2) | package-preview-2023-04(release-app-Microsoft.App-2023-04-01-preview) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L25 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L64 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L106 |
|
| The summary and description values should not be same. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L145 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L152 |
|
| The summary and description values should not be same. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L212 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L219 |
|
| The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L269 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L276 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L340 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L408 |
|
| Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L466 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L472 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L540 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L597 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L755 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L831 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L833 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @tdaroly, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 25, 2023
weidongxu-microsoft
approved these changes
Apr 26, 2023
weidongxu-microsoft
merged commit f8b4b9a
into
release-app-Microsoft.App-2023-04-01-preview
| @@ -706,6 +709,21 @@ | |||
| } | |||
| } | |||
| }, | |||
| "eventTriggerConfig": { | |||
| "type": "object", | |||
| "description": "Manual trigger configuration for a single execution job. Properties replicaCompletionCount and parallelism would be set to 1 by default", | |||
There was a problem hiding this comment.
Event trigger configuration
There was a problem hiding this comment.
no, we need to match rp and other trigger configs
There was a problem hiding this comment.
@tdaroly check the description, it mentions "Manual trigger configuration" instead of "Event trigger configuration". I know that the property name needs to match RP but the description here is copy+paste from manualTriggerConfig.
| @@ -199,6 +199,9 @@ | |||
| "x-ms-examples": { | |||
| "Create or Update Container Apps Job": { | |||
| "$ref": "./examples/Job_CreateorUpdate.json" | |||
| }, | |||
| "Create or Update Container Apps Job With Event Driver Trigger": { | |||
| { | ||
| "name": "httpscalingrule", | ||
| "custom": { | ||
| "type": "http", |
There was a problem hiding this comment.
I don't think we would support scale-type http for event driven jobs, since we don't support ingress to jobs yet. Maybe, add an example with a different scale type?
There was a problem hiding this comment.
what are the scale types we are supporting ? We should also make a change in rp then since the object for Scale used in rp uses all validations ....
There was a problem hiding this comment.
@tdaroly this is the spec for Scale which is being reused with jobs, I believe the validation for what types are compatible with jobs, should be done on the CP.
...nager/Microsoft.App/preview/2023-04-01-preview/examples/Job_CreateorUpdate_EventTrigger.json
Show resolved
Hide resolved
...nager/Microsoft.App/preview/2023-04-01-preview/examples/Job_CreateorUpdate_EventTrigger.json
Show resolved
Hide resolved
tadelesh
pushed a commit
that referenced
this pull request
May 26, 2023
* Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * support terminationGracePeriodSeconds (#23476) * Support SubPath in volume mount and mount options for azure file volume (#23496) * Support SubPath in volume mount and mount options for azure file volume * update description * Add replica/container running state (#23617) * add replica/container running state * spell error fix * add event trigger for Container Jobs 2023-04-01-preview (#23724) * add event trigger for Container Jobs 2023-04-01-preview * prettier and avocado fix --------- Co-authored-by: Taher Darolywala <[email protected]> * Resolve Comments for Event driven jobs (#23729) * Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <[email protected]> * Swagger change for mtls and runningState (#23767) * 1. Add mtls properties for managed ManagedEnvironment 2. Add running state for Revision * fix * Add ContainerApp Start/Stop for 2023-04-01-preview (#23497) * Add ContainerApp Start/Stop for 2023-04-01-preview * Fix validation error * Fix validation error * Change example to add location in header * Fix lint error * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Add new source controls properties (#23891) * Add new source controls properties * Update examples * fix examples * Change event trigger replica properties to executions, add polling in… (#23810) * Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs * Fix validation errors * code review comments * Fix formatting errors * Code review comments * Add single execution history endpoint, refactor copy paste code for j… (#23816) * Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters * Fix validation errors from ARM * Fix validation errors * Code review comments * Fix validation error * code review comments from Anand * Add springboard properties (#23932) * Add springboard properties * CR comments * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <[email protected]> * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <[email protected]> --------- Co-authored-by: Jitin John <[email protected]> * Fix Lint issues in ContainerApps.json (#24107) * Fix lint issue * Fix format issue * Fix json format issue * Fix model validation * Fix lint error * fix param (#24166) Co-authored-by: Chenghui Yu <[email protected]> --------- Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> Co-authored-by: Taher Daroly <[email protected]> Co-authored-by: Taher Darolywala <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: Zijian-Ju <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]> Co-authored-by: trajkobal <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Jitin John <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.