Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support terminationGracePeriodSeconds for container app #23476

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Apr 7, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @njuCZ Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 7, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail] The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/f8c5ea9d1206c2838ef1fb7ffa48bc7cd56917c5/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/CommonDefinitions.json",
    "details":"Command failed: dotnet "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/@azure/oad/dlls/OpenApiDiff.dll" -o /tmp/old-resolved.json -n /tmp/new-resolved.json\nYou must install or update .NET to run this application.
    App: /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/@azure/oad/dlls/OpenApiDiff.dll\nArchitecture: x64\nFramework: 'Microsoft.NETCore.App',
    version '3.1.0' (x64)\n.NET location: /usr/share/dotnet/
    The following frameworks were found:\n 6.0.15 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]\n 7.0.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
    Learn about framework resolution:\nhttps://aka.ms/dotnet/app-launch-failed
    To install missing framework,
    download:\nhttps://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.20.04-x64\n"


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/f8c5ea9d1206c2838ef1fb7ffa48bc7cd56917c5/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/CommonDefinitions.json",
    "details":"Command failed: dotnet "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/@azure/oad/dlls/OpenApiDiff.dll" -o /tmp/old-resolved.json -n /tmp/new-resolved.json\nYou must install or update .NET to run this application.
    App: /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.49/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/@azure/oad/dlls/OpenApiDiff.dll\nArchitecture: x64\nFramework: 'Microsoft.NETCore.App',
    version '3.1.0' (x64)\n.NET location: /usr/share/dotnet/
    The following frameworks were found:\n 6.0.15 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]\n 7.0.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
    Learn about framework resolution:\nhttps://aka.ms/dotnet/app-launch-failed
    To install missing framework,
    download:\nhttps://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.20.04-x64\n"
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-04 package-preview-2023-04(f8c5ea9) package-preview-2023-04(release-app-Microsoft.App-2023-04-01-preview)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L720
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L729
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L893
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L896
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L965
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L1023
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json#L1026
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 7, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 2.0.0-beta.3
    +	Field `BillingMeterCategory` of struct `AvailableWorkloadProfileProperties` has been removed
    +	Field `OutboundSettings` of struct `VnetConfiguration` has been removed
    +	Field `RuntimeSubnetID` of struct `VnetConfiguration` has been removed
    +	Field `SKU` of struct `ManagedEnvironment` has been removed
    +	Field `WorkloadProfileType` of struct `ContainerAppProperties` has been removed
    +	Struct `EnvironmentSKUProperties` has been removed
    +	Struct `ManagedEnvironmentOutboundSettings` has been removed
    +	Type alias `Category` has been removed
    +	Type alias `ManagedEnvironmentOutBoundType` has been removed
    +	Type alias `SKUName` has been removed
    +	Type of `BillingMeterProperties.Category` has been changed from `*Category` to `*string`
    +	Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
    +	Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`
    ⚠️azure-sdk-for-js - @azure/arm-appcontainers - 2.0.0-beta.3
    +	Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
    +	Interface VnetConfiguration no longer has parameter runtimeSubnetId
    +	Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
    +	Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-appcontainers - 2.0.0
    +	Model AvailableWorkloadProfileProperties no longer has parameter billing_meter_category
    +	Model ContainerApp no longer has parameter workload_profile_type
    +	Model ManagedEnvironment no longer has parameter sku
    +	Model VnetConfiguration no longer has parameter outbound_settings
    +	Model VnetConfiguration no longer has parameter runtime_subnet_id
    +	Model WorkloadProfile has a new required parameter name
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 1c397e9e053a4240124934902030ada98a3301b7. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group JobsExecutionsOperations
      info	[Changelog]   - Added operation group JobsOperations
      info	[Changelog]   - Added operation group ManagedCertificatesOperations
      info	[Changelog]   - Model AvailableWorkloadProfileProperties has a new parameter category
      info	[Changelog]   - Model ContainerApp has a new parameter managed_by
      info	[Changelog]   - Model ContainerApp has a new parameter workload_profile_name
      info	[Changelog]   - Model ContainerAppSecret has a new parameter identity
      info	[Changelog]   - Model ContainerAppSecret has a new parameter key_vault_url
      info	[Changelog]   - Model Ingress has a new parameter sticky_sessions
      info	[Changelog]   - Model ManagedEnvironment has a new parameter dapr_configuration
      info	[Changelog]   - Model ManagedEnvironment has a new parameter infrastructure_resource_group
      info	[Changelog]   - Model ManagedEnvironment has a new parameter keda_configuration
      info	[Changelog]   - Model Secret has a new parameter identity
      info	[Changelog]   - Model Secret has a new parameter key_vault_url
      info	[Changelog]   - Model Template has a new parameter termination_grace_period_seconds
      info	[Changelog]   - Model Volume has a new parameter secrets
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model AvailableWorkloadProfileProperties no longer has parameter billing_meter_category
      info	[Changelog]   - Model ContainerApp no longer has parameter workload_profile_type
      info	[Changelog]   - Model ManagedEnvironment no longer has parameter sku
      info	[Changelog]   - Model VnetConfiguration no longer has parameter outbound_settings
      info	[Changelog]   - Model VnetConfiguration no longer has parameter runtime_subnet_id
      info	[Changelog]   - Model WorkloadProfile has a new required parameter name
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 1c397e9e053a4240124934902030ada98a3301b7. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `BillingMeterProperties.Category` has been changed from `*Category` to `*string`
      info	[Changelog] - Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
      info	[Changelog] - Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`
      info	[Changelog] - Type alias `Category` has been removed
      info	[Changelog] - Type alias `ManagedEnvironmentOutBoundType` has been removed
      info	[Changelog] - Type alias `SKUName` has been removed
      info	[Changelog] - Struct `EnvironmentSKUProperties` has been removed
      info	[Changelog] - Struct `ManagedEnvironmentOutboundSettings` has been removed
      info	[Changelog] - Field `BillingMeterCategory` of struct `AvailableWorkloadProfileProperties` has been removed
      info	[Changelog] - Field `WorkloadProfileType` of struct `ContainerAppProperties` has been removed
      info	[Changelog] - Field `SKU` of struct `ManagedEnvironment` has been removed
      info	[Changelog] - Field `OutboundSettings` of struct `VnetConfiguration` has been removed
      info	[Changelog] - Field `RuntimeSubnetID` of struct `VnetConfiguration` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `StorageTypeSecret` added to enum type `StorageType`
      info	[Changelog] - New enum type `Affinity` with values `AffinityNone`, `AffinitySticky`
      info	[Changelog] - New enum type `IngressClientCertificateMode` with values `IngressClientCertificateModeAccept`, `IngressClientCertificateModeIgnore`, `IngressClientCertificateModeRequire`
      info	[Changelog] - New enum type `JobExecutionRunningState` with values `JobExecutionRunningStateDegraded`, `JobExecutionRunningStateFailed`, `JobExecutionRunningStateProcessing`, `JobExecutionRunningStateRunning`, `JobExecutionRunningStateStopped`, `JobExecutionRunningStateSucceeded`, `JobExecutionRunningStateUnknown`
      info	[Changelog] - New enum type `JobProvisioningState` with values `JobProvisioningStateCanceled`, `JobProvisioningStateDeleting`, `JobProvisioningStateFailed`, `JobProvisioningStateInProgress`, `JobProvisioningStateSucceeded`
      info	[Changelog] - New enum type `ManagedCertificateDomainControlValidation` with values `ManagedCertificateDomainControlValidationCNAME`, `ManagedCertificateDomainControlValidationHTTP`, `ManagedCertificateDomainControlValidationTXT`
      info	[Changelog] - New enum type `TriggerType` with values `TriggerTypeEvent`, `TriggerTypeManual`, `TriggerTypeScheduled`
      info	[Changelog] - New function `*ClientFactory.NewJobsClient() *JobsClient`
      info	[Changelog] - New function `*ClientFactory.NewJobsExecutionsClient() *JobsExecutionsClient`
      info	[Changelog] - New function `*ClientFactory.NewManagedCertificatesClient() *ManagedCertificatesClient`
      info	[Changelog] - New function `NewJobsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobsClient, error)`
      info	[Changelog] - New function `*JobsClient.BeginCreateOrUpdate(context.Context, string, string, Job, *JobsClientBeginCreateOrUpdateOptions) (*runtime.Poller[JobsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*JobsClient.BeginDelete(context.Context, string, string, *JobsClientBeginDeleteOptions) (*runtime.Poller[JobsClientDeleteResponse], error)`
      info	[Changelog] - New function `*JobsClient.Get(context.Context, string, string, *JobsClientGetOptions) (JobsClientGetResponse, error)`
      info	[Changelog] - New function `*JobsClient.NewListByResourceGroupPager(string, *JobsClientListByResourceGroupOptions) *runtime.Pager[JobsClientListByResourceGroupResponse]`
      info	[Changelog] - New function `*JobsClient.NewListBySubscriptionPager(*JobsClientListBySubscriptionOptions) *runtime.Pager[JobsClientListBySubscriptionResponse]`
      info	[Changelog] - New function `*JobsClient.ListSecrets(context.Context, string, string, *JobsClientListSecretsOptions) (JobsClientListSecretsResponse, error)`
      info	[Changelog] - New function `*JobsClient.BeginStart(context.Context, string, string, JobExecutionTemplate, *JobsClientBeginStartOptions) (*runtime.Poller[JobsClientStartResponse], error)`
      info	[Changelog] - New function `*JobsClient.BeginStopExecution(context.Context, string, string, string, *JobsClientBeginStopExecutionOptions) (*runtime.Poller[JobsClientStopExecutionResponse], error)`
      info	[Changelog] - New function `*JobsClient.BeginStopMultipleExecutions(context.Context, string, string, JobExecutionNamesCollection, *JobsClientBeginStopMultipleExecutionsOptions) (*runtime.Poller[JobsClientStopMultipleExecutionsResponse], error)`
      info	[Changelog] - New function `*JobsClient.BeginUpdate(context.Context, string, string, JobPatchProperties, *JobsClientBeginUpdateOptions) (*runtime.Poller[JobsClientUpdateResponse], error)`
      info	[Changelog] - New function `NewJobsExecutionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobsExecutionsClient, error)`
      info	[Changelog] - New function `*JobsExecutionsClient.NewListPager(string, string, *JobsExecutionsClientListOptions) *runtime.Pager[JobsExecutionsClientListResponse]`
      info	[Changelog] - New function `NewManagedCertificatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedCertificatesClient, error)`
      info	[Changelog] - New function `*ManagedCertificatesClient.BeginCreateOrUpdate(context.Context, string, string, string, *ManagedCertificatesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedCertificatesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ManagedCertificatesClient.Delete(context.Context, string, string, string, *ManagedCertificatesClientDeleteOptions) (ManagedCertificatesClientDeleteResponse, error)`
      info	[Changelog] - New function `*ManagedCertificatesClient.Get(context.Context, string, string, string, *ManagedCertificatesClientGetOptions) (ManagedCertificatesClientGetResponse, error)`
      info	[Changelog] - New function `*ManagedCertificatesClient.NewListPager(string, string, *ManagedCertificatesClientListOptions) *runtime.Pager[ManagedCertificatesClientListResponse]`
      info	[Changelog] - New function `*ManagedCertificatesClient.Update(context.Context, string, string, string, ManagedCertificatePatch, *ManagedCertificatesClientUpdateOptions) (ManagedCertificatesClientUpdateResponse, error)`
      info	[Changelog] - New struct `ContainerAppJobExecutions`
      info	[Changelog] - New struct `CorsPolicy`
      info	[Changelog] - New struct `DaprConfiguration`
      info	[Changelog] - New struct `IngressStickySessions`
      info	[Changelog] - New struct `Job`
      info	[Changelog] - New struct `JobConfiguration`
      info	[Changelog] - New struct `JobConfigurationManualTriggerConfig`
      info	[Changelog] - New struct `JobConfigurationScheduleTriggerConfig`
      info	[Changelog] - New struct `JobExecution`
      info	[Changelog] - New struct `JobExecutionBase`
      info	[Changelog] - New struct `JobExecutionContainer`
      info	[Changelog] - New struct `JobExecutionNamesCollection`
      info	[Changelog] - New struct `JobExecutionTemplate`
      info	[Changelog] - New struct `JobPatchProperties`
      info	[Changelog] - New struct `JobPatchPropertiesProperties`
      info	[Changelog] - New struct `JobProperties`
      info	[Changelog] - New struct `JobSecretsCollection`
      info	[Changelog] - New struct `JobTemplate`
      info	[Changelog] - New struct `JobsCollection`
      info	[Changelog] - New struct `KedaConfiguration`
      info	[Changelog] - New struct `ManagedCertificate`
      info	[Changelog] - New struct `ManagedCertificateCollection`
      info	[Changelog] - New struct `ManagedCertificatePatch`
      info	[Changelog] - New struct `ManagedCertificateProperties`
      info	[Changelog] - New struct `SecretVolumeItem`
      info	[Changelog] - New field `Category` in struct `AvailableWorkloadProfileProperties`
      info	[Changelog] - New field `ManagedBy` in struct `ContainerApp`
      info	[Changelog] - New field `LatestReadyRevisionName` in struct `ContainerAppProperties`
      info	[Changelog] - New field `WorkloadProfileName` in struct `ContainerAppProperties`
      info	[Changelog] - New field `Identity` in struct `ContainerAppSecret`
      info	[Changelog] - New field `KeyVaultURL` in struct `ContainerAppSecret`
      info	[Changelog] - New anonymous field `ContainerApp` in struct `ContainerAppsClientUpdateResponse`
      info	[Changelog] - New field `ClientCertificateMode` in struct `Ingress`
      info	[Changelog] - New field `CorsPolicy` in struct `Ingress`
      info	[Changelog] - New field `StickySessions` in struct `Ingress`
      info	[Changelog] - New field `Kind` in struct `ManagedEnvironment`
      info	[Changelog] - New field `DaprConfiguration` in struct `ManagedEnvironmentProperties`
      info	[Changelog] - New field `InfrastructureResourceGroup` in struct `ManagedEnvironmentProperties`
      info	[Changelog] - New field `KedaConfiguration` in struct `ManagedEnvironmentProperties`
      info	[Changelog] - New anonymous field `ManagedEnvironment` in struct `ManagedEnvironmentsClientUpdateResponse`
      info	[Changelog] - New field `Identity` in struct `Secret`
      info	[Changelog] - New field `KeyVaultURL` in struct `Secret`
      info	[Changelog] - New field `TerminationGracePeriodSeconds` in struct `Template`
      info	[Changelog] - New field `Secrets` in struct `Volume`
      info	[Changelog] - New field `Name` in struct `WorkloadProfile`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 115 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 1c397e9e053a4240124934902030ada98a3301b7. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCheckNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListSecretsResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsUpdateResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
      info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
      info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
      info	[Changelog]   - Added Type Alias ExtendedLocationTypes
      info	[Changelog]   - Added Type Alias IngressClientCertificateMode
      info	[Changelog]   - Added Type Alias JobExecutionRunningState
      info	[Changelog]   - Added Type Alias JobProvisioningState
      info	[Changelog]   - Added Type Alias JobsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias JobsExecutionsListNextResponse
      info	[Changelog]   - Added Type Alias JobsExecutionsListResponse
      info	[Changelog]   - Added Type Alias JobsGetResponse
      info	[Changelog]   - Added Type Alias JobsListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias JobsListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias JobsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias JobsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias JobsListSecretsResponse
      info	[Changelog]   - Added Type Alias JobsStartResponse
      info	[Changelog]   - Added Type Alias JobsStopMultipleExecutionsResponse
      info	[Changelog]   - Added Type Alias JobsUpdateResponse
      info	[Changelog]   - Added Type Alias LogLevel
      info	[Changelog]   - Added Type Alias ManagedCertificateDomainControlValidation
      info	[Changelog]   - Added Type Alias ManagedCertificatesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedCertificatesGetResponse
      info	[Changelog]   - Added Type Alias ManagedCertificatesListNextResponse
      info	[Changelog]   - Added Type Alias ManagedCertificatesListResponse
      info	[Changelog]   - Added Type Alias ManagedCertificatesUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
      info	[Changelog]   - Added Type Alias TriggerType
      info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
      info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
      info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
      info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
      info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
      info	[Changelog]   - Interface ContainerApp has a new optional parameter latestReadyRevisionName
      info	[Changelog]   - Interface ContainerApp has a new optional parameter managedBy
      info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileName
      info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter identity
      info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter keyVaultUrl
      info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
      info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
      info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
      info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
      info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
      info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
      info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
      info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
      info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
      info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
      info	[Changelog]   - Interface Ingress has a new optional parameter stickySessions
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter daprConfiguration
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter infrastructureResourceGroup
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kedaConfiguration
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
      info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
      info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
      info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
      info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
      info	[Changelog]   - Interface Secret has a new optional parameter identity
      info	[Changelog]   - Interface Secret has a new optional parameter keyVaultUrl
      info	[Changelog]   - Interface Template has a new optional parameter initContainers
      info	[Changelog]   - Interface Template has a new optional parameter terminationGracePeriodSeconds
      info	[Changelog]   - Interface Volume has a new optional parameter secrets
      info	[Changelog]   - Added Enum KnownAction
      info	[Changelog]   - Added Enum KnownAffinity
      info	[Changelog]   - Added Enum KnownApplicability
      info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
      info	[Changelog]   - Added Enum KnownExtendedLocationTypes
      info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
      info	[Changelog]   - Added Enum KnownJobExecutionRunningState
      info	[Changelog]   - Added Enum KnownJobProvisioningState
      info	[Changelog]   - Added Enum KnownLogLevel
      info	[Changelog]   - Added Enum KnownManagedCertificateDomainControlValidation
      info	[Changelog]   - Added Enum KnownTriggerType
      info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
      info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
      info	[Changelog]   - Enum KnownStorageType has a new value Secret
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface VnetConfiguration no longer has parameter runtimeSubnetId
      info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
      info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 1c397e9e053a4240124934902030ada98a3301b7. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 1c397e9e053a4240124934902030ada98a3301b7. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.app.DefaultTag [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 7, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.App https://apiview.dev/Assemblies/Review/d7a42232b85540a8aec4eb92b1f88ca2
    Go sdk/resourcemanager/appcontainers/armappcontainers https://apiview.dev/Assemblies/Review/38f5843c34fa464c9465e3abea07d264
    Java azure-resourcemanager-appcontainers https://apiview.dev/Assemblies/Review/8f3ab1013a104ad5afbeb1b725248b18
    JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/19a2d54f03274edfb61fda767f14aceb

    @weidongxu-microsoft weidongxu-microsoft merged commit 6c3d940 into Azure:release-app-Microsoft.App-2023-04-01-preview Apr 10, 2023
    @njuCZ njuCZ deleted the user/njucz/terminationGracePeriodSeconds branch April 10, 2023 07:27
    tadelesh pushed a commit that referenced this pull request May 26, 2023
    * Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * support terminationGracePeriodSeconds (#23476)
    
    * Support SubPath in volume mount and mount options for azure file volume (#23496)
    
    * Support SubPath in volume mount and mount options for azure file volume
    
    * update description
    
    * Add replica/container running state (#23617)
    
    * add replica/container running state
    
    * spell error fix
    
    * add event trigger for Container Jobs 2023-04-01-preview (#23724)
    
    * add event trigger for Container Jobs 2023-04-01-preview
    
    * prettier and avocado fix
    
    ---------
    
    Co-authored-by: Taher Darolywala <[email protected]>
    
    * Resolve Comments for Event driven jobs (#23729)
    
    * Resolve Comments for Event driven jobs
    
    * change scaling rule to azure-servicebus
    
    * update example
    
    ---------
    
    Co-authored-by: Taher Darolywala <[email protected]>
    
    * Swagger change for mtls and runningState (#23767)
    
    * 1. Add mtls properties for managed ManagedEnvironment
    2. Add running state for Revision
    
    * fix
    
    * Add ContainerApp Start/Stop for 2023-04-01-preview (#23497)
    
    * Add ContainerApp Start/Stop for 2023-04-01-preview
    
    * Fix validation error
    
    * Fix validation error
    
    * Change example to add location in header
    
    * Fix lint error
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Fix lint issue
    
    * Add new source controls properties (#23891)
    
    * Add new source controls properties
    
    * Update examples
    
    * fix examples
    
    * Change event trigger replica properties to executions, add polling in… (#23810)
    
    * Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs
    
    * Fix validation errors
    
    * code review comments
    
    * Fix formatting errors
    
    * Code review comments
    
    * Add single execution history endpoint, refactor copy paste code for j… (#23816)
    
    * Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters
    
    * Fix validation errors from ARM
    
    * Fix validation errors
    
    * Code review comments
    
    * Fix validation error
    
    * code review comments from Anand
    
    * Add springboard properties (#23932)
    
    * Add springboard properties
    
    * CR comments
    
    * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json
    
    Co-authored-by: Jitin John <[email protected]>
    
    * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json
    
    Co-authored-by: Jitin John <[email protected]>
    
    ---------
    
    Co-authored-by: Jitin John <[email protected]>
    
    * Fix Lint issues in ContainerApps.json (#24107)
    
    * Fix lint issue
    
    * Fix format issue
    
    * Fix json format issue
    
    * Fix model validation
    
    * Fix lint error
    
    * fix param (#24166)
    
    Co-authored-by: Chenghui Yu <[email protected]>
    
    ---------
    
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: njucz <[email protected]>
    Co-authored-by: LaylaLiu-gmail <[email protected]>
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: Taher Daroly <[email protected]>
    Co-authored-by: Taher Darolywala <[email protected]>
    Co-authored-by: zhenqxuMSFT <[email protected]>
    Co-authored-by: Zijian-Ju <[email protected]>
    Co-authored-by: Sanchit Mehta <[email protected]>
    Co-authored-by: trajkobal <[email protected]>
    Co-authored-by: Ahmed ElSayed <[email protected]>
    Co-authored-by: Jitin John <[email protected]>
    Co-authored-by: Seris370 <[email protected]>
    Co-authored-by: Chenghui Yu <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants