[Hub Generated] Review request for Microsoft.HybridCompute to add version stable/2022-11-10 #21528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…022-08-11-preview to version 2022-11-10
|
Hi, @dorothyhu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| HybridCompute.json | 2022-11-10(a60199b) | 2022-03-10(main) |
| HybridCompute.json | 2022-11-10(a60199b) | 2022-08-11-preview(main) |
| privateLinkScopes.json | 2022-11-10(a60199b) | 2022-03-10(main) |
| privateLinkScopes.json | 2022-11-10(a60199b) | 2022-08-11-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The 'required' status changed from the old version('False') to the new version('True'). New: common-types/resource-management/v3/types.json#L104:7 Old: common-types/resource-management/v1/types.json#L98:7 |
|
The new version has new required property 'location' that was not found in the old version. New: common-types/resource-management/v3/types.json#L101:5 Old: common-types/resource-management/v1/types.json#L95:5 |
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v3/types.json#L179:9 Old: common-types/resource-management/v1/types.json#L195:9 |
|
| The new version has a different 'allOf' property than the previous one. New: common-types/resource-management/v3/types.json#L101:5 Old: common-types/resource-management/v1/types.json#L95:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-11 | package-2022-11(a60199b) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'machineName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L37 |
|
The resource name parameter 'machineName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L328 |
|
The resource name parameter 'extensionName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L328 |
|
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L329 |
|
A 'put' operation 'MachineExtensions_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L329 |
|
An async PUT operation must return 201. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L369 |
|
Only 201 is the supported response code for PUT async response. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L376 |
|
A 202 response should include an Location response header. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L376 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L472 |
|
The resource name parameter 'machineName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L594 |
|
The resource name parameter 'machineName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L650 |
|
An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L651 |
|
Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources']. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L1369 |
|
Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these. Location: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L1448 |
|
The resource name parameter 'scopeName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L115 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L116 |
|
A 'delete' operation 'PrivateLinkScopes_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L116 |
|
The resource name parameter 'scopeName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L311 |
|
The resource name parameter 'scopeName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L356 |
|
The resource name parameter 'groupName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L356 |
|
The resource name parameter 'scopeName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L401 |
|
The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L401 |
|
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L449 |
|
An async PUT operation must return 201. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L484 |
|
Only 201 is the supported response code for PUT async response. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L491 |
|
A 202 response should include an Location response header. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L491 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L508 |
|
The resource name parameter 'scopeName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L575 |
|
The path for nested resource doest not meet the valid resource pattern. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L659 |
|
The resource name parameter 'machineName' should be defined with a 'pattern' restriction. Location: Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json#L659 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HybridCompute/machines/{}/reconnect is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hybridcompute/resource-manager/readme.md json: Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi, @dorothyhu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @dorothyhu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @dorothyhu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 11, 2022
This was referenced Nov 11, 2022
rkmanda
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
rkmanda
reviewed
Nov 11, 2022
| "title": "HybridComputeManagementClient", | ||
| "description": "The Hybrid Compute Management Client.", | ||
| "version": "2022-11-10" | ||
| }, |
There was a problem hiding this comment.
Is every file in this PR new changes? If any of them are from previous API version, please follow this:
The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" label once you have fixed this issue.
There was a problem hiding this comment.
No. I promoted our older version to a new version. Those 3 commits were generated by OpenAPIHub and their process was always like this.
dorothyhu
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
reviewed
Nov 29, 2022
.../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json
Show resolved
Hide resolved
|
Rest LGTM. |
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" |
There was a problem hiding this comment.
Please replace all v2 common type refs with v3 for consistentcy.
There was a problem hiding this comment.
@timotheeguerin this swagger uses a mixed v2 and v3 common types of ErrorResponse and ErrorDetails. Their definitions are exactly the same in both versions, but modelerfour gave the below errors when generating .NET SDK:
error | PreCheck/DuplicateSchema | Duplicate Schema named 'ErrorDetail' (1 differences):
- properties.details.$ref: "#/components/schemas/schemas:258" => "#/components/schemas/schemas:356";
error | PreCheck/DuplicateSchema | Duplicate Schema named 'ErrorResponse' (1 differences):
- properties.error.$ref: "#/components/schemas/schemas:254" => "#/components/schemas/schemas:352";
Is this expected?
There was a problem hiding this comment.
yes, modelerfour doesn't support deduplicating types with circular references
dw511214992
approved these changes
Dec 15, 2022
This was referenced Dec 15, 2022
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…sion stable/2022-11-10 (Azure#21528) * Adds base for updating Microsoft.HybridCompute from version preview/2022-08-11-preview to version 2022-11-10 * Updates readme * Updates API version in new specs and examples * added headers for 202 * add extensions back * updated description * changed every v2 to v3 type
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
…sion stable/2022-11-10 (Azure#21528) * Adds base for updating Microsoft.HybridCompute from version preview/2022-08-11-preview to version 2022-11-10 * Updates readme * Updates API version in new specs and examples * added headers for 202 * add extensions back * updated description * changed every v2 to v3 type
akning-ms
pushed a commit
that referenced
this pull request
Feb 14, 2023
…ge anything) (#22553) * [Purview - PDS] - 2021-01-01-preview (#20142) * Add PDS swagger specification. * Use default instead of multiple error codes. * Add desctiptions. * Fix error response model. * Update PDS api specifications as per API guidelines * Pretty. * Correct example. * fix dug property. * Remove from custom words. * Fix linting errors. * Fix errors. * Fix conflict. * Fix examples. * Fix linting errors. * Linting errors. * Linting errors. * Fix operatio Id. * Fix x-ms-pageable. * Add filter description. Co-authored-by: Gaurav Gupta <[email protected]> * Document that public_exponent applies only to MHSM (#21762) * AAD Domain Services: Add 2022-12-01 API version (#21567) * AAD Domain Services: Add 2022-12-01 API version * Update all api-version in files to latest 2022-12-01 version * Add SyncApplicationId property to domainservices.json * pr review feedback on the property description * [Hub Generated] Publish private branch 'appplatform/release/s213' (#21746) * [AutoSync] 3a0ff3ca9 Merged PR 7162965: fix: add missing change * Update readme.md Co-authored-by: swagger-automation <[email protected]> * [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 (#21450) * Adds base for updating Microsoft.RecoveryServices from version preview/2022-09-01-preview to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * moving latest preview to stable Co-authored-by: Himanshu Agarwal <[email protected]> * added duration format to support ISO8601 strings (#21711) * Add more parameters to common types (#21420) * Add more parameters to common types * Put back the line at the end of the file * Skip URL encoding on already-encoded parameter * [Hub Generated] Publish private branch 'user/pri/2022-12-01' (#21717) * add or modify files * Fixed spellcheck validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * avacado fix * avacado fix * avacado fix * avacado fix' * avacado fix * avacado fix * revert custom-words.txt * update custom-words.txt * updated PreCheckResult * removed SystemData * removed SystemData Co-authored-by: Aditya Ravishankar <[email protected]> * [Hub Generated] Publish private branch 'RPSaaSMaster' (#21518) * add or modify files * Update FileSystems_CreateOrUpdate_MaximumSet_Gen.json * Adding 2022-06-27 preview folder * Adding custom-words.txt * Adding Qumulo.Storage in ./custom.txt file * Adding id in the response * Fixed ModelValidation errors * Fixed prettier issue * Reverting FileSystems_CreateOrUpdate_MaximumSet_Gen.json * Fixed prettier issue * Adding cadl file * Adding examples for cadl * Removing readme file * Adding read me files * /Removing read me files * Adding Read me all supported languages * Changed python readme * Removing npmrc and cadl-project.yaml * Moved the cadl under resource-manager and added cadl to support both API versions * Adding readme files * Removing read me * Adding .gitignore file * Removing examples * Renaming to cadl folder * Renaming cadl folder to Qumulo.Management * Formatted cadl file * Formatted cadl file * Adding examples in Qumulo.Management * adding cadl-project.yaml * Adding new package.json * Reverting examples in Qumulo.Management * Adding examples in Qumulo.Management Co-authored-by: shamsthabrez <[email protected]> * [Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2022-05-01 (#21588) * Adds base for updating Microsoft.ResourceHealth from version preview/2022-05-01-preview to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Changes to example files for ImpactedResources. * was told to add a pattern restiction * was told to add a pattern restiction Co-authored-by: ABHISHEK SINGHAL <[email protected]> * Clarify AKV's description for the maxresults parameter. (#21697) * Azure RedHat OpenShift 2022-09-04 (#21248) * Previous API Version 2022-04-01 * add new api 2022-09-04 refactor list install versions * Add patterns, remove 201s for PUTs * Update examples * Remove patterns, add back 201s for PUTs * Fix response codes * Remove patterns * Update examples * Update readme.python.md * Removed 201 modified from added resources * Satisfy ModelValidation. * Implement pattern restrictions on new resources Co-authored-by: Ross Bryan <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * add RPSaaS comments (#21801) * [Hub Generated] Publish private branch 'ssivathas/Microsoft.MobileNetwork-2022-11-01' (#21752) * add or modify files * Use "5Qi" as the schema to define Default QoS Flow 5G QoS Indicator value. (#9817) On SIM policy we use the 'Default QoS Flow 5G QoS Indicator value', we were incorrectly using the '5QiPriorityLevel' schema (which is an interger between 1 and 127 as per https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/mobilenetwork/resource-manager/Microsoft.MobileNetwork/stable/2022-11-01/ts29571.json#L117. We should have used 5Qi - an integer between 0 and 255. We made a mistake when we first p ut this in and have no spotted it. Even though changing the allowed values for a property is a breaking change, we think this is acceptable because: 1) This is our first stable API, there is no pre-existing stable API we need to be back-compatible with 2) 2022-04-01-preview to 2022-11-01 already contains breaking changes that we have discussed in https://eng.ms/docs/strategic-missions-and-technologies/strategic-missions-and-technologies-organization/azure-for-operators/packet-core/private-mobile-network/azure-private-5g-core/cross-team/releases/2022-11-01-arm-api/back-compatibility 3) We have one customer who may need to use values 128-255 -> if that customer does PUTs with the 2022-11-01 API then a GET with the 2022-04-01, it will fail, while this is sad, we think this is an acceptable risk. * Update ICCID definition to support shorter ICCID (#9910) GSM 11.1 Version 8 has been replaced by 3GPP TS 11.11, which itself has been replaced by 3GPP TS 102.211 Rel 16, and all of them share the same information for the definition of ICCID. ISO/IEC 7812-1 2017, ITU-T E.118 - 05/2006 and 3GPP TS 102.211 all alllow ICCID/Primary Account Numbers which are shorter than 19 digits. While ISO/IEC 7812-1 2017 and ITU-T E.118 - 05/2006 both require a maximum number of digits of 19, and GSM 11.11 is clear than 20 digits ICCID are allowed to be grandfathered in. ITU-T E.118 - 05/2006 mandates that all new SIM cards use a prefix of 89, but allows 66 as a transitional mechanism for older SIM cards. ISO/IEC 7812-1 2017 mandates a minimum length of 10 digits. No other specification comments on a minimum size, so we go with this. The original validation was based on an incorrect reading of the specs, where 19 and 20 were assumed to be the only valid lengths, and the comment on the transitional mechanism was missed. Even though changing the allowed values for a property is a breaking change, we think this is acceptable because: 1) This is our first stable API, there is no pre-existing stable API we need to be back-compatible with 2) 2022-04-01-preview to 2022-11-01 already contains breaking changes that we have discussed in https://eng.ms/docs/strategic-missions-and-technologies/strategic-missions-and-technologies-organization/azure-for-operators/packet-core/private-mobile-network/azure-private-5g-core/cross-team/releases/2022-11-01-arm-api/back-compatibility 3) We have customers who are currently blocked and having to work around this restriction, and it's acceptable for them to be unable to resubmit the data on the old API. 4) This is relaxing the restriction on a optional field, so the impact of this change is restricted anyway. 5) Not making this change leaves the product ill defined for ever. * Remove reference to 2021-04-01-preview API in readme * Fix python output-folder * Update readme.python.md Co-authored-by: Richard Whitehouse <[email protected]> Co-authored-by: Andrew Lee <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Release app microsoft.app 2022 10 01 (#21683) * Adds base for updating Microsoft.App from version preview/2022-06-01-preview to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * Add AppState and LatestReadyRevisionName (#21034) * Add new props * add defaults * Add swagger for client cert & CORS policy (#21126) * Fix password format of env domain for 2022-10-01 (#21463) * fix * fix * Remove AppState property as we decided to postpone it (#21483) * Remove AppState property as we decided to postpone it * Fix swagger issues * More swagger fixes * s360 swagger correctness fixes (#21472) Co-authored-by: Nan Jiang <[email protected]> * Add kind for managed environment (#21589) * add * fix * fix (#21730) * fix (#21747) Co-authored-by: p-bouchon <[email protected]> Co-authored-by: Ruslan Yakushev <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> * Allow edit for daprAIInstrumentationKey (#21815) Co-authored-by: Nan Jiang <[email protected]> * [Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2022-08-01-preview (#21422) * Adds base for updating Microsoft.SqlVirtualMachine from version preview/2022-07-01-preview to version 2022-08-01-preview * Updates readme * Updates API version in new specs and examples * Adding 2022-08-01-preview version for Sql Virtual Machine swagger * move all api-version to 2022-08-01-preview * fix the following validation errors: R4041 - XmsIdentifierValidation R4009 - RequiredReadOnlySystemData * add location for 202 reponse * fix typo * fix LRO_RESPONSE_HEADER validation error * fix Swagger PrettierCheck * fix 1047 - XmsEnumChanged, manually move IdentityTypeWithNone to IdentityType * fix DefinitionsPropertiesNamesCamelCase, adding azureADAuthenticationSettings to the custom-words.txt * adding azureADAuthenticationSettings in the alphabetical position. * fix PostOperationAsyncResponseValidation and LroLocationHeader errors * fix typo * missing quote * adding quote * fix DefinitionsPropertiesNamesCamelCase * remove azureADAuthenticationSettings * fix ResourceNameRestriction * use \" to escape " * fix swagger regex syntax difference comparing to C# regex * addressing one comment from ARM team to add error response schema for the default response: * fix 202 response: 1. adding Location header 2. adding specify x-ms-long-running-operation-options * UnHealthyReplica to UnhealthyReplica uuHealthyReplica to unhealthyReplica * TroubleShoot to Troubleshoot troubleShoot to troubleshoot * "UTC format" to "UTC timezone" * SqlVmTroubleshoot to SqlVmTroubleshooting * Successfully started SQL virtual machine troubleshoot to Successfully started SQL virtual machine troubleshooting and similar cases * "SQL Iaas Extension" to "SQL IaaS Extension" * Assessment to "an assessment" and other similiar issues * resolve conflict for custom-words.txt * resolve conflict * adding default for troubleshootingScenario * refactor all sqlVirtualMachineName into common definition and reference it elsewhere * add x-ms-long-running-operation-options with azure-async-operation * remove Location header from the Post request * add back the Location header for the Post method, as the validation checks it * add response schema to HA troubleshooting endpoint 200 response. * add "default" to false for SQL IAAS auto upgrade property * renaming: troubleshootStatus => troubleshootingStatus unhealthyReplicaProperties => unhealthyReplicaInfo * update the HA troubleshooting example after the renaming in this endpoint * rewording Assessment as SQL best practices Assessment after consulting with PM. * revert custom-words.tx file Co-authored-by: Qiang Liu <[email protected]> * Update billingbenefits.json (#21766) * update files (#21817) * Scrub custom-words.txt for non-words and descriptions for more inclusive terminology (#21069) * Delete term AADP from custom-words as its not a commonly known acronym. * Delete term 'accountid' from custom-words.txt. You should use proper casing and spacing according to context, such as 'AccountId', 'accountId', 'accountID', 'account ID', or so on, instead. * Delete a whole lot of terms that don't seem to be used anywhere in the specification folder according to a cursory search. * Delete many duplicates from custom-words.txt * Use cSpell.json to quarantine away some misspelled words from custom-words.txt. And remove duplicates of PPSX and PPTM. * 'Mwarev' should not be a word. Terms like 'VMwarevSphere' 'vmware', 'vSphere' should be words instead. * Using cSpell and custom-words better. 'targetv' should not be a custom word in order to allow 'targetvCenterId'. * Actually remove UNKNOWON from custom-words now that it has a cSpell.json exception. * Updation is not a real word. * Sort 'vcenters' * Expand away the nonstandard capitalized acronym Vrops from old documentation, * Noreuse isn't a proper word, so making it a cSpell exception. * Sort 'cadl' * Retire some references to whitelists from documentation. * Replace */* with ** * CloudServiceRP 2022-09-04 version (#21630) * create 2022-09-04 cloudService Folder * update references to new version * update readme and fix common.json divergence * Adding zones, example and renaming IP to Ip in cloudservices swagger (#21232) * Adding zones, example and renaming frontendIPConfigurations to frontendIpConfigurations, LoadBalancerFrontendIPConfiguration to LoadBalancerFrontendIpConfiguration, LoadBalancerFrontendIPConfigurationProperties to LoadBalancerFrontendIpConfigurationProperties * resolving CI validations * changing privateIPAddress to privateIpAddress, publiCIPAddress to ppublicIpAddress * reverting publicIpAddress, privateIpAddress to privateIPAddress, publicIPAddress * removing x-ms-client-flatten and parameter order change Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: ashvermamsft <[email protected]> * update typescript.readme.md in recoveryservicessiterecovery (#21809) * update typescript.readme.md in recoveryservicessiterecovery * update file * Updates for Face PersonDirectory (#21831) * Updates for Face PersonDirectory Add parameter descriptions, and add flatten flags for currently nested request body. * Another description update * More * update api scenario schema (#21836) Co-authored-by: Tianxiang Chen <[email protected]> * [Hub Generated] Publish private branch 'dev/monica/nv' (#21847) * TASK 2104196: Adding a new API version to AzureArcData In this commit, I just copied over all the current files in 2022-03-01-preview to 2022-06-01-preview so that it serves as a base commit. I will add all new files on top of this commit to make main branch at par with RPSaaSMaster. * Added the new changes on top of base version * Updated the readme file * don't close and mark PR as stale for customer-reported PR (#21837) * don't close and mark PR as stable for customer-reported PR * Update fabricbot.json * Initial Commit (#21749) * Initial Commit * Example Changes * Parameter Changes * Parameter Changes * Definition Changes * Semantic Fix * Lint error Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * add label for arcReview (#21851) * [Hub Generated] Publish private branch 'users/prjayasw/agrifoodrp' (#21583) * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * Private endpoint changes * updated examples * updated db update example * build fixes * changed common-types version * pr comments * minor update * Removed 202 response code from Put call * update examples * prettier fix * enum example fix * Incremental change of sensor feature * Adding support for operationResults api for farmbeats resource. * Making cosmetic changes to fix checks * Update readme.python.md pin the title for python SDK * Fixing one change * Rsolving comments * FarmBeats Solution API Review * fixed error * pr comment change * fixing errors * fixing semantic validation errors * example file changes * fixing errors * pr update fields * prettier fix * solution api changes updated * revert changes in custom words file * Swagger Spell check fix * new changes updated in solution definitions * solution discoverability example file change * changes updated * changes updated * changes updated * comment changes * rebaseing main branch * adding solutions resource in swagger * rebasing main branch * solutions resource added in paths * Solution properties added in definitions * solution Id added in parameters * model validation error fix * model validation errors fixes * changes updated Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Priyanka Jayaswal <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Remove format:arm-id from v4 since api validation service fails to load the spec, causing global outages for RPaaS RPs (#21860) * Update RoleManagementAlerts paths (#21735) * Start updating paths * update all paths and examples * Change patch operations to 204 instead of 200 * Update operations paths * Adding 2022-12-01-preview version with CMK support (#21741) * baseline commit for 2022-12-01-preview * Adding encryption property to Account * Add Azure-AsyncOperation header * Fixing Azure-AsyncOperation with Location * Fixing Access Connector / Workspace Swagger Correctness (#21783) * Fixing Access Connector Swagger Correctness * Addressing Swagger Correctness Issues * Fixing diskEncryptionSetId readOnly attribute * update arc review comments and mail (#21867) * update arc review comments and mail * Update .github/comment.yml Co-authored-by: Ray Chen <[email protected]> * update typescript.md in network (#21873) * Initial Commit (#21848) * Initial Commit * Prettier Check Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * Update sla.yml (#21884) * Release securityinsights microsoft.security insights 2022 12 01 preview resolved (#21853) * Adds base for updating Microsoft.SecurityInsights from version preview/2022-11-01-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Resolve merge conflicts in 2022-12-01-preview (#21772) * Adds base for updating Microsoft.SecurityInsights from version preview/2022-11-01-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Add tasks API to incidents and tasks action to automationRules (#21542) * Use generated incidents swagger instead of manual * try to fix prettier * try to fix prettier * try to fix prettier * fix example casing * fix example casing * fix example path and body * fix alignment with previous swagger * Add tasks to incidents API * add task action to automationrules API * prettier * fix lint - missing workspaceName pattern * fix lint - missing workspaceName pattern * Update entity additional properties to match new oav example validation * Delete redundant examples Co-authored-by: ityankel <[email protected]> * Fix model and spell validations (#21857) * Fix model validation * Add Ueba to custom-words Co-authored-by: Anat Gilenson <[email protected]> Co-authored-by: ityankel <[email protected]> * Sm data registry api 2022 12 01 preview review (#21823) * Update dataregistry.json * Update dataregistry.json * Update dataregistry.json * Update dataregistry.json * Update specification/maps/data-plane/DataRegistry/preview/2022-12-01-preview/dataregistry.json Co-authored-by: Yenru Chin <[email protected]> * Update dataregistry.json Co-authored-by: Yenru Chin <[email protected]> * [Hub Generated] Publish private branch 'dev/armohommed/200' (#21820) * add or modify files * fix model * Fix API version in swagger info for OpenAI (#21886) * [Hub Generated] Review request for Microsoft.HybridCompute to add version stable/2022-11-10 (#21528) * Adds base for updating Microsoft.HybridCompute from version preview/2022-08-11-preview to version 2022-11-10 * Updates readme * Updates API version in new specs and examples * added headers for 202 * add extensions back * updated description * changed every v2 to v3 type * Service Bus API version 2022-10-01-preview (#20725) * Base Checkin * update API version to 2022-10-01-preview * Adding the partition count property * updated readme files * Changed the name of the partitions property to premiumMessagingPartitions * added headers - azure-asyncoperation * revertd changes for "modelAsString": true * revertign the modelasstring changes * ci Fixes Co-authored-by: REDMOND\ardsouza <[email protected]> Co-authored-by: Ajit Maruti Navasare (MINDTREE LIMITED) <[email protected]> Co-authored-by: Ajit Navasare <[email protected]> * Updating Examples for SAP Trans (#21874) * Updating examples * Updated payload example * Updating payloads * Updating descriptions Co-authored-by: Shreyas Kottukkal <[email protected]> * [Hub Generated] Review request for Microsoft.Insights to add version preview/2022-08-01-preview (#21339) * Adds base for updating Microsoft.Insights from version stable/2022-06-15 to version 2022-08-01-preview * Updates readme * Updates API version in new specs and examples * Added Managed Identity field * Added publicNetworkAccess field for NSP * Added ruleResolveConfiguration field for TTM * Added missing apis to default tag * Updated package-composite-v1, added package-2022-08-01-preview-only tag * Fixed swagger path in package-composite-v1 * Reverted change to package-composite-v1 Co-authored-by: Avi Jerafi <[email protected]> * Loadtest stableapis (#21672) * publishing stable api version 2022-11-01 for load test service * prettier run * spell check * changing swagger back to 2.0 * adding description * prettier changes * renaming opertation id * adding x-ms-enum extension * validation fixes * renaming examples * review changes * adding x-ms-parameter-location * review fixes * removing required field * adding x-ms-enum values * prettier fix * spell fixes * prettier fix * adding new metrics and app component apis * updating examples * removing list resource type api * changing to kebab case * changing x-ms-parameter-location value for sdk * updating example * removing resourceId * removing resource Id from examples * adding missing desc * removing read only properties from examples * spell fix * review fixes * mode renaming * properties changes in examples * renaming * Update loadtestservice.json * renaming properties * renaming property * desc changes * Add readme SDK changes (#21315) Co-authored-by: Harshan B <[email protected]> * review changes 1. adding file with application octet stream 2.taking fileName as param instead of fileId 3. adding new api for metrics dimension values 4. simplifying metrics api * model validation fixes * spell fixes * updating desc for search and orderby * desc changes * adding 201 response * adding 201 status code * sdk consistency changes * filename renaming * renaming file info * adding default pass fail criteria action value * changing operation id and adding x-ms-pageable attributes * adding Test or Test Run in operation id * updating operation id * adding test suffix in operation id * removing the test suffix * changing operation id * changing example response * updating operation ids Co-authored-by: Krishna Chandak <[email protected]> Co-authored-by: Harshan B <[email protected]> Co-authored-by: Harshan B <[email protected]> * [Hub Generated] Review request for Microsoft.DesktopVirtualization to add version preview/2022-10-14-preview (#21700) * Adds base for updating Microsoft.DesktopVirtualization from version stable/2022-09-09 to version 2022-10-14-preview * Updates readme * Updates API version in new specs and examples * Added removed changes from 2022-04-01-preview to 2022-10-14-preview * Removed MigrationRequest from version * Copied examples over from previous preview * Added missing changes for private link to swagger * Added enabled/disabled status to check descriptions. * Added regex pattern to parameter in types.json * reverted mistaken common type edit and added pattern to parameters * Revert "Added enabled/disabled status to check descriptions." This reverts commit ad177a4e36b3b42d6ac4eb37c622225de3bf95ec. * Removed pattern requirement; will get exception on linter errors * Revert "Revert "Added enabled/disabled status to check descriptions."" This reverts commit 40ef1db774609e7440298a3d236c755aded86942. * Replaced v1 and v2 common types with v3 and added 201 responses as directed from PR review. * Only added v3 to new resources to avoid breaking changes * Fixed incorrect find replace from param to def * changed system data from v3 to v2 to avoid breaking changes * Updated resource version from v3 to v1 to avoid breaking changes * Removed added 201 responses * Changed PrivateLinkResourceListResult to use internal definition and added pagination to PrivateLink collection calls * Update to use same version of PrivateEndpointConnection type * Update PrivateLink version from v3 to v2 to use the same Resource def * Reverted PrivateLinkConnection v3 to v2 due to sdk problems. * Added missed pagable to privatelink ListByHostpool * [Hub Generated] Review request for Microsoft.DataProtection to add version preview/2022-11-01-preview (#21441) * Adds base for updating Microsoft.DataProtection from version preview/2022-10-01-preview to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Added API changes for Blob Backup * Updated class descriptions based on the feedback * Fixing spellcheck errors * Removing "timedout" from custom-words.txt and adding to cSpell.json * Vidit msft/update database api version v5 (#21878) * update database api version to 2022-05-01-preview * rearrange * rearrange specs file * Fixed the allowed Column Types (#21864) * Fixed the allowed Column Types * Fix the formatting of description for enum * Adding User Assigned MI Support for Access Connector Resource (#21765) * Adding new API version for accessConnector * Adding User Assigned MI Changes * Updating Version in Examples folder * Review request for Microsoft.DBforPostgreSQL Flexible server to add version stable/2022-12-01 (#21803) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2022-03-08-preview to version 2022-12-01 * Updates readme * Updates API version in new specs and examples * Fix readme file for new api version change * Move common-types.json to types folder under postgresql/resource-manager * Fix path for common-types.json * Introduced new enum properties for authConfig object instead of previously used enums, based on ARM feedback on earlier 2022-03-08-preview api version PR * Add LroLocationHeaders for 202 calls * Updated readme files for go, python and typescript to include new ga api version 2022-12-01 * Multi api version for PG flexible server to inlude 2022-12-01 ga api version * remove 2022-1201- from multi api in readme.md file * Update readme files to keep 2022-12-01 ga api version as default version * Revert changes done to readme.go.md * Cognitive Services 2022-12-01 (#21716) * Adds base for updating Microsoft.CognitiveServices from version stable/2022-10-01 to version 2022-12-01 * Updates readme * Updates API version in new specs and examples * Cognitive Services 2022-12-01 * adress comments * Revert v4 common types to v2 * Add supression * Update specification/cognitiveservices/resource-manager/readme.md Co-authored-by: Jianye Xi <[email protected]> Co-authored-by: Jianye Xi <[email protected]> * Revert "Adding User Assigned MI Support for Access Connector Resource (#21765)" (#21923) This reverts commit 2181a44b0f75c71ae65142702876e3de59041f3a. * [S360 fix] update Agreements.json to reflect the current api (#21844) * update Agreements.json to reflect the current api * fix prettier issues * fix prettier issues * [Hub Generated] Publish private branch 'dev-azure-kusto-Microsoft.Kusto-2022-11-11' (#21802) * Adds base for updating Microsoft.Kusto from version stable/2022-07-07 to version 2022-11-11 * Updates readme * Updates API version in new specs and examples * changes from Kusto monolith * "type": "object", * Format * 1. Add "_List" 2. ApiVersionParameter from common types 3. Add required state "Canceled" * Location_Skus_List to Skus_List * Typo fix: "an CosmosDb" to "a CosmosDb" * Support zoneDetails * Revert "Support zoneDetails" This reverts commit d873727f042d8ff2b6624bfc8049653fa84ef72d. * zoneDetails to 2022-11-11 * "type": "object" + "x-ms-identifiers": [ "name" ], * [Communication - Telephony Service] Trunk status API (#19233) * trunkstatus 2022-07-01 preview * fix nextLink * remove pageable, fix sdk typo * add port to trunk properties * replace by health endpoint * fix overallHealth property * fix enums * update enum and add descriptive properties * enums to camelcase * remove trunkstatus folder * add health to trunk properties * create new preview * address review comments * fix example * the latest api version swaggers are in the default tag * remove unused response codes from example * fix prettier * update python and ruby tag to the latest version * Unify naming SBC->Trunk, move Extended to beginning of Trunk and SipConfiguration to suggest inheritance * bump up version * bump up the swagger version * fix errors missing enabled property * revert error code version back to new * fix typo and duplicate definition in previous reamdme versions * fix typo * address comments * update ping description * shuffle object definition to help APIview render document properly * Revert "shuffle object definition to help APIview render document properly" This reverts commit a682d6a26f93866ca3467253168be5c569e958a6. * remove redundant type:object on * Momalka/fix examples (#21889) * change moniotor account id * add lables to recording rule Co-authored-by: Moshe Malka <[email protected]> * Added two services PR assignment (#21901) * Added two services PR assignment * Added kusto service for PR assignment * Remove rpsaasdev branch review for voiceservices * {AzureRecoveryServices} fixes Azure/azure-sdk-for-python#27977 recovery_point_id property description (#21919) * {AzureRecoveryServices} fixes Azure/azure-sdk-for-python#27977 recovery_point_id property description fixes Azure/azure-sdk-for-python#27977 `recovery_point_id` property description The current description for `recovery_point_id` property says "ID of the backup copy to be recovered." This is very confusing. Users might confuse it for the resource ID. The description should be made clear that it is "Recovery Point ID Name of the backup copy to be recovered." * Updating the recent stable version * Update bms.json * Dev hybridconnectivity microsoft.hybrid connectivity 2023 03 15 (Draft PR, please review it, but do not merge it yet) (#21631) * Adds base for updating Microsoft.HybridConnectivity from version preview/2022-05-01-preview to version 2023-03-15 * Updates readme * Updates API version in new specs and examples * Adding upcoming changes for GA * Adding service configuration * Adding serviceConfigurationToken * Changing service configuration type * [Manual PR] Review request for Microsoft.ContainerRegistry to add version stable/2022-12-01 (#21807) * Revert "Dev hybridconnectivity microsoft.hybrid connectivity 2023 03 15 (Draft PR, please review it, but do not merge it yet) (#21631)" (#21974) This reverts commit f9e272186af02eb26b2563e438e8b120c772a5cc. * [Hub Generated] Publish private branch 'voiceservice-private-preview' (#21862) * add or modify files * Sync custom-words to main * Add custom words * update typescript.md in service-map (#21961) * update typescript.md in service-map * update files * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#21671) * Fix s360 alerts for properties being returned in GET but not exising in PUT requests * Prettier fix * Fix model validation error for long running operation response missing location header * removed default value for array as it breaks the arm template schema creation * removed default value for array for managed hsm virtual network rule as it breaks the arm template schema creation * add pbi workspace linked service (#21888) * [AnomalyDetector] Update CADL specification (#21969) * update mvad enums * update uvad enums * update main.cadl and package.json * update cadl-project.yaml * update package.json * update swagger * Add a note to Event Grid readme about review (#21968) * Add a note to Event Grid readme about review * Update specification/eventgrid/data-plane/readme.md Co-authored-by: Laurent Mazuel <[email protected]> Co-authored-by: Laurent Mazuel <[email protected]> * add typescropt.md (#21981) * add typescropt.md * update * update * update * ASE VM Marketplace (#21890) * Base Commit * New api's * Review comment fixes * Updating Examples for Create flow with proper values (#21839) * Updating Examples for Create flow with proper values * Updating Examples for Create Infra * Adding SAP Trans and DIsk Configuration common example * Adding Install Example payloads for HA systems * Update pull_request_assignment.yml (#21985) * Update pull_request_assignment.yml * Update pull_request_assignment.yml * [Hub Generated] Publish private branch 'oravital-update--dev-security-Microsoft.Security-2022-01-01-preview' (#21988) * Update governance operation result * Fix Model Validation * Fix comment * Fix comment * update custom words (#21929) * [Hub Generated] Publish private branch 'containerservice/official/v20221218' (#21987) * [AutoSync] 6a6ad0e3336 Merged PR 7353698: [API Release] Sync swagger changes in GitHub PR #21069 * [AutoSync] c7b8955aefd Merged PR 7359461: [API Release] Fix Swagger LintDiff errors * [AutoSync] 76fc4392c08 Merged PR 7379598: [Swagger][2022-11 APIs] azure auth-provider kubeconfig is fully removed in v1.26 instead of v1.25 Co-authored-by: swagger-automation <[email protected]> * Event Hub API version 2022-10-01-preview (#20724) * Base Checkin * Replace API version with 2022-10-01-preview * Adding settings for Compaction * Fixed examples * Adding new api version to README.md * Getting PolicyRetention enum to be modelled as string * Adding latest api as default * Fixing LintDiff * Fixing Model Validation * updated readme files * Splitting the RetentionTimein Hours into two seperate properties. * lint fix * fixed typo * Revert "fixed typo" This reverts commit 2387ca3bf6f02e3a2df4966de2234c9dd2212e2b. * Revert "lint fix" This reverts commit 2c775034f650404cb9fe85bcc1730cb8425847b5. * Revert "Splitting the RetentionTimein Hours into two seperate properties." This reverts commit caf5d9ebaf2d5429ce489ba8004e805e5bd9159c. * Fixing examples * removed the supperssion * added headers - azure-asyncoperation * fixing the CI failures * Revert "added headers - azure-asyncoperation" This reverts commit 2d60d5c0d8d7839da3e6cf2d5f1aeba90c1efacb. * updated CI fixes * headers fix for cluster catch Co-authored-by: REDMOND\ardsouza <[email protected]> Co-authored-by: davadhani <[email protected]> Co-authored-by: Ajit Maruti Navasare (MINDTREE LIMITED) <[email protected]> Co-authored-by: Ajit Navasare <[email protected]> * Update Data container ubuntu os version (#21995) * Add blockchain to latest profile * Add additional types * update Co-authored-by: Mark Cowlishaw <[email protected]> * [Hub Generated] Review request for Search to add version preview/2022-09-01-preview (#21898) * Boundary Documentation changes in Dev maps search 2022 09 01 preview (#21892) * Adds base for updating Search from version preview/2022-02-01-preview to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Rename geocoding.json to search.json * Added Boundary service APIs * Fixed references to common spec * Use an array instead of a map for geometries copyright * Remove readOnly attribute from responses and default/max for the top parameter * Mark seach/polygon location parameter as required * Rename entityType parameter to resultType * Rename entityType parameter to resultType in the example too * Use View parameter from Common spec * Doc Updates:1. Updated 'location' request parameter to 'coordinates' and updated the GetPolygon example with the correct values 2. Updated the boundary description to mention the expected geometry objects in the boundary API response 3. Updated View description to mention link to azure maps supported views details. * Update custom-words.txt Added POIs word to fix spell check error. Co-authored-by: Igor Shishkin <[email protected]> Co-authored-by: Igor Shishkin <[email protected]> * Update common.json (#21897) * Updated the Boundary parameters description. (#21913) * Updated the Boundary description and removed pois from custom words list. * spelling validation fix for POIs - adding POIs to the custom-words list. * Updated POIs description. * addressed PR comment - Updated View description. * Updated the Boundary view parameter description - default value set to auto. Co-authored-by: Igor Shishkin <[email protected]> Co-authored-by: Igor Shishkin <[email protected]> * EnableInteractivequery Changes (#21936) * EnableInteractivequery Changes * Spell Check Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * Adding new api-version 2022-12-01 to Microsoft.DataProtection (#21661) * Base commit for updating Microsoft.DataProtection from version stable/2022-05-01 to version stable/2022-12-01 Base commit for updating Microsoft.DataProtection from version stable/2022-05-01 to version stable/2022-12-01 * Updating readme * Updating api version in new specs and examples * Updating examples * Adding CSR related changes * Adding softDeleteSettings to backupVault * Adding examples * fixing swagger * Fixing readme * Adding description * Adding immutability settings * Update dataprotection.json Added Expiry time field for RP contract * Update ListRecoveryPoints.json Updated ListRP example for expiry Time * Merging latest fix * Adding OperationalStore enum value * Using parameters from v4 common * Adding parameter for BackupInstanceName * PatchResourceGaurd Fix * Adding identity property in PatchResourceGuardInput * Removing identity in resourceGuard resource * Removing identity from ResourceGuard patch Co-authored-by: amchandn <[email protected]> Co-authored-by: cvarsh <[email protected]> Co-authored-by: Srinivas Charan Madu <[email protected]> * s360 kpi fix (#22013) * Create readme.python.md (#21972) * Create readme.python.md * Update readme.md * Fix required api version parameter in OpenAI (#21921) * Fix API version in swagger info for OpenAI * Fix api version parameter of open ai ga version * {AzureFrontdoor} fixes Azure/azure-cli#24758 fixing ActionType enum to include AnomalyScoring (#21947) fixes Azure/azure-cli#24758 fixing ActionType enum to include AnomalyScoring Running the below command to override the managed rules with --action set to AnomalyScoring fails: > az network front-door waf-policy managed-rules override add ``` az network front-door waf-policy managed-rules override add: 'AnomalyScoring' is not a valid value for '--action'. Allowed values: Allow, Block, Log, Redirect. ``` This is because currently only the `Allow, Block, Log, Redirect` enums are specified. `AnomalyScoring` value should also be included in the `ActionType` enums. * Creating Settings.json spec under preview (#21723) * Creating Settings.json spec under preview * Adding settings.json into readme.md * Prettier fix * Review comments * Feature/cplat 2022 11 01 (#21571) * add 2022-11-01 folder * update readme, update version reference * Added userData property for PUT Restore Point API Added user data property for PUT Restore Point API * Revert "Added userData property for PUT Restore Point API" This reverts commit 94c96d8ca8586b37a59083efd6357ccf2594dd61. * Reimage Support for Non-Ephemeral VMs (#21090) * Reimage support for non-ephemeral VMs * small changes * small changes * resolving issues * pretty check * pretty install * remove package-lock * remove package-lock * Added userData property in Restore Point PUT API endpoint (#21262) * Added userData property in Restore Point PUT Operation * Update based on review comment * Updated description Co-authored-by: Ashwani Tiwari <[email protected]> * Add OS Image profile to scheduled events profile and maxSurge in rolling upgrade policy in Microsoft.Compute (#21253) * add reimage notification * update reimage notification, add max surge * fix grammar * Adding requireGuestProvisionSignal and constrainedMaximumCapacity mis… (#21433) * Adding requireGuestProvisionSignal and constrainedMaximumCapacity missing properties * Moved the property at the end Co-authored-by: Avaiyang Garg <[email protected]> * Add serviceArtifactReference property (#21607) * Add serviceArtifactReference property * Moved the property inside the virtualMachineScaleSet file * Minor change in example Co-authored-by: Avaiyang Garg <[email protected]> * add platformFaultDomain in instanceView (#21605) * add platformFaultDomain in instanceView * change platformFaultDomain values * add APIVersionPattern Suppression (#21675) Co-authored-by: Theodore Chang <[email protected]> * Adding imageDeprecationStatus properties to VirtualMachineImage response (#21615) * Changes to virtualMachineImage.json to include ImageDeprecationStatus properties * Changes to example json * Fixed LintDiff errors * Addressed review comment * Introduce rollbackFailedInstancesOnPolicyBreach in VMSS RollingUpgradePolicy (#21676) * add property in compute.json * add in 2022 file * add rollbackFailedInstancesOnPolicyBreach in examples * Revert "add property in compute.json" This reverts commit 15a1e10503cc4e34b0b69f351cc8f23339002360. * remove space Co-authored-by: Sachin Doddaiah Shylaja <[email protected]> Co-authored-by: Theodore Chang <[email protected]> * fix spellingCheck error, LintDiff error, model validation, and typo * fix modelValidation * model validation * update headers for examples * model validation errors * model validation * Revert "model validation" This reverts commit d3810a7866a9093b6ef75a57834e1aaeb4e139f3. * Revert "model validation errors" This reverts commit ba34d1b2af2bef58b60c16e9ed1cda00803a2ce0. * Revert "update headers for examples" This reverts commit 216b3dc1367655b8c7867a9d7a772fe7e2fa1583. * Revert "model validation" This reverts commit 285345656321e984bc99486a575e35a4d3359667. * Revert "fix modelValidation" This reverts commit a5fa156d42130566b827df88d6dea4ee591f4a6c. * Revert "fix spellingCheck error, LintDiff error, model validation, and typo" This reverts commit 9f60b71000be72bf4511feefcda0820b570345de. * fix spelling error CI, file name typo, Lint Diff Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Ashwani Tiwari <[email protected]> Co-authored-by: srcharug <[email protected]> Co-authored-by: csassasin <[email protected]> Co-authored-by: John Zhang <[email protected]> Co-authored-by: avaiyanggarg <[email protected]> Co-authored-by: Avaiyang Garg <[email protected]> Co-authored-by: parahluwalia <[email protected]> Co-authored-by: RajalakshmiSwaminathan <[email protected]> Co-authored-by: Sachin Doddaiah Shylaja <[email protected]> Co-authored-by: Sachin Doddaiah Shylaja <[email protected]> * readme.java.md (#22040) * Check in Appconfig scenarios and recording assets (#21798) * add appconfig control-plane scenarios * touch swagger * push tag successfully * check in tag * move assets.json to scenarios folder * update tag * add appconfig data-plane scenarios * push data-plane apitest recording * update mgmt recording * restore swagger * update recording * change array name to settings (#21335) * Task 16564293: Update swagger description of new budget alert. (#21879) * Task 16564293: Update swagger description of new budget alert. * Also remove "budget" as it will not longer be used. * Add custom words Co-authored-by: Thomas Pham <[email protected]> * Add additionalProperties to Microsoft.ResourceGraph/resourcesHistory (#21088) * Additional Properties * Not anonymous * PrettierCheck * add or modify files (#21989) * {AzureAPIM} fixes Azure/azure-rest-api-specs#21849 'in body' parameter specification missing (#21875) * {AzureAPIM} fixes Azure/azure-rest-api-specs#21849 'in body' parameter specification missing fixes Azure/azure-rest-api-specs#21849 'in body' parameter specification missing The CreateOrUpdate operations on both of the following resource types are missing the in body parameter in the OpenAPI specification (OAS): Microsoft.ApiManagement/service/contentTypes Microsoft.ApiManagement/service/contentTypes/contentItems This causes the documentation TryIt and autogenerated libraries (e.g. nodejs @azure/arm-apimanagement) to break, as they don't support passing in the properties in the body, making these resource types unable to be updated or created. For example, if you run the "Try It" for this API, it doesn't give you a body field in the auto-generated REST HTTP request form. The body field is needed, but it doesn't give you that field as it's not populated in the OAS for this resource type. See this: https://github.com/Azure/azure-rest-api-specs/blob/7245d0f5cc01bf95df9d7ae893f252d4001b4ad7/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2021-08-01/apimcontenttypes.json#L132-L162 * Update apimcontenttypes.json * [Go] add servicenetworking readme.go.md (#22082) * ASE New API version 2023-01-01-preview Changes (#22072) * Base Commit from previous released version * New API version changes * fix cosmosdb examples (#22087) * Add new tier and sku - Standard_Basic for Application Gateway (#21976) * Add new tier and sku for standard_basic * spaces * Add scan folder and spark config support in Sparkjob activity (#21768) * add scan folder and spark config support * fix typo * update description * add custom word * [Language - QA authoring] correct `source` to required param for update sources (#22065) * correct source to required param for update sources * fix validation errors while we're here * Document how to integrate test-proxy (#21811) * document how to integrate test-proxy * update doc * fix comments * RAN Info Updated (#22101) * Adding cadl sample project (#21722) * Adding cadl sample project * cadl sample: packaqe.json & cadl-project.yaml (#21903) * cadl sample: packaqe.json & cadl-project.yaml * Update cadl-project.yaml * Use faked shared model * Update documentation/cadl-sample-project/specification/contosowidgetmanager/Contoso.WidgetManager/cadl-project.yaml Co-authored-by: Wes Haggard <[email protected]> * Update cadl-project.yaml * Adjusted to minimum file set * update .Net emitter configuration * update java emitter config * Fixed examples issues * Fixed example style issue Co-authored-by: Wei Dong <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Add 2023-02-27-preview for DigitalTwins (#21953) * Add 2023-02-27-preview for DigitalTwins * Update readme.md * Updated Toc in cadl structure markdown document (#22118) * Changed Ehc Resource Id property to camel case (#22019) * Removing myself from CODEOWNERS since I no longer work on Azure Search (#22033) Co-authored-by: Bruce Johnston <[email protected]> * Release botservice microsoft.bot service 2022 09 15 (#22077) * Base commit from 2022-06-15-preview * Fix S360 issues Co-authored-by: Chang Liu <[email protected]> * Add entry to CODEOWNERS (#22115) * update (#22144) * Ran units Information updated (#22130) * RAN Info Updated * Ran Unit Info Updated * [Hub Generated] Review request for Microsoft.Media/Encoding to add version stable/2022-07-01 (#21190) * Adds base for updating Microsoft.Media/Encoding from version stable/2021-11-01 to version 2022-07-01 * Updates readme * Updates API version in new specs and examples * Copy over the new swagger and example files, and modify the readme file * Fix the missing identifier properties * Fix the experimentalOptions in StandardEncoderPreset * Run Prettier fix * Restore the original order of the existing models * Revert the casing change in api version description * fix spell check and missing format * add subwoofer word back to custom words * Add test scenarios * fix missing ids in examples * Revert "fix missing ids in examples" This reverts commit b84e104dd86dab6c2ce796a8bccfa2efc8432997. * Revert "Add test scenarios" This reverts commit 9456029757435de2800698350528cf067f5bf490. Co-authored-by: giakas <[email protected]> * [monitor] Update readme.python.md (#22163) * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.md Co-authored-by: Yuchao Yan <[email protected]> * mgmt, autorest configure for Java codegen (#22122) * fix cadl sample (#22146) * fix * Update Widgets_ListWidgetsSample.json * Update Widgets_ListWidgetsSample.json * [Hub Generated] Review request for Microsoft.Media/Encoding to add version preview/2022-05-01-preview (#21160) * Adds base for updating Microsoft.Media/Encoding from version stable/2021-11-01 to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * Copy over the swagger files for 2022-05-01-preview * Fix validation failures * Fix validation failures * Fix validation failures II * Fix readme file * Fix readme file II * Fix readme file III * Restore the original order of the existing models * Revert the casing change in api version description * Added shared library guideline (#22162) * Added shared library guidline * Use sample project in example * Sync private repo (#22074) * The run.sh script requires git, which is not available by default (#22174) * The run.sh script requires git, but git is not available by default in the base image I've created a shell in the datacontainer and noticed that the run.sh script fails, because the git command is not found. Without it, the datacontainer cannot check out the local clone of the repo and we end up with a completely empty/usr/data/openapispecs. This is currently blocking RPaaS api-validation service in Air-Gapped clouds, where we depend entirely on specs loaded from the data container. I tested this change locally: WIth git being previously installed to the image, run.sh succeeds and /usr/data/openapispecs is properly populated with the repo contents. * Addressing PR commants Use Ubuntu 22.04, as suggested in the PR reviews. * Dev reservations microsoft.capacity 2022 11 01 (#21565) * Adds base for updating Microsoft.Capacity from version stable/2022-03-01 to version 2022-11-01 * Updates readme * Updates API version in new specs and examples * 2022-02-16-privatepreview CalculateExchange and Exchange, 2022-06-02-privatepreview Reservation properties change * Add appliedScopeProperties to purchase and patch request. Add reviewDateTime to purchase patch request and get response for reservationOrder * Add reviewDateTime to Reservation Response * Update operationId to clean up doc heirarchy * Modified examples to address property changes. Added back quota.json. Add readonly to property definitions * Add 202 headers for Split, Merge, Patch. Add back AppliedScopes in reservation response to match request. * Add nextlink and totaItems, filter, skip, take to GetCatalogs * Fix lint error * Add back publisherId, offerId, planId for GetCatalog API * Revert "Update operationId to clean up doc heirarchy" This reverts commit 31826f8e7ee40e30f099d5d95bf8b5fccf728819. * Add back expiryDate and purchaseDate Add back expiryDate and purchaseDate for backward compatibility * Revert string to enum change * Remove readOnly for existing definition to fix breaking change * change expand to $expand * Address comments from ARMReview * Revert "Address comments from ARMReview" This reverts commit cdeda23a6a666d79991b369bfc0aea31edd9d54e. * Address comments for arm review * Added x-ms-pageable for catalog api * Fix spellcheck unknown words * address comments and legacy lint errors and warnings * add location for return. address some lint warnings. use proxyResource * address legacy lint error and warnings * Add descriptions for objects and fix typo * fix spell error and missing description * Fix comment * Add back long running operations true to available scopes * Add more description for appliedScopeProperties Co-authored-by: chchen3 <[email protected]> * [service connector ]add default value for enums (#22099) * add default value for enums * add default value for enum * remove * [Go] add network readme.go.md config (#22184) * [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-01-01-preview (#21727) * [Hub Generated] Review request for Microsoft.StreamAnalytics to add version preview/2017-04-01-preview (#22090) * Added the support for Delta Lake output for Azure Stream Analytics. * Added missing references to Delta Lake samples * Corrected the api versions in the examples. * Resolved validation errors. * Tried to fix LRO_RESPONSE_HEADER * Tried to fix LRO_RESPONSE_HEADER * Tried to fix LPO validation error. * LPO Co-authored-by: Vincent Feng <[email protected]> * [Hub Generated] Review request for Microsoft.StreamAnalytics to add version preview/2021-10-01-preview (#22092) * Added support for Delta Lake output * Corrected api version * Fixed LPO issues. Co-authored-by: Vincent Feng <[email protected]> * Fix wrong URL for Ubuntu (#22193) The URL for Ubuntu 22.04 in MCR is slightly different from what we had before for Ubuntu 20.04. this is breaking the Docker build. This PR replaces the wrong URL with the new and correct one. * Dev search microsoft.search 2022 09 01 (#21964) * Adds base for updating Microsoft.Search from version stable/2020-08-01 to version 2022-09-01 * Updates readme * Updates API version in new specs and examples * Add missing private endpoint connection properties (#21629) * add missing private endpoint connection properties * fix errors * Adding delegated identities to data plane * Revert "Adding delegated identities to data plane" This reverts commit def1bd3ba296458c19b8f04cb1a7a5b800d002f9. * Fix Lint ProvisioningStateValidation Error * Applying prettier changes npm run prettier -- --write Co-authored-by: Enrique Jaimes <[email protected]> * Satumkur/new api ver 20220901 (#21922) * semantic updates * Add Dataplane RBAC related changes + examples * Prettier fixes * Fix LintDiff errors * Update SearchUpdateServiceDisableLocalAuth.json update erroneous api version param Co-authored-by: Samartha Tumkur Vani <[email protected]> Co-authored-by: Enrique Jaimes <[email protected]> * Add CMK Enforcement policy support (#21996) * Add CMK Enforcement policy support * Update api-version * Remove unused properties * Remove bypass property Co-authored-by: satumkurmsft <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: Samartha Tumkur Vani <[email protected]> * [Hub Generated] Review request for Microsoft.ServiceFabricMesh to add version preview/2018-09-01-preview (#22171) * Fixing Linter Validation Error * Fixing Model Validation errors * Incorporating review feedback. * add or modify files (#22187) * mgmt, java, fix invalid swagger (#22204) * fixing eTag issues (#22121) * Recoveryservicesbackup microsoft.recovery services 2023-01-01 (#21788) * Adds base for updating Microsoft.RecoveryServices from version stable/2022-10-01 to version 2023-01-01 * Updates readme * Updates API version in new specs and examples * Update bms.json Added RecoveryPoint Expiry time for Immutability GA * Update bms.json Prettier fix * Update readme.md Updated default tag * Update bms.json Updated bms json for expiry time format.. * Update bms.json UPdating correct type * Update bms.json Syntax error fixed * Update bms.json Prettier fix * Release maintenance microsoft.maintenance 2022 11 01 preview (#21806) * Adds base for updating Microsoft.Maintenance from version preview/2022-07-01-preview to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Add Override Functionality to the Maintenance Configuration. * Adding Maintenance Override Properties to the Maintenance Configuration. * Revert "Adding Maintenance Override Properties to the Maintenance Configuration." This reverts commit 28d2f7556eb10d8aeb7fe28e4c27489fa5e6ae19. * Adding Maintenance Override Properties to the Maintenance Configuration. * Adding "x-ms-identifiers": [] to fix lint error. * Adding description to the Override Properties. * Swagger Prettier Check Fix * Reverting the Changes in the 07-01 preview version * Address PR comments * Fixing the Datetime type * Fixing Code Checks * Fixing DateTime * Removing Name from the json * Triggering a API Check run * Pretty Check * Changed Description Co-authored-by: Paul Selvaraj <[email protected]> * add or modify files (#22189) * [LOADTESTSERVICE] added "format" to "Endpoint", removed "continuationToken" (#21986) * added "format" to "Endpoint" * Update loadtestservice.json Removed `continuationToken` and `maxPageSize` * re-added "maxpagesize" Co-authored-by: Nivedit Jain <[email protected]> * Bump InstanceFailoverGroups version (#22172) * Fix operation status common type to bring it up to speed with RpaaS's runtime contract (#22192) * Add resourceId as an optional property for operation status response schema * base commit cloning the v4 type * adding resourceId to the operation status response as an optional property to make the common type compliant with RpaaS's runtime behavior * prettier * Update readme.python.md (#22221) * feat: Introduce 11 new events for Azure API Management in Azure Event Grid system topic (#21771) * feat: Introduce 11 new events for Azure API Management in Azure Event Grid system topic Signed-off-by: Tom Kerkhove <[email protected]> * Add CE samples Signed-off-by: Tom Kerkhove <[email protected]> * Run prettier Signed-off-by: Tom Kerkhove <[email protected]> * Rename Signed-off-by: Tom Kerkhove <[email protected]> * "API" -> "Api" * Rename events Signed-off-by: Tom Kerkhove <[email protected]> * Add sample links Signed-off-by: Tom Kerkhove <[email protected]> Signed-off-by: Tom Kerkhove <[email protected]> * Added data plane swagger for Microsoft.DataBox RP for EventGrid system topic (#21945) * Added data plane swagger for Microsoft.DataBox EventGrid system topic * Update DataBox.json * updated * Update copy_completed.json * Update copy_started.json * Update order_completed.json * Update DataBox.json * Resolving comments around Stage details & enum * resolving arch board points * Update DataBox.json * [Hub Generated] Publish private branch 'user/jimmyca/AppConfigurationV2' (#22213) * Set foundation for api version 2.0 * Update to v2. * API review updates. * Update API version for 2.0 to use date format. 2.0 -> 2022-11-01-preview. * Remove unnecessary if-match and if-none-match to snapshot creation. * * Fixed prettier, oav, autorest validation errors. * Added missing examples. * Added readme tag for new api version. * Addressed feedback. * Add error schema. * Creation should return 201 response. * Remove application/json from consumes. * Add descriptions. Remove breaking changes caused by retroactively adding x-ms-enum. * * Remove default schema for head requests. They have no response body. * Add requirements on snapshot filters. * Add retention_period, status_code, and failed state.. * Fix snapshots path (snapshot/ -> snapshots/). Remove extraneous items_link property from snapshot. * Feedback. * Respect enum changes introduced in prior API version: https://github.com/Azure/azure-rest-api-specs/issues/21216 fix number format lint diff errors. * {AzureApplicationInsights} fixes Azure/azure-rest-api-specs#22136 IgnoreHttpsStatusCode should be IgnoreHttpStatusCode (#22199) fixes Azure/azure-rest-api-specs#22136 IgnoreHttpsStatusCode should be IgnoreHttpStatusCode. More Info here: https://learn.microsoft.com/en-us/rest/api/application-insights/web-tests/get?tabs=HTTP#webtest * [Maps - RevGeoCoding] Add version preview/2022-12-01-preview [Hub Generated] (#19951) * Adds base for updating Search from version preview/2022-02-01-preview to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * 2022/07/26 Add new version swagger for RevGC * 2022/07/27 Update description * 20…
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.