-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Post Action and Add Secrets Tags #20775
Conversation
…o version 2022-05-01
* Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <[email protected]>
* fix * update * more fix
…g the same fixes in 2022-05-01 (#19048) * Correct Probe enums (#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc55. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Mike Vu <[email protected]> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]>
* Fix description for ManagedEnvironment.Internal property (#19307) * Fix descriptions in all api versions
* Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix
…9360) * Add httpReadBufferSize to dapr config * remove nullable
…o version 2022-06-01-preview
* update * update * update * fix * update * update * update * update * fix * update * update
…ent (#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments
* Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview
* Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <[email protected]> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <[email protected]>
Co-authored-by: Mengjun Qin <[email protected]>
* Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci
* adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <[email protected]>
* Add property for tcp apps * Add scale * Fix * Fix
* add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <[email protected]>
* update * update
* add property: maxInactiveRevisions * update * update
* Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <[email protected]>
* Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing
* new APIs to 06-01 * test fix * more fixes
Hi @xwang971, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
@leni-msft Hi, the authToken API is newly introduced to this version and we havent rolled out release based on this version yet so this would not break anything. Could we please remove the label and get this merged? |
@xwang971 - The changes are good from ARM perspective, but the BreakingChangeReviewRequired label needs to be addressed before ARM signoff. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@leni-msft Hi, the breacking change is approved, also got approval from ARM side, please take a look, thanks |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.