Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Traffic Labels from revisions because they haven't been impelemented #20261

Conversation

ruslany
Copy link
Contributor

@ruslany ruslany commented Aug 16, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ruslany Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 20 Warnings warning [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    ContainerAppsRevisions.json 2022-06-01-preview(10bfacf) 2022-03-01(main)
    ContainerAppsRevisions.json 2022-06-01-preview(10bfacf) 2022-01-01-preview(main)
    ContainerAppsRevisions.json 2022-05-01(10bfacf) 2022-03-01(main)
    ContainerAppsRevisions.json 2022-05-01(10bfacf) 2022-01-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L88:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L141:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L191:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L248:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L354:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L88:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L141:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L191:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L248:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L354:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L96:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L149:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L199:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'replicaName' was added in the new version.
    New: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L256:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L362:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L96:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L149:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L199:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'replicaName' was added in the new version.
    New: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L256:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'revisionName' was added in the new version.
    New: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L362:11
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-05 package-2022-05(10bfacf) package-2022-05(Microsoft.App-2022-06-01-preview)
    package-preview-2022-06 package-preview-2022-06(10bfacf) package-preview-2022-06(Microsoft.App-2022-06-01-preview)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ContainerAppsRevisionReplicas_ListReplicas' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L289
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ContainerAppsRevisionReplicas_ListReplicas' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L289
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'revisions' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L393
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'revisions' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L393
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'replicas' with immediate parent 'Revision', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L500
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'revisions' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L393
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'revisions' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L393
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'replicas' with immediate parent 'Revision', must have a list by immediate parent operation.
    Location: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L500
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: ready
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L562
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: started
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerAppsRevisions.json#L566
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: ready
    Location: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L562
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: started
    Location: Microsoft.App/stable/2022-05-01/ContainerAppsRevisions.json#L566
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/10bfacfcbafb0dc07239e7df567e3f3c7ced6cbd/specification/app/resource-manager/readme.md#tag-package-preview-2022-06">app/resource-manager/readme.md#package-preview-2022-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/10bfacfcbafb0dc07239e7df567e3f3c7ced6cbd/specification/app/resource-manager/readme.md#tag-package-2022-05">app/resource-manager/readme.md#package-2022-05
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"app/resource-manager/readme.md",
    "tag":"package-preview-2022-06",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"app/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2022

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-app - 1.0.0b2
    ️✔️azure-sdk-for-js - @azure/arm-app - 1.0.0-beta.1
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 505d0ff25bce576ca79ab120711d443b808fa9dd. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-app [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation ContainerAppsOperations.begin_update
      info	[Changelog]   - Added operation DaprComponentsOperations.list_secrets
      info	[Changelog]   - Added operation ManagedEnvironmentsOperations.begin_update
      info	[Changelog]   - Added operation group ConnectedEnvironmentsCertificatesOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsDaprComponentsOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsStoragesOperations
      info	[Changelog]   - Added operation group ContainerAppsDiagnosticsOperations
      info	[Changelog]   - Added operation group ManagedEnvironmentDiagnosticsOperations
      info	[Changelog]   - Added operation group ManagedEnvironmentsDiagnosticsOperations
      info	[Changelog]   - Added operation group NamespacesOperations
      info	[Changelog]   - Model CertificateProperties has a new parameter subject_alternative_names
      info	[Changelog]   - Model ContainerApp has a new parameter environment_id
      info	[Changelog]   - Model ContainerApp has a new parameter extended_location
      info	[Changelog]   - Model Dapr has a new parameter enable_api_logging
      info	[Changelog]   - Model Dapr has a new parameter http_max_request_size
      info	[Changelog]   - Model Dapr has a new parameter http_read_buffer_size
      info	[Changelog]   - Model Dapr has a new parameter log_level
      info	[Changelog]   - Model DaprComponent has a new parameter secret_store_component
      info	[Changelog]   - Model GithubActionConfiguration has a new parameter context_path
      info	[Changelog]   - Model GithubActionConfiguration has a new parameter image
      info	[Changelog]   - Model Ingress has a new parameter ip_security_restrictions
      info	[Changelog]   - Model ManagedEnvironment has a new parameter custom_domain_configuration
      info	[Changelog]   - Model ManagedEnvironment has a new parameter dapr_ai_connection_string
      info	[Changelog]   - Model ManagedEnvironment has a new parameter zone_redundant
      info	[Changelog]   - Model RegistryCredentials has a new parameter identity
      info	[Changelog]   - Model TrafficWeight has a new parameter label
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter id
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter name
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter system_data
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter type
      info	[Changelog]   - Model GithubActionConfiguration no longer has parameter dockerfile_path
      info	[Changelog]   - Operation CertificatesOperations.create_or_update has a new parameter certificate_name
      info	[Changelog]   - Operation CertificatesOperations.create_or_update has a new parameter environment_name
      info	[Changelog]   - Operation CertificatesOperations.create_or_update no longer has parameter managed_environment_name
      info	[Changelog]   - Operation CertificatesOperations.create_or_update no longer has parameter name
      info	[Changelog]   - Operation CertificatesOperations.delete has a new parameter certificate_name
      info	[Changelog]   - Operation CertificatesOperations.delete has a new parameter environment_name
      info	[Changelog]   - Operation CertificatesOperations.delete no longer has parameter managed_environment_name
      info	[Changelog]   - Operation CertificatesOperations.delete no longer has parameter name
      info	[Changelog]   - Operation CertificatesOperations.get has a new parameter certificate_name
      info	[Changelog]   - Operation CertificatesOperations.get has a new parameter environment_name
      info	[Changelog]   - Operation CertificatesOperations.get no longer has parameter managed_environment_name
      info	[Changelog]   - Operation CertificatesOperations.get no longer has parameter name
      info	[Changelog]   - Operation CertificatesOperations.list has a new parameter environment_name
      info	[Changelog]   - Operation CertificatesOperations.list no longer has parameter managed_environment_name
      info	[Changelog]   - Operation CertificatesOperations.update has a new parameter certificate_name
      info	[Changelog]   - Operation CertificatesOperations.update has a new parameter environment_name
      info	[Changelog]   - Operation CertificatesOperations.update no longer has parameter managed_environment_name
      info	[Changelog]   - Operation CertificatesOperations.update no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsAuthConfigsOperations.create_or_update has a new parameter auth_config_name
      info	[Changelog]   - Operation ContainerAppsAuthConfigsOperations.create_or_update no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsAuthConfigsOperations.delete has a new parameter auth_config_name
      info	[Changelog]   - Operation ContainerAppsAuthConfigsOperations.delete no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsAuthConfigsOperations.get has a new parameter auth_config_name
      info	[Changelog]   - Operation ContainerAppsAuthConfigsOperations.get no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsOperations.begin_create_or_update has a new parameter container_app_name
      info	[Changelog]   - Operation ContainerAppsOperations.begin_create_or_update no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsOperations.begin_delete has a new parameter container_app_name
      info	[Changelog]   - Operation ContainerAppsOperations.begin_delete no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsOperations.get has a new parameter container_app_name
      info	[Changelog]   - Operation ContainerAppsOperations.get no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsOperations.list_secrets has a new parameter container_app_name
      info	[Changelog]   - Operation ContainerAppsOperations.list_secrets no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsRevisionReplicasOperations.get_replica has a new parameter replica_name
      info	[Changelog]   - Operation ContainerAppsRevisionReplicasOperations.get_replica no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.activate_revision has a new parameter revision_name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.activate_revision no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.deactivate_revision has a new parameter revision_name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.deactivate_revision no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.get_revision has a new parameter revision_name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.get_revision no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.list_revisions has a new parameter filter
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.restart_revision has a new parameter revision_name
      info	[Changelog]   - Operation ContainerAppsRevisionsOperations.restart_revision no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsSourceControlsOperations.begin_create_or_update has a new parameter source_control_name
      info	[Changelog]   - Operation ContainerAppsSourceControlsOperations.begin_create_or_update no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsSourceControlsOperations.begin_delete has a new parameter source_control_name
      info	[Changelog]   - Operation ContainerAppsSourceControlsOperations.begin_delete no longer has parameter name
      info	[Changelog]   - Operation ContainerAppsSourceControlsOperations.get has a new parameter source_control_name
      info	[Changelog]   - Operation ContainerAppsSourceControlsOperations.get no longer has parameter name
      info	[Changelog]   - Operation DaprComponentsOperations.create_or_update has a new parameter component_name
      info	[Changelog]   - Operation DaprComponentsOperations.create_or_update no longer has parameter name
      info	[Changelog]   - Operation DaprComponentsOperations.delete has a new parameter component_name
      info	[Changelog]   - Operation DaprComponentsOperations.delete no longer has parameter name
      info	[Changelog]   - Operation DaprComponentsOperations.get has a new parameter component_name
      info	[Changelog]   - Operation DaprComponentsOperations.get no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsOperations.begin_create_or_update has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsOperations.begin_create_or_update no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsOperations.begin_delete has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsOperations.begin_delete no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsOperations.get has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsOperations.get no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.create_or_update has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.create_or_update has a new parameter storage_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.create_or_update no longer has parameter env_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.create_or_update no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.delete has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.delete has a new parameter storage_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.delete no longer has parameter env_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.delete no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.get has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.get has a new parameter storage_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.get no longer has parameter env_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.get no longer has parameter name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.list has a new parameter environment_name
      info	[Changelog]   - Operation ManagedEnvironmentsStoragesOperations.list no longer has parameter env_name
      info	[Changelog]   - Removed operation ContainerAppsOperations.update
      info	[Changelog]   - Removed operation ManagedEnvironmentsOperations.update
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 505d0ff25bce576ca79ab120711d443b808fa9dd. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-app [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface ConnectedEnvironmentsStoragesListOptionalParams
      info	[Changelog]   - Added Interface ConnectedEnvironmentStorage
      info	[Changelog]   - Added Interface ConnectedEnvironmentStorageProperties
      info	[Changelog]   - Added Interface ConnectedEnvironmentStoragesCollection
      info	[Changelog]   - Added Interface ConnectedEnvironmentsUpdateOptionalParams
      info	[Changelog]   - Added Interface ContainerApp
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsGetDetectorOptionalParams
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsGetRevisionOptionalParams
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsGetRootOptionalParams
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsListDetectorsNextOptionalParams
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsListDetectorsOptionalParams
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsListRevisionsNextOptionalParams
      info	[Changelog]   - Added Interface ContainerAppsDiagnosticsListRevisionsOptionalParams
      info	[Changelog]   - Added Interface CustomDomainConfiguration
      info	[Changelog]   - Added Interface CustomHostnameAnalysisResult
      info	[Changelog]   - Added Interface CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
      info	[Changelog]   - Added Interface CustomHostnameAnalysisResultCustomDomainVerificationFailureInfoDetailsItem
      info	[Changelog]   - Added Interface DaprComponent
      info	[Changelog]   - Added Interface DaprComponentsListSecretsOptionalParams
      info	[Changelog]   - Added Interface DaprSecretsCollection
      info	[Changelog]   - Added Interface DiagnosticDataProviderMetadata
      info	[Changelog]   - Added Interface DiagnosticDataProviderMetadataPropertyBagItem
      info	[Changelog]   - Added Interface DiagnosticDataTableResponseColumn
      info	[Changelog]   - Added Interface DiagnosticDataTableResponseObject
      info	[Changelog]   - Added Interface DiagnosticRendering
      info	[Changelog]   - Added Interface Diagnostics
      info	[Changelog]   - Added Interface DiagnosticsCollection
      info	[Changelog]   - Added Interface DiagnosticsDataApiResponse
      info	[Changelog]   - Added Interface DiagnosticsDefinition
      info	[Changelog]   - Added Interface DiagnosticsProperties
      info	[Changelog]   - Added Interface DiagnosticsStatus
      info	[Changelog]   - Added Interface DiagnosticSupportTopic
      info	[Changelog]   - Added Interface ExtendedLocation
      info	[Changelog]   - Added Interface IpSecurityRestrictionRule
      info	[Changelog]   - Added Interface ManagedEnvironment
      info	[Changelog]   - Added Interface ManagedEnvironmentDiagnosticsGetDetectorOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentDiagnosticsListDetectorsOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentsDiagnosticsGetRootOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentStorage
      info	[Changelog]   - Added Interface NamespacesCheckNameAvailabilityOptionalParams
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface Replica
      info	[Changelog]   - Added Interface Revision
      info	[Changelog]   - Added Interface SourceControl
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Type Alias Action
      info	[Changelog]   - Added Type Alias CheckNameAvailabilityReason
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentProvisioningState
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCheckNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListSecretsResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsUpdateResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
      info	[Changelog]   - Added Type Alias DaprComponentsListSecretsResponse
      info	[Changelog]   - Added Type Alias ExtendedLocationTypes
      info	[Changelog]   - Added Type Alias LogLevel
      info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
      info	[Changelog]   - Added Type Alias NamespacesCheckNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias Scheme
      info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
      info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams has a new optional parameter filter
      info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsOptionalParams has a new optional parameter filter
      info	[Changelog]   - Interface ContainerAppsUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface ContainerAppsUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
      info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
      info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
      info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
      info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter contextPath
      info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter image
      info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
      info	[Changelog]   - Interface ManagedEnvironmentsUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface ManagedEnvironmentsUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface RegistryCredentials has a new optional parameter identity
      info	[Changelog]   - Interface TrafficWeight has a new optional parameter label
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter connectedEnvironments
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter connectedEnvironmentsCertificates
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter connectedEnvironmentsDaprComponents
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter connectedEnvironmentsStorages
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter containerAppsDiagnostics
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter managedEnvironmentDiagnostics
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter managedEnvironmentsDiagnostics
      info	[Changelog]   - Class ContainerAppsAPIClient has a new parameter namespaces
      info	[Changelog]   - Added Enum KnownAction
      info	[Changelog]   - Added Enum KnownCheckNameAvailabilityReason
      info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
      info	[Changelog]   - Added Enum KnownExtendedLocationTypes
      info	[Changelog]   - Added Enum KnownLogLevel
      info	[Changelog]   - Added Enum KnownScheme
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation ContainerApps.update
      info	[Changelog]   - Removed operation ManagedEnvironments.update
      info	[Changelog]   - Interface GithubActionConfiguration no longer has parameter dockerfilePath
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 505d0ff25bce576ca79ab120711d443b808fa9dd. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-app Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-appcontainers Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-app Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @akning-ms akning-ms merged commit 903da55 into Azure:Microsoft.App-2022-06-01-preview Aug 17, 2022
    leni-msft pushed a commit that referenced this pull request Sep 22, 2022
    * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add app diag to 2022-05-01 (#18678)
    
    * Add container apps diagnostics
    
    * Fix validation errors
    
    * Move Microsoft.App diag APIs to 2022-05-01
    
    * Fix validation errors
    
    * Fix validation errors
    
    * Fix validation errors 3
    
    * Change operationIds
    
    Co-authored-by: Michimune Kohno <[email protected]>
    
    * Fix definition for customhostnameesult (#19014)
    
    * fix
    
    * update
    
    * more fix
    
    * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048)
    
    * Correct Probe enums (#18839)
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix patch example
    
    * Fix the casing of enums in the latest api version
    
    * Change the parameter names to unblock Terraform release (#19005)
    
    * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview
    
    * containerapps: fixing inconsistencies in the 2022-03-01 swagger
    
    * containerapps: updating the examples for 2022-01-01-preview
    
    * containerapps: updating the examples to account for the updated parameter names
    
    * containerapps: fixing linting
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix the policheck error
    
    * Revert "containerapps: fixing linting"
    
    This reverts commit 3c4872f.
    
    * Revert "containerapps: updating the examples for 2022-01-01-preview"
    
    This reverts commit 9b81fbd.
    
    * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"
    
    This reverts commit 553fc55.
    
    * Undo changes to 2022-01-01-preview
    
    * Fix one issue
    
    * fix remaining inconsistency
    
    * fix authConfig and sourceControl names
    
    Co-authored-by: tombuildsstuff <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    
    * Change param names
    
    * Fix examples
    
    * Fix CI errors
    
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: tombuildsstuff <[email protected]>
    
    * Fix description in all API versions (#19313)
    
    * Fix description for ManagedEnvironment.Internal property (#19307)
    
    * Fix descriptions in all api versions
    
    * Add traffic info to revisions api (#19054)
    
    * Add traffic info to a revision api
    
    * Add deprecated prop
    
    * Prettier fixes
    
    * 1pdate based on new proposal
    
    * Rename
    
    * Change names
    
    * minor fix
    
    * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360)
    
    * Add httpReadBufferSize to dapr config
    
    * remove nullable
    
    * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add new resources for 2022-06-01-preview (#19494)
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974)
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment
    
    * Fix dapr ai connection string
    
    * remove read
    
    * remove read permission of dapr ai connection string and instrument key for managed environment
    
    * fixes for comments
    
    * update (#20013)
    
    * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133)
    
    * Fix casing for detector properties
    
    * Fix descriptions
    
    * Fix descriptions and detectorProperties in 2022-06-01-preview
    
    * Added `secretsStoreComponent` in 2022-06-01 spec (#20044)
    
    * Added `secretsStoreComponent` in 2022-06-01 spec
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    
    * Fixed typos and added example of name/key
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    
    * Add custom domain configuration for managed environment (#20149)
    
    Co-authored-by: Mengjun Qin <[email protected]>
    
    * Add additional Dapr options (2022-06-01-preview) (#19886)
    
    * Add additional Dapr options
    
    * Update examples for 2022-06-01-preview
    
    * force ci
    
    * force ci
    
    * force ci
    
    * adding ip-restriction feat (#19841)
    
    * adding ip-restriction feat
    
    * remove from stable, add to preview
    
    * fix lintDiff error
    
    * fix modelvalidation error
    
    * fix formatting changes
    
    * rename names, add note to all allow or all deny
    
    * fix spell check error
    
    * update name and examples
    
    * rename `ipAddress` to `ipAddressRange`
    
    * making small change to re-run build pipeline
    
    * trigger GitHub actions
    
    * resolve comments
    
    Co-authored-by: Taher Darolywala <[email protected]>
    
    * Remove Traffic Labels from revisions because they haven't been impelemented (#20261)
    
    * Revert "Add traffic info to revisions api (#19054)"
    
    This reverts commit 056cc51.
    
    * Remove traffic labels from revisions
    
    * Add property for tcp apps (#20193)
    
    * Add property for tcp apps
    
    * Add scale
    
    * Fix
    
    * Fix
    
    * Add Init Containers to common definitions (#19855)
    
    * add init containers to common definitions
    
    * move changes to 06-01 preview
    
    * remove repeated container definition
    
    * fix allof syntax
    
    * fix anonymous container definition
    
    * fix lintdiff errors
    
    * fix container allof syntax
    
    * add more init examples
    
    * split baseContainer definition
    
    * remove description
    
    Co-authored-by: p-bouchon <[email protected]>
    
    * Update container app provisioningstate (#20411)
    
    * update
    
    * update
    
    * add property: maxInactiveRevisions (#20334)
    
    * add property: maxInactiveRevisions
    
    * update
    
    * update
    
    * Add premium sku related properties for managed environment (#19770)
    
    * Add premium sku related properties for managed environment
    
    * Move sku to base property
    
    * Add workloadProfileType
    
    * Examples for managed environment
    
    * Add container app example
    
    * Fix workloadProfiles
    
    * Add custom word
    
    * Fix WorkloadProfileType references
    
    * prettier fixes
    
    * Fix workload profile
    
    * Fix typo
    
    * remove readonly property for workload profile
    
    * Add object type
    
    * nit: Fix description location
    
    * Fix XmsIdentifierValidation
    
    * Remove spaces from enum values
    
    * Remove unwanted change
    
    * Add aka ms url
    
    * Update examples for workload profile type
    
    * Fix rebase issue
    
    * Fix json
    
    * Update description and move location
    
    * Remove provisioning state for node pool
    
    * sku capacity explanation
    
    * Remove capacity attribute
    
    * Remove capacity attribute from required
    
    * Mark sku property as required
    
    * Add x-ms-identifiers
    
    * Rename mimum and maximum
    
    * Rename skutype to skuName
    
    * Make sku property as optional
    
    * Make workload profile type as string
    
    * fix go SDK automation config
    
    Co-authored-by: Chenjie Shi <[email protected]>
    
    * Fix source control status code in 2022-06-01-preview. (#20429)
    
    * Remove 20220501 because we will not support it in server side (#20427)
    
    * remove
    
    * update
    
    * Added support for user defined routing (#20464)
    
    * Added support for user defined routing
    
    * Added examples
    
    * fixed JSON syntax
    
    * syntax fix
    
    * fixed vnetenvironment syntax
    
    * fixed camel case
    
    * case fix
    
    * enum syntax
    
    * fixed comma cases ManagedEnvironmentOutBoundType
    
    * fixing casing
    
    * Some more APIs (#20448)
    
    * new APIs to 06-01
    
    * test fix
    
    * more fixes
    
    * add last active time for revision (#20658)
    
    * Add custom domain for connected env (#20731)
    
    * add custom domain
    
    * fhcekout
    
    * billingMeters - GET endpoint (#20485)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * add proxy resource properties
    
    * Response formatting
    
    * add default error response
    
    * ARM Review feedback + small naming change for a property
    
    * Change GB to GiB
    
    * Fix 2022-06-01-preview branch merge conflicts (#20773)
    
    * Reset
    
    * more fixes
    
    * More fixes
    
    * another conflict fix
    
    * Fix old preview version
    
    * fix 2022-03-01
    
    * supress lint
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    Co-authored-by: Ruslan Yakushev <[email protected]>
    Co-authored-by: michimune <[email protected]>
    Co-authored-by: Michimune Kohno <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: tombuildsstuff <[email protected]>
    Co-authored-by: Ahmed ElSayed <[email protected]>
    Co-authored-by: LaylaLiu-gmail <[email protected]>
    Co-authored-by: Alessandro (Ale) Segala <[email protected]>
    Co-authored-by: Mengjun Qin <[email protected]>
    Co-authored-by: Mengjun Qin <[email protected]>
    Co-authored-by: Taher Daroly <[email protected]>
    Co-authored-by: Taher Darolywala <[email protected]>
    Co-authored-by: zhenqxuMSFT <[email protected]>
    Co-authored-by: p-bouchon <[email protected]>
    Co-authored-by: p-bouchon <[email protected]>
    Co-authored-by: njucz <[email protected]>
    Co-authored-by: JJ <[email protected]>
    Co-authored-by: Chenjie Shi <[email protected]>
    Co-authored-by: yalixiang <[email protected]>
    Co-authored-by: Mahmoud Desokey <[email protected]>
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: trajkobal <[email protected]>
    leni-msft pushed a commit that referenced this pull request Sep 27, 2022
    * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add app diag to 2022-05-01 (#18678)
    
    * Add container apps diagnostics
    
    * Fix validation errors
    
    * Move Microsoft.App diag APIs to 2022-05-01
    
    * Fix validation errors
    
    * Fix validation errors
    
    * Fix validation errors 3
    
    * Change operationIds
    
    Co-authored-by: Michimune Kohno <[email protected]>
    
    * Fix definition for customhostnameesult (#19014)
    
    * fix
    
    * update
    
    * more fix
    
    * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048)
    
    * Correct Probe enums (#18839)
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix patch example
    
    * Fix the casing of enums in the latest api version
    
    * Change the parameter names to unblock Terraform release (#19005)
    
    * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview
    
    * containerapps: fixing inconsistencies in the 2022-03-01 swagger
    
    * containerapps: updating the examples for 2022-01-01-preview
    
    * containerapps: updating the examples to account for the updated parameter names
    
    * containerapps: fixing linting
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix the policheck error
    
    * Revert "containerapps: fixing linting"
    
    This reverts commit 3c4872f.
    
    * Revert "containerapps: updating the examples for 2022-01-01-preview"
    
    This reverts commit 9b81fbd.
    
    * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"
    
    This reverts commit 553fc55.
    
    * Undo changes to 2022-01-01-preview
    
    * Fix one issue
    
    * fix remaining inconsistency
    
    * fix authConfig and sourceControl names
    
    Co-authored-by: tombuildsstuff <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    
    * Change param names
    
    * Fix examples
    
    * Fix CI errors
    
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: tombuildsstuff <[email protected]>
    
    * Fix description in all API versions (#19313)
    
    * Fix description for ManagedEnvironment.Internal property (#19307)
    
    * Fix descriptions in all api versions
    
    * Add traffic info to revisions api (#19054)
    
    * Add traffic info to a revision api
    
    * Add deprecated prop
    
    * Prettier fixes
    
    * 1pdate based on new proposal
    
    * Rename
    
    * Change names
    
    * minor fix
    
    * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360)
    
    * Add httpReadBufferSize to dapr config
    
    * remove nullable
    
    * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add new resources for 2022-06-01-preview (#19494)
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974)
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment
    
    * Fix dapr ai connection string
    
    * remove read
    
    * remove read permission of dapr ai connection string and instrument key for managed environment
    
    * fixes for comments
    
    * update (#20013)
    
    * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133)
    
    * Fix casing for detector properties
    
    * Fix descriptions
    
    * Fix descriptions and detectorProperties in 2022-06-01-preview
    
    * Added `secretsStoreComponent` in 2022-06-01 spec (#20044)
    
    * Added `secretsStoreComponent` in 2022-06-01 spec
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    
    * Fixed typos and added example of name/key
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    
    * Add custom domain configuration for managed environment (#20149)
    
    Co-authored-by: Mengjun Qin <[email protected]>
    
    * Add additional Dapr options (2022-06-01-preview) (#19886)
    
    * Add additional Dapr options
    
    * Update examples for 2022-06-01-preview
    
    * force ci
    
    * force ci
    
    * force ci
    
    * adding ip-restriction feat (#19841)
    
    * adding ip-restriction feat
    
    * remove from stable, add to preview
    
    * fix lintDiff error
    
    * fix modelvalidation error
    
    * fix formatting changes
    
    * rename names, add note to all allow or all deny
    
    * fix spell check error
    
    * update name and examples
    
    * rename `ipAddress` to `ipAddressRange`
    
    * making small change to re-run build pipeline
    
    * trigger GitHub actions
    
    * resolve comments
    
    Co-authored-by: Taher Darolywala <[email protected]>
    
    * Remove Traffic Labels from revisions because they haven't been impelemented (#20261)
    
    * Revert "Add traffic info to revisions api (#19054)"
    
    This reverts commit 056cc51.
    
    * Remove traffic labels from revisions
    
    * Add property for tcp apps (#20193)
    
    * Add property for tcp apps
    
    * Add scale
    
    * Fix
    
    * Fix
    
    * Add Init Containers to common definitions (#19855)
    
    * add init containers to common definitions
    
    * move changes to 06-01 preview
    
    * remove repeated container definition
    
    * fix allof syntax
    
    * fix anonymous container definition
    
    * fix lintdiff errors
    
    * fix container allof syntax
    
    * add more init examples
    
    * split baseContainer definition
    
    * remove description
    
    Co-authored-by: p-bouchon <[email protected]>
    
    * Update container app provisioningstate (#20411)
    
    * update
    
    * update
    
    * add property: maxInactiveRevisions (#20334)
    
    * add property: maxInactiveRevisions
    
    * update
    
    * update
    
    * Add premium sku related properties for managed environment (#19770)
    
    * Add premium sku related properties for managed environment
    
    * Move sku to base property
    
    * Add workloadProfileType
    
    * Examples for managed environment
    
    * Add container app example
    
    * Fix workloadProfiles
    
    * Add custom word
    
    * Fix WorkloadProfileType references
    
    * prettier fixes
    
    * Fix workload profile
    
    * Fix typo
    
    * remove readonly property for workload profile
    
    * Add object type
    
    * nit: Fix description location
    
    * Fix XmsIdentifierValidation
    
    * Remove spaces from enum values
    
    * Remove unwanted change
    
    * Add aka ms url
    
    * Update examples for workload profile type
    
    * Fix rebase issue
    
    * Fix json
    
    * Update description and move location
    
    * Remove provisioning state for node pool
    
    * sku capacity explanation
    
    * Remove capacity attribute
    
    * Remove capacity attribute from required
    
    * Mark sku property as required
    
    * Add x-ms-identifiers
    
    * Rename mimum and maximum
    
    * Rename skutype to skuName
    
    * Make sku property as optional
    
    * Make workload profile type as string
    
    * fix go SDK automation config
    
    Co-authored-by: Chenjie Shi <[email protected]>
    
    * Fix source control status code in 2022-06-01-preview. (#20429)
    
    * Remove 20220501 because we will not support it in server side (#20427)
    
    * remove
    
    * update
    
    * Added support for user defined routing (#20464)
    
    * Added support for user defined routing
    
    * Added examples
    
    * fixed JSON syntax
    
    * syntax fix
    
    * fixed vnetenvironment syntax
    
    * fixed camel case
    
    * case fix
    
    * enum syntax
    
    * fixed comma cases ManagedEnvironmentOutBoundType
    
    * fixing casing
    
    * Some more APIs (#20448)
    
    * new APIs to 06-01
    
    * test fix
    
    * more fixes
    
    * add last active time for revision (#20658)
    
    * Add custom domain for connected env (#20731)
    
    * add custom domain
    
    * fhcekout
    
    * billingMeters - GET endpoint (#20485)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * add proxy resource properties
    
    * Response formatting
    
    * add default error response
    
    * ARM Review feedback + small naming change for a property
    
    * Change GB to GiB
    
    * Rename Action
    
    * secrets tag
    
    * missed fix
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    Co-authored-by: Ruslan Yakushev <[email protected]>
    Co-authored-by: michimune <[email protected]>
    Co-authored-by: Michimune Kohno <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: tombuildsstuff <[email protected]>
    Co-authored-by: Ahmed ElSayed <[email protected]>
    Co-authored-by: LaylaLiu-gmail <[email protected]>
    Co-authored-by: Alessandro (Ale) Segala <[email protected]>
    Co-authored-by: Mengjun Qin <[email protected]>
    Co-authored-by: Mengjun Qin <[email protected]>
    Co-authored-by: Taher Daroly <[email protected]>
    Co-authored-by: Taher Darolywala <[email protected]>
    Co-authored-by: zhenqxuMSFT <[email protected]>
    Co-authored-by: p-bouchon <[email protected]>
    Co-authored-by: p-bouchon <[email protected]>
    Co-authored-by: njucz <[email protected]>
    Co-authored-by: JJ <[email protected]>
    Co-authored-by: Chenjie Shi <[email protected]>
    Co-authored-by: yalixiang <[email protected]>
    Co-authored-by: Mahmoud Desokey <[email protected]>
    Co-authored-by: trajkobal <[email protected]>
    leni-msft pushed a commit that referenced this pull request Sep 28, 2022
    * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add app diag to 2022-05-01 (#18678)
    
    * Add container apps diagnostics
    
    * Fix validation errors
    
    * Move Microsoft.App diag APIs to 2022-05-01
    
    * Fix validation errors
    
    * Fix validation errors
    
    * Fix validation errors 3
    
    * Change operationIds
    
    Co-authored-by: Michimune Kohno <[email protected]>
    
    * Fix definition for customhostnameesult (#19014)
    
    * fix
    
    * update
    
    * more fix
    
    * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048)
    
    * Correct Probe enums (#18839)
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix patch example
    
    * Fix the casing of enums in the latest api version
    
    * Change the parameter names to unblock Terraform release (#19005)
    
    * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview
    
    * containerapps: fixing inconsistencies in the 2022-03-01 swagger
    
    * containerapps: updating the examples for 2022-01-01-preview
    
    * containerapps: updating the examples to account for the updated parameter names
    
    * containerapps: fixing linting
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix the policheck error
    
    * Revert "containerapps: fixing linting"
    
    This reverts commit 3c4872f.
    
    * Revert "containerapps: updating the examples for 2022-01-01-preview"
    
    This reverts commit 9b81fbd.
    
    * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"
    
    This reverts commit 553fc55.
    
    * Undo changes to 2022-01-01-preview
    
    * Fix one issue
    
    * fix remaining inconsistency
    
    * fix authConfig and sourceControl names
    
    Co-authored-by: tombuildsstuff <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    
    * Change param names
    
    * Fix examples
    
    * Fix CI errors
    
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: tombuildsstuff <[email protected]>
    
    * Fix description in all API versions (#19313)
    
    * Fix description for ManagedEnvironment.Internal property (#19307)
    
    * Fix descriptions in all api versions
    
    * Add traffic info to revisions api (#19054)
    
    * Add traffic info to a revision api
    
    * Add deprecated prop
    
    * Prettier fixes
    
    * 1pdate based on new proposal
    
    * Rename
    
    * Change names
    
    * minor fix
    
    * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360)
    
    * Add httpReadBufferSize to dapr config
    
    * remove nullable
    
    * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add new resources for 2022-06-01-preview (#19494)
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974)
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment
    
    * Fix dapr ai connection string
    
    * remove read
    
    * remove read permission of dapr ai connection string and instrument key for managed environment
    
    * fixes for comments
    
    * update (#20013)
    
    * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133)
    
    * Fix casing for detector properties
    
    * Fix descriptions
    
    * Fix descriptions and detectorProperties in 2022-06-01-preview
    
    * Added `secretsStoreComponent` in 2022-06-01 spec (#20044)
    
    * Added `secretsStoreComponent` in 2022-06-01 spec
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    
    * Fixed typos and added example of name/key
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    
    * Add custom domain configuration for managed environment (#20149)
    
    Co-authored-by: Mengjun Qin <[email protected]>
    
    * Add additional Dapr options (2022-06-01-preview) (#19886)
    
    * Add additional Dapr options
    
    * Update examples for 2022-06-01-preview
    
    * force ci
    
    * force ci
    
    * force ci
    
    * adding ip-restriction feat (#19841)
    
    * adding ip-restriction feat
    
    * remove from stable, add to preview
    
    * fix lintDiff error
    
    * fix modelvalidation error
    
    * fix formatting changes
    
    * rename names, add note to all allow or all deny
    
    * fix spell check error
    
    * update name and examples
    
    * rename `ipAddress` to `ipAddressRange`
    
    * making small change to re-run build pipeline
    
    * trigger GitHub actions
    
    * resolve comments
    
    Co-authored-by: Taher Darolywala <[email protected]>
    
    * Remove Traffic Labels from revisions because they haven't been impelemented (#20261)
    
    * Revert "Add traffic info to revisions api (#19054)"
    
    This reverts commit 056cc51.
    
    * Remove traffic labels from revisions
    
    * Add property for tcp apps (#20193)
    
    * Add property for tcp apps
    
    * Add scale
    
    * Fix
    
    * Fix
    
    * Add Init Containers to common definitions (#19855)
    
    * add init containers to common definitions
    
    * move changes to 06-01 preview
    
    * remove repeated container definition
    
    * fix allof syntax
    
    * fix anonymous container definition
    
    * fix lintdiff errors
    
    * fix container allof syntax
    
    * add more init examples
    
    * split baseContainer definition
    
    * remove description
    
    Co-authored-by: p-bouchon <[email protected]>
    
    * Update container app provisioningstate (#20411)
    
    * update
    
    * update
    
    * add property: maxInactiveRevisions (#20334)
    
    * add property: maxInactiveRevisions
    
    * update
    
    * update
    
    * Add premium sku related properties for managed environment (#19770)
    
    * Add premium sku related properties for managed environment
    
    * Move sku to base property
    
    * Add workloadProfileType
    
    * Examples for managed environment
    
    * Add container app example
    
    * Fix workloadProfiles
    
    * Add custom word
    
    * Fix WorkloadProfileType references
    
    * prettier fixes
    
    * Fix workload profile
    
    * Fix typo
    
    * remove readonly property for workload profile
    
    * Add object type
    
    * nit: Fix description location
    
    * Fix XmsIdentifierValidation
    
    * Remove spaces from enum values
    
    * Remove unwanted change
    
    * Add aka ms url
    
    * Update examples for workload profile type
    
    * Fix rebase issue
    
    * Fix json
    
    * Update description and move location
    
    * Remove provisioning state for node pool
    
    * sku capacity explanation
    
    * Remove capacity attribute
    
    * Remove capacity attribute from required
    
    * Mark sku property as required
    
    * Add x-ms-identifiers
    
    * Rename mimum and maximum
    
    * Rename skutype to skuName
    
    * Make sku property as optional
    
    * Make workload profile type as string
    
    * fix go SDK automation config
    
    Co-authored-by: Chenjie Shi <[email protected]>
    
    * Fix source control status code in 2022-06-01-preview. (#20429)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * Remove 20220501 because we will not support it in server side (#20427)
    
    * remove
    
    * update
    
    * add proxy resource properties
    
    * Response formatting
    
    * Added support for user defined routing (#20464)
    
    * Added support for user defined routing
    
    * Added examples
    
    * fixed JSON syntax
    
    * syntax fix
    
    * fixed vnetenvironment syntax
    
    * fixed camel case
    
    * case fix
    
    * enum syntax
    
    * fixed comma cases ManagedEnvironmentOutBoundType
    
    * fixing casing
    
    * add default error response
    
    * Add available workprofiles -GET endpoint
    
    * Remove duplicate schema name WorkloadProfile
    
    * Change memoryGiB to memoryGB as suggested in code review
    
    * Add x-ms-pageable - nextLink support to not introduce breaking changes in the future
    
    * rename to memory in GiB because our case is Gibibytes base 1024
    
    * change friendlyName to displayName
    
    * Some more APIs (#20448)
    
    * new APIs to 06-01
    
    * test fix
    
    * more fixes
    
    * Add new property to the response object
    
    * add last active time for revision (#20658)
    
    * Add custom domain for connected env (#20731)
    
    * add custom domain
    
    * fhcekout
    
    * billingMeters - GET endpoint (#20485)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * add proxy resource properties
    
    * Response formatting
    
    * add default error response
    
    * ARM Review feedback + small naming change for a property
    
    * Change GB to GiB
    
    * Change the boolean value for default to enum
    
    * change error response to v3/ErrorResponse
    
    * Fix 2022-06-01-preview branch merge conflicts (#20773)
    
    * Reset
    
    * more fixes
    
    * More fixes
    
    * another conflict fix
    
    * Fix old preview version
    
    * fix 2022-03-01
    
    Signed-off-by: ItalyPaleAle <[email protected]>
    Co-authored-by: Ruslan Yakushev <[email protected]>
    Co-authored-by: michimune <[email protected]>
    Co-authored-by: Michimune Kohno <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: tombuildsstuff <[email protected]>
    Co-authored-by: Ahmed ElSayed <[email protected]>
    Co-authored-by: LaylaLiu-gmail <[email protected]>
    Co-authored-by: Alessandro (Ale) Segala <[email protected]>
    Co-authored-by: Mengjun Qin <[email protected]>
    Co-authored-by: Mengjun Qin <[email protected]>
    Co-authored-by: Taher Daroly <[email protected]>
    Co-authored-by: Taher Darolywala <[email protected]>
    Co-authored-by: zhenqxuMSFT <[email protected]>
    Co-authored-by: p-bouchon <[email protected]>
    Co-authored-by: p-bouchon <[email protected]>
    Co-authored-by: njucz <[email protected]>
    Co-authored-by: JJ <[email protected]>
    Co-authored-by: Chenjie Shi <[email protected]>
    Co-authored-by: yalixiang <[email protected]>
    Co-authored-by: Mahmoud Desokey <[email protected]>
    Co-authored-by: Xingjian Wang <[email protected]>
    @ruslany ruslany deleted the removetrafficweights-2022-06-01 branch October 7, 2022 21:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants