Add support for ImageCleaner on AKS #19916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jiashun0011 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| managedClusters.json | 2022-07-02-preview(4da4ac3) | 2022-06-01(main) |
| managedClusters.json | 2022-07-02-preview(4da4ac3) | 2022-06-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version has a different format than the previous one. New: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3381:9 Old: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2791:9 |
|
The new version has a different format than the previous one. New: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3381:9 Old: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2791:9 |
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-07 | package-preview-2022-07(4da4ac3) | package-preview-2022-07(dev-containerservice-Microsoft.ContainerService-2022-07-02-preview) |
The following errors/warnings are introduced by current PR:
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L6168 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1238 |
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L37 |
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L5456 |
| Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1221 |
|
| 'PUT' operation 'PrivateEndpointConnections_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1629 |
|
| The operation 'ManagedClusters_GetCommandResult' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1941 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1730 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1884 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1534 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1791 |
|
| OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L244 |
|
| OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1838 |
|
| The child tracked resource, 'agentPools' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3483 |
|
| The child tracked resource, 'commandResults' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3855 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L5360 |
|
| The child tracked resource, 'trustedAccessRoleBindings' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L6692 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAutoScaling Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3241 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableNodePublicIP Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3293 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableCustomCATrust Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3298 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableEncryptionAtHost Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3355 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableUltraSSD Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3360 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFIPS Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3364 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableCSIProxy Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3532 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3550 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableMultipleStandardLoadBalancers Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L4023 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L4086 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRBAC Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L4246 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePodSecurityPolicy Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L4250 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableNamespaceResources Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L4254 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAccounts Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L4413 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/4da4ac364ccddae8f0d0ee072cfc78f4f73c5f92/specification/containerservice/resource-manager/readme.md#tag-package-preview-2022-07">containerservice/resource-manager/readme.md#package-preview-2022-07
| Rule | Message |
|---|---|
| "readme":"containerservice/resource-manager/readme.md", "tag":"package-preview-2022-07", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @jiashun0011, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jul 25, 2022
Closed
Closed
matthchr
reviewed
Jul 25, 2022
| "description": "ImageCleaner scanning interval." | ||
| } | ||
| }, | ||
| "description": "ImageCleaner settings for the security profile." |
There was a problem hiding this comment.
@miwithro - do we want to actually document/link to the underlying implementation here? Or do we have a documentation page we can link to that explains what this does?
IMO we need to say a bit more about what ImageCleaner is doing. Something like: `ImageCleaner removes unused images from nodes, freeing up disk space and helping to reduce attack surface area. For more information see this article
There was a problem hiding this comment.
@matthchr @jiashun0011 I agree with adding more context in the API. Worst case we can add a link to the document.
tianxchen-ms
approved these changes
Aug 1, 2022
tianxchen-ms
merged commit f6bed55
into
Azure:dev-containerservice-Microsoft.ContainerService-2022-07-02-preview
davidomid
pushed a commit
to davidomid/azure-rest-api-specs
that referenced
this pull request
Aug 18, 2022
…02-preview (Azure#20062) * Adds base for updating Microsoft.ContainerService from version preview/2022-06-02-preview to version 2022-07-02-preview * Updates readme * Updates API version in new specs and examples * update readmes (Azure#19872) * Add example of Azure KeyVault Secrets Provider Addon for 2022-07-02-preview (Azure#19874) * add example of kv secret provider addon * fix * fix lint * move ADH GA type to preview (Azure#19904) * move ADH GA type to preview * fix prettier check issue * add overlay vpa swagger (Azure#19936) * add overlay vpa objects * fix typo * address comments Co-authored-by: zhifanhui <[email protected]> * Swagger API for Operation Abort (Azure#19971) * Swagger API for Operation Abort * Swagger changes updates for Abort operation based on validations * Haitao/secured by perimeter0702 (Azure#19873) * add SecuredByPerimeter in publicNetworkAccess * update enum value descriptions * Add support for ImageCleaner on AKS (Azure#19916) * Add support for ImageCleaner on AKS * add more context in ImageCleaner description * add default for availableAgentPoolVersions (Azure#19902) * Add Azure Monitor Metrics (Prometheus) Profile (Azure#19965) * Add Azure Monitor Metrics (Prometheus) Profile * spelling error * restructure to names from rp * commit to rerun build * ksm metrics Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: huizhifan <[email protected]> Co-authored-by: zhifanhui <[email protected]> Co-authored-by: InduSridhar <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: jiashun0011 <[email protected]> Co-authored-by: bragi92 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.