Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Merged
merged 27 commits into from
Jan 6, 2022
Merged

Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
50ae493
Copied the last item from private repo and renamed to 2021-10-01
Nov 6, 2021
7ceeadc
Updated the version to 2021-10-01
Nov 6, 2021
7330927
Error response is updated. It is required by OpenAPI Validation Tools…
Nov 6, 2021
9d10cdc
http status response on post method is updated to 201 from 202; requi…
Nov 6, 2021
9547433
description is added in #definitions.Operation.properties.display; re…
Nov 6, 2021
cb80098
updated error response to match it previous
Nov 6, 2021
4becfb1
systemData properties are added; required by Swagger validation on th…
Nov 6, 2021
833e89d
updated readme.md for the new version
Nov 6, 2021
561f718
removed a file getSubscriptionOperation.json as long as it is not ref…
Nov 6, 2021
c994f96
Modified style by npm prettier
Nov 6, 2021
467d788
executed npm run prettier; required by prettier check on PR
Nov 6, 2021
af77819
added type:object; required by swagger LintDiff
Nov 9, 2021
f9ea165
added type:object; required by swagger LintDiff
Nov 9, 2021
108950b
reverted back the post response of acceptOwnership to 202
Nov 9, 2021
3c575ea
http status response on post method is updated to 201 from 202; requi…
Nov 9, 2021
2c1d675
reverted back the post response of acceptOwnership to 202
Nov 9, 2021
ebc537b
Updated property name value to subscriptionId
Dec 20, 2021
0238925
Added missing property in response body of Get List of Alias subscrip…
Dec 20, 2021
084d929
Updated response of default policies from 201 to 200 based on API res…
Dec 21, 2021
9ef4389
Merge branch 'main' into main
Ochirkhuyag Dec 21, 2021
b88350d
Updated example for response of default policies from 201 to 200 base…
Dec 21, 2021
f5eaa71
s360 fix: error response is fixed on managementpartner
Dec 30, 2021
983cad7
added Microsoft.Subscription/stable/2016-06-01/subscriptions.json in …
Jan 5, 2022
51756c4
Lint diff errors are fixed
Jan 6, 2022
3a5f8cf
reverting back the changes for 2-16-06-01
Jan 6, 2022
85004f8
added v2016-06-01 for the new
Jan 6, 2022
42fc129
executed prettier
Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.Subscription/stable/2021-10-01/examples/cancelSubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"responses": {
"200": {
"body": {
"value": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
"subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.Subscription/stable/2021-10-01/examples/changeTenantPolicy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
},
"responses": {
"201": {
"200": {
"body": {
"id": "providers/Microsoft.Subscription/policies/default",
"name": "default",
Expand Down
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.Subscription/stable/2021-10-01/examples/enableSubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"responses": {
"200": {
"body": {
"value": "7948bcee-488c-47ce-941c-38e20ede803d"
"subscriptionId": "7948bcee-488c-47ce-941c-38e20ede803d"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.Subscription/stable/2021-10-01/examples/renameSubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"responses": {
"200": {
"body": {
"value": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
"subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
}
}
}
Expand Down
16 changes: 10 additions & 6 deletions ...subscription/resource-manager/Microsoft.Subscription/stable/2021-10-01/subscriptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
]
}
},
"/providers/Microsoft.Subscription/{subscriptionId}/acceptOwnership": {
"/providers/Microsoft.Subscription/subscriptions/{subscriptionId}/acceptOwnership": {
"post": {
"description": "Accept subscription ownership.",
"operationId": "Subscription_AcceptOwnership",
Expand Down Expand Up @@ -341,7 +341,7 @@
]
}
},
"/providers/Microsoft.Subscription/{subscriptionId}/acceptOwnershipStatus": {
"/providers/Microsoft.Subscription/subscriptions/{subscriptionId}/acceptOwnershipStatus": {
"get": {
"description": "Accept subscription ownership status.",
"operationId": "Subscription_AcceptOwnershipStatus",
Expand Down Expand Up @@ -384,7 +384,7 @@
}
},
"responses": {
"201": {
"200": {
"description": "Subscription tenant policy has been successfully created/updated.",
"schema": {
"$ref": "#/definitions/GetTenantPolicyResponse"
Expand Down Expand Up @@ -544,7 +544,7 @@
"description": "The ID of the canceled subscription",
"type": "object",
"properties": {
"value": {
"subscriptionId": {
"description": "The ID of the canceled subscription",
"type": "string",
"readOnly": true
Expand All @@ -555,7 +555,7 @@
"description": "The ID of the subscriptions that is being renamed",
"type": "object",
"properties": {
"value": {
"subscriptionId": {
"description": "The ID of the subscriptions that is being renamed",
"type": "string",
"readOnly": true
Expand All @@ -566,7 +566,7 @@
"description": "The ID of the subscriptions that is being enabled",
"type": "object",
"properties": {
"value": {
"subscriptionId": {
"description": "The ID of the subscriptions that is being enabled",
"type": "string",
"readOnly": true
Expand Down Expand Up @@ -781,6 +781,10 @@
"description": "The Management Group Id.",
"type": "string"
},
"createdTime": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createdTime

Please ensure you have a task to implement the common systemData contract in the next API version: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

"description": "Created Time",
"type": "string"
},
"tags": {
"description": "Tags for the subscription",
"type": "object",
Expand Down