Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Ochirkhuyag · 2021-12-21T11:34:47Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…(linter)

…red by OpenAPI Validation Tools(linter)

…quired by OpenAPI Validation Tools(linter)

…e PR

…erenced; required by Swagger Avocado on the PR

…red by OpenAPI Validation Tools(linter)

…tion API

…ponse

openapi-workflow-bot · 2021-12-21T11:34:49Z

Hi, @Ochirkhuyag Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-12-21T11:34:49Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-workflow-bot · 2021-12-21T11:34:50Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-12-21T11:34:50Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-workflow-bot · 2021-12-21T11:34:52Z

Hi, @Ochirkhuyag your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

openapi-pipeline-app · 2021-12-21T18:49:11Z

Swagger Validation Report

️❌BreakingChange: 15 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:preview/2018-02-01/ManagementPartner.json compared with base:preview/2018-02-01/ManagementPartner.json
- current:stable/2021-10-01/subscriptions.json compared with base:stable/2021-10-01/subscriptions.json

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Subscription/{subscriptionId}/acceptOwnership' removed or restructured? Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L294:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Subscription/{subscriptionId}/acceptOwnershipStatus' removed or restructured? Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L344:5
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L387:11
`❌` 1012 - RemovedResponseCode	The new version removes the response code '201' Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L387:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'value' renamed or removed? New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L546:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L546:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'value' renamed or removed? New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L557:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L557:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'value' renamed or removed? New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L568:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L568:7
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L294:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L344:5
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'subscriptionId' in response that was not found in the old version. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L546:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L546:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'subscriptionId' in response that was not found in the old version. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L557:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L557:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'subscriptionId' in response that was not found in the old version. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L568:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L568:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'code' in response that was not found in the old version. New: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L330:7 Old: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L335:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'message' in response that was not found in the old version. New: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L330:7 Old: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L335:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'createdTime' in response that was not found in the old version. New: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L735:7 Old: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L735:7

️❌LintDiff: 11 Errors, 8 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- managementpartner/resource-manager/readme.md tag:package-2018-02
- subscription/resource-manager/readme.md tag:package-2021-10
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- managementpartner/resource-manager/readme.md tag:package-2018-02
- subscription/resource-manager/readme.md tag:package-2021-10

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
`❌` R4037 - MissingTypeObject	The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
`❌` R4037 - MissingTypeObject	The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198
`❌` R4037 - MissingTypeObject	The schema 'Subscription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L210
`❌` R4037 - MissingTypeObject	The schema 'SubscriptionPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L254
`❌` R4037 - MissingTypeObject	The schema 'SubscriptionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L283
`❌` R4037 - MissingTypeObject	The schema 'TenantIdDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L302
`❌` R4037 - MissingTypeObject	The schema 'TenantListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L317
⚠️ R1005 - GetInOperationName	'GET' operation 'Subscription_AcceptOwnershipStatus' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L347
⚠️ R2017 - PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'SubscriptionPolicy_AddUpdatePolicyForTenant' Request Model: 'PutTenantPolicyRequestProperties' Response Model: 'GetTenantPolicyResponse' Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L378
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L21
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L54
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L90
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L297
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L347
⚠️ R4000 - ParameterDescriptionRequired	'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L330

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L156
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L247
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ManagementPartner/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L169
`❌` R4019 - GetCollectionResponseSchema	The response in the GET collection operation 'Partners_Get' does not match the response definition in the individual GET operation 'Partner_Get' . Location: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L206
⚠️ R1006 - PutInOperationName	'PUT' operation 'SubscriptionPolicy_AddUpdatePolicyForTenant' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L380
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L643
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L721
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L820
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L926
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L975
⚠️ R2017 - PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Alias_Create' Request Model: 'PutAliasRequest' Response Model: 'SubscriptionAliasResponse' Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L155
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'Alias_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L265
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L611
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: blockSubscriptionsLeavingTenant Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L888
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: blockSubscriptionsIntoTenant Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L892
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowTransfers Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L999
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: blockSubscriptionsLeavingTenant Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L1014
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: blockSubscriptionsIntoTenant Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L1018
⚠️ R4000 - ParameterDescriptionRequired	'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L188
⚠️ R4000 - ParameterDescriptionRequired	'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Subscription/stable/2021-10-01/subscriptions.json#L401
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetPartnerDetails Location: Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json#L211

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/subscription/resource-manager/readme.md tag: specification/subscription/resource-manager/readme.md#tag-package-2021-10

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-12-21T18:49:12Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armsubscription - 0.2.0

+	Field `Value` of struct `CanceledSubscriptionID` has been removed
+	Field `Value` of struct `EnabledSubscriptionID` has been removed
+	Field `Value` of struct `RenamedSubscriptionID` has been removed

❌azure-sdk-for-python-track2 - track2_azure-mgmt-subscription - Approved - 2.0.0

+	Model CanceledSubscriptionId no longer has parameter value
+	Model EnabledSubscriptionId no longer has parameter value
+	Model RenamedSubscriptionId no longer has parameter value

️✔️azure-sdk-for-go - subscription/mgmt/2020-09-01/subscription - v61.1.0
️✔️azure-sdk-for-go - preview/subscription/mgmt/2019-10-01-preview/subscription - v61.1.0
️✔️azure-sdk-for-go - preview/subscription/mgmt/2018-03-01-preview/subscription - v61.1.0
️✔️azure-sdk-for-go - preview/subscription/mgmt/2017-11-01-preview/subscription - v61.1.0
❌azure-sdk-for-go-track2 - armmanagementpartner - 0.2.0

+	Const `ErrorResponseCodeBadRequest` has been removed
+	Const `ErrorResponseCodeConflict` has been removed
+	Const `ErrorResponseCodeNotFound` has been removed
+	Function `ErrorResponseCode.ToPtr` has been removed
+	Function `PossibleErrorResponseCodeValues` has been removed
+	Type of `ExtendedErrorInfo.Code` has been changed from `*ErrorResponseCode` to `*string`

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-managementpartner - Approved - 1.0.0
❌azure-sdk-for-go - preview/managementpartner/mgmt/2018-02-01/managementpartner - v61.1.0

+	Const `BadRequest` has been removed
+	Const `Conflict` has been removed
+	Const `NotFound` has been removed
+	Function `PossibleCodeValues` has been removed
+	Type of `ExtendedErrorInfo.Code` has been changed from `Code` to `*string`

❌azure-sdk-for-js - track2_@azure/arm-subscriptions - Approved - 5.0.0

+	Class SubscriptionClient no longer has parameter apiVersion
+	Class SubscriptionClient no longer has parameter subscription
+	Interface CanceledSubscriptionId no longer has parameter value
+	Interface EnabledSubscriptionId no longer has parameter value
+	Interface RenamedSubscriptionId no longer has parameter value
+	Interface SubscriptionClientOptionalParams no longer has parameter apiVersion
+	Removed operation group Subscription

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 10043a5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managementpartner/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/subscription/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ManagementPartner [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ManagementPartner.1.1.1-preview.nupkg
- Microsoft.Azure.Management.ManagementPartner.1.1.1-preview.symbols.nupkg
️✔️Microsoft.Azure.Management.Subscription [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Subscription.1.1.5.nupkg
- Microsoft.Azure.Management.Subscription.1.1.5.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 10043a5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 8.1.2 -> 8.3.0
cmderr	[automation_generate.sh]  Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
cmderr	[automation_generate.sh]  Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh]

️✔️track2_azure-mgmt-managementpartner [View full logs] [Release SDK Changes]
- azure_mgmt_managementpartner-1.0.0b1-py3-none-any.whl
- azure-mgmt-managementpartner-1.0.0b1.zip
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Error has a new parameter code
info	[Changelog]   - Model Error has a new parameter message
```

️✔️track2_azure-mgmt-subscription [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group SubscriptionsOperations
info	[Changelog]   - Added operation group TenantsOperations
info	[Changelog]   - Model CanceledSubscriptionId has a new parameter subscription_id
info	[Changelog]   - Model EnabledSubscriptionId has a new parameter subscription_id
info	[Changelog]   - Model RenamedSubscriptionId has a new parameter subscription_id
info	[Changelog]   - Model SubscriptionAliasResponseProperties has a new parameter created_time
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model CanceledSubscriptionId no longer has parameter value
info	[Changelog]   - Model EnabledSubscriptionId no longer has parameter value
info	[Changelog]   - Model RenamedSubscriptionId no longer has parameter value

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 10043a5. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/managementpartner/mgmt/2018-02-01/managementpartner [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ExtendedErrorInfo.Code` has been changed from `Code` to `*string`
info	[Changelog] - Const `BadRequest` has been removed
info	[Changelog] - Const `Conflict` has been removed
info	[Changelog] - Const `NotFound` has been removed
info	[Changelog] - Function `PossibleCodeValues` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Message` in struct `Error`
info	[Changelog] - New field `Code` in struct `Error`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 1 additive change(s).

️✔️subscription/mgmt/2020-09-01/subscription [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/subscription/mgmt/2019-10-01-preview/subscription [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/subscription/mgmt/2018-03-01-preview/subscription [View full logs]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `OperationClient.Get(context.Context, string) (CreationResult, error)`
info	[Changelog] - New function `OperationClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `OperationClient.GetResponder(*http.Response) (CreationResult, error)`
info	[Changelog] - New function `NewOperationClientWithBaseURI(string) OperationClient`
info	[Changelog] - New function `OperationClient.GetPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `NewOperationClient() OperationClient`
info	[Changelog] - New struct `ErrorResponseBody`
info	[Changelog] - New struct `OperationClient`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 10 additive change(s).

️✔️preview/subscription/mgmt/2017-11-01-preview/subscription [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 10043a5. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armmanagementpartner [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ExtendedErrorInfo.Code` has been changed from `*ErrorResponseCode` to `*string`
info	[Changelog] - Const `ErrorResponseCodeConflict` has been removed
info	[Changelog] - Const `ErrorResponseCodeNotFound` has been removed
info	[Changelog] - Const `ErrorResponseCodeBadRequest` has been removed
info	[Changelog] - Function `ErrorResponseCode.ToPtr` has been removed
info	[Changelog] - Function `PossibleErrorResponseCodeValues` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Code` in struct `Error`
info	[Changelog] - New field `Message` in struct `Error`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 1 additive change(s).

️✔️armsubscription [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - Field `Value` of struct `CanceledSubscriptionID` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `SubscriptionStateDisabled`
info	[Changelog] - New const `SubscriptionStateEnabled`
info	[Changelog] - New const `SpendingLimitOn`
info	[Changelog] - New const `SpendingLimitOff`
info	[Changelog] - New const `SpendingLimitCurrentPeriodOff`
info	[Changelog] - New const `SubscriptionStatePastDue`
info	[Changelog] - New const `SubscriptionStateDeleted`
info	[Changelog] - New const `SubscriptionStateWarned`
info	[Changelog] - New function `NewSubscriptionsClient(azcore.TokenCredential, *arm.ClientOptions) *SubscriptionsClient`
info	[Changelog] - New function `*TenantsListPager.Err() error`
info	[Changelog] - New function `*TenantsClient.List(*TenantsListOptions) *TenantsListPager`
info	[Changelog] - New function `TenantListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*SubscriptionsListPager.PageResponse() SubscriptionsListResponse`
info	[Changelog] - New function `NewTenantsClient(azcore.TokenCredential, *arm.ClientOptions) *TenantsClient`
info	[Changelog] - New function `*SubscriptionsClient.ListLocations(context.Context, string, *SubscriptionsListLocationsOptions) (SubscriptionsListLocationsResponse, error)`
info	[Changelog] - New function `SubscriptionListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*SubscriptionsListPager.Err() error`
info	[Changelog] - New function `SpendingLimit.ToPtr() *SpendingLimit`
info	[Changelog] - New function `*SubscriptionsClient.Get(context.Context, string, *SubscriptionsGetOptions) (SubscriptionsGetResponse, error)`
info	[Changelog] - New function `*SubscriptionsListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `LocationListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*TenantsListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `PossibleSubscriptionStateValues() []SubscriptionState`
info	[Changelog] - New function `SubscriptionState.ToPtr() *SubscriptionState`
info	[Changelog] - New function `PossibleSpendingLimitValues() []SpendingLimit`
info	[Changelog] - New function `*SubscriptionsClient.List(*SubscriptionsListOptions) *SubscriptionsListPager`
info	[Changelog] - New function `*TenantsListPager.PageResponse() TenantsListResponse`
info	[Changelog] - New struct `Location`
info	[Changelog] - New struct `LocationListResult`
info	[Changelog] - New struct `Subscription`
info	[Changelog] - New struct `SubscriptionListResult`
info	[Changelog] - New struct `SubscriptionPolicies`
info	[Changelog] - New struct `SubscriptionsClient`
info	[Changelog] - New struct `SubscriptionsGetOptions`
info	[Changelog] - New struct `SubscriptionsGetResponse`
info	[Changelog] - New struct `SubscriptionsGetResult`
info	[Changelog] - New struct `SubscriptionsListLocationsOptions`
info	[Changelog] - New struct `SubscriptionsListLocationsResponse`
info	[Changelog] - New struct `SubscriptionsListLocationsResult`
info	[Changelog] - New struct `SubscriptionsListOptions`
info	[Changelog] - New struct `SubscriptionsListPager`
info	[Changelog] - New struct `SubscriptionsListResponse`
info	[Changelog] - New struct `SubscriptionsListResult`
info	[Changelog] - New struct `TenantIDDescription`
info	[Changelog] - New struct `TenantListResult`
info	[Changelog] - New struct `TenantsClient`
info	[Changelog] - New struct `TenantsListOptions`
info	[Changelog] - New struct `TenantsListPager`
info	[Changelog] - New struct `TenantsListResponse`
info	[Changelog] - New struct `TenantsListResult`
info	[Changelog] - New field `SubscriptionID` in struct `CanceledSubscriptionID`
info	[Changelog] - New field `SubscriptionID` in struct `EnabledSubscriptionID`
info	[Changelog] - New field `CreatedTime` in struct `SubscriptionAliasResponseProperties`
info	[Changelog] - New field `SubscriptionID` in struct `RenamedSubscriptionID`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 77 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 10043a5. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-managementpartner [View full logs] [Release SDK Changes]
- azure-arm-managementpartner-2.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️✔️track2_@azure/arm-subscriptions [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-subscriptions-5.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group SubscriptionOperations
info	[Changelog]   - Added operation group Subscriptions
info	[Changelog]   - Added operation group Tenants
info	[Changelog]   - Added Interface Location_2
info	[Changelog]   - Added Interface LocationListResult
info	[Changelog]   - Added Interface Subscription
info	[Changelog]   - Added Interface SubscriptionListResult
info	[Changelog]   - Added Interface SubscriptionPolicies
info	[Changelog]   - Added Interface SubscriptionsGetOptionalParams
info	[Changelog]   - Added Interface SubscriptionsListLocationsOptionalParams
info	[Changelog]   - Added Interface SubscriptionsListNextOptionalParams
info	[Changelog]   - Added Interface SubscriptionsListOptionalParams
info	[Changelog]   - Added Interface TenantIdDescription
info	[Changelog]   - Added Interface TenantListResult
info	[Changelog]   - Added Interface TenantsListNextOptionalParams
info	[Changelog]   - Added Interface TenantsListOptionalParams
info	[Changelog]   - Added Type Alias SpendingLimit
info	[Changelog]   - Added Type Alias SubscriptionsGetResponse
info	[Changelog]   - Added Type Alias SubscriptionsListLocationsResponse
info	[Changelog]   - Added Type Alias SubscriptionsListNextResponse
info	[Changelog]   - Added Type Alias SubscriptionsListResponse
info	[Changelog]   - Added Type Alias SubscriptionState
info	[Changelog]   - Added Type Alias TenantsListNextResponse
info	[Changelog]   - Added Type Alias TenantsListResponse
info	[Changelog]   - Interface CanceledSubscriptionId has a new optional parameter subscriptionId
info	[Changelog]   - Interface EnabledSubscriptionId has a new optional parameter subscriptionId
info	[Changelog]   - Interface RenamedSubscriptionId has a new optional parameter subscriptionId
info	[Changelog]   - Interface SubscriptionAliasResponseProperties has a new optional parameter createdTime
info	[Changelog]   - Class SubscriptionClient has a new parameter subscriptionOperations
info	[Changelog]   - Class SubscriptionClient has a new parameter subscriptions
info	[Changelog]   - Class SubscriptionClient has a new parameter tenants
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation group Subscription
info	[Changelog]   - Interface CanceledSubscriptionId no longer has parameter value
info	[Changelog]   - Interface EnabledSubscriptionId no longer has parameter value
info	[Changelog]   - Interface RenamedSubscriptionId no longer has parameter value
info	[Changelog]   - Interface SubscriptionClientOptionalParams no longer has parameter apiVersion
info	[Changelog]   - Class SubscriptionClient no longer has parameter apiVersion
info	[Changelog]   - Class SubscriptionClient no longer has parameter subscription

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 10043a5. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️managementpartner [View full logs]
️✔️subscription [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

lirenhe · 2022-01-06T03:54:06Z

The lint issues are not related to the change in this PR. Add the tag to suppress it.

dw511214992 · 2022-01-06T07:03:17Z

/azp run

azure-pipelines · 2022-01-06T07:03:26Z

Azure Pipelines successfully started running 1 pipeline(s).

* Copied the last item from private repo and renamed to 2021-10-01 * Updated the version to 2021-10-01 * Error response is updated. It is required by OpenAPI Validation Tools(linter) * http status response on post method is updated to 201 from 202; required by OpenAPI Validation Tools(linter) * description is added in #definitions.Operation.properties.display; required by OpenAPI Validation Tools(linter) * updated error response to match it previous * systemData properties are added; required by Swagger validation on the PR * updated readme.md for the new version * removed a file getSubscriptionOperation.json as long as it is not referenced; required by Swagger Avocado on the PR * Modified style by npm prettier * executed npm run prettier; required by prettier check on PR * added type:object; required by swagger LintDiff * added type:object; required by swagger LintDiff * reverted back the post response of acceptOwnership to 202 * http status response on post method is updated to 201 from 202; required by OpenAPI Validation Tools(linter) * reverted back the post response of acceptOwnership to 202 * Updated property name value to subscriptionId * Added missing property in response body of Get List of Alias subscription API * Updated response of default policies from 201 to 200 based on API response * Updated example for response of default policies from 201 to 200 based on API response * s360 fix: error response is fixed on managementpartner * added Microsoft.Subscription/stable/2016-06-01/subscriptions.json in input file list * Lint diff errors are fixed * reverting back the changes for 2-16-06-01 * added v2016-06-01 for the new * executed prettier Co-authored-by: Ochi <[email protected]>

Ochi added 19 commits November 5, 2021 19:28

Copied the last item from private repo and renamed to 2021-10-01

50ae493

Updated the version to 2021-10-01

7ceeadc

Error response is updated. It is required by OpenAPI Validation Tools…

7330927

…(linter)

http status response on post method is updated to 201 from 202; requi…

9d10cdc

…red by OpenAPI Validation Tools(linter)

description is added in #definitions.Operation.properties.display; re…

9547433

…quired by OpenAPI Validation Tools(linter)

updated error response to match it previous

cb80098

systemData properties are added; required by Swagger validation on th…

4becfb1

…e PR

updated readme.md for the new version

833e89d

removed a file getSubscriptionOperation.json as long as it is not ref…

561f718

…erenced; required by Swagger Avocado on the PR

Modified style by npm prettier

c994f96

executed npm run prettier; required by prettier check on PR

467d788

added type:object; required by swagger LintDiff

af77819

added type:object; required by swagger LintDiff

f9ea165

reverted back the post response of acceptOwnership to 202

108950b

http status response on post method is updated to 201 from 202; requi…

3c575ea

…red by OpenAPI Validation Tools(linter)

reverted back the post response of acceptOwnership to 202

2c1d675

Updated property name value to subscriptionId

ebc537b

Added missing property in response body of Get List of Alias subscrip…

0238925

…tion API

Updated response of default policies from 201 to 200 based on API res…

084d929

…ponse

openapi-assignment-bot bot assigned lirenhe Dec 21, 2021

openapi-workflow-bot bot added FixS360 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 21, 2021

Merge branch 'main' into main

9ef4389

msyyc added the Approved-SdkBreakingChange-Python label Jan 6, 2022

Lint diff errors are fixed

51756c4

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 6, 2022

dw511214992 added the Approved-SdkBreakingChange-JavaScript label Jan 6, 2022

reverting back the changes for 2-16-06-01

3a5f8cf

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 6, 2022

ArcturusZhang added the Approved-SdkBreakingChange-Go-V2 label Jan 6, 2022

added v2016-06-01 for the new

85004f8

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 6, 2022

executed prettier

42fc129

lirenhe merged commit 10043a5 into Azure:main Jan 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Ochirkhuyag commented Dec 21, 2021 •

edited

Loading

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

Breaking Changes Tracking

lirenhe commented Jan 6, 2022

dw511214992 commented Jan 6, 2022

azure-pipelines bot commented Jan 6, 2022

Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Subscription RP v2021-10-01 endpoint fix, s360 correctness #17155

Conversation

Ochirkhuyag commented Dec 21, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021

openapi-workflow-bot bot commented Dec 21, 2021

openapi-pipeline-app bot commented Dec 21, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 21, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

lirenhe commented Jan 6, 2022

dw511214992 commented Jan 6, 2022

azure-pipelines bot commented Jan 6, 2022

Ochirkhuyag commented Dec 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Dec 21, 2021 •

edited

Loading