Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview #16096

Merged
merged 29 commits into from
Sep 29, 2021
Merged

[Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview #16096

merged 29 commits into from
Sep 29, 2021

Conversation

dochollidayxx
Copy link
Contributor

@dochollidayxx dochollidayxx commented Sep 20, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

dochollidayxx and others added 20 commits August 19, 2021 10:47
@dochollidayxx
Adds base for updating Microsoft.Security from version stable/2021-07…
9678550 
…-01 to version 2021-08-01-preview
@dochollidayxx
Updates readme
affd393
@dochollidayxx
Updates API version in new specs and examples
149a360
First pass at Microsoft.Security/standards for review/preview
f7ded94
Addressing Round-1 feedback, adding missing descriptions and changing…
d75f361 
… scoping to match ProxyResource type
First pass for Microsoft.Security\standardComponents
551900c
Changes to fix a typo in an example spec
8e32e2d
Added Microsoft.Security/standardAssignments
255431d
Fix naming convention issue
05a3e96
Removed types based on Hila's feedback
e8cb807
Changes to data model for both API calls
fd9ca41
Fix example errors and typos
fa893f9
Add systemData to Microsoft.Security/standards
06a8c3b
Changes to fix systemData linting
7c7155c
un-nest systemData fields in examples
13975c3
More systemData placement
b1077b5
Naming convention name to assignments from standardAssignment
f285029
Additional example added
a1732f3
Changes to address descriptive comments on field types
2ca2b27
Add systemData readOnly
a5aa447
@openapi-workflow-bot
Copy link

Hi, @dochollidayxx Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 20, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ❌ R4037 - MissingTypeObject The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: resource-manager/common/v1/types.json#L59
    ❌ R4037 - MissingTypeObject The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: resource-manager/common/v1/types.json#L59
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ❌ AutorestCore/Exception "readme":"security/resource-manager/readme.md",
    "tag":"package-composite-v1",
    "details":"Error: Semantic validation failed. There was some errors"
    ❌ AutorestCore/Exception "readme":"security/resource-manager/readme.md",
    "tag":"package-composite-v2",
    "details":"Error: Semantic validation failed. There was some errors"
    ❌ AutorestCore/Exception "readme":"security/resource-manager/readme.md",
    "tag":"package-composite-v3",
    "details":"Error: Plugin prechecker reported failure."
    ❌ AutorestCore/Exception "readme":"security/resource-manager/readme.md",
    "tag":"package-2015-06-preview-only",
    "details":"Error: Semantic validation failed. There was some errors"
    ❌ AutorestCore/Exception "readme":"security/resource-manager/readme.md",
    "tag":"package-2020-01-only",
    "details":"Error: Plugin prechecker reported failure."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 20, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @dochollidayxx, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @dochollidayxx dochollidayxx marked this pull request as ready for review September 20, 2021 18:20
    This was referenced Sep 20, 2021
    Closed
    Closed
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @dochollidayxx your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @dochollidayxx
    Copy link
    Contributor Author

    Please let me know any remaining items needed to merge in this documentation change.

    @dochollidayxx
    Copy link
    Contributor Author

    Dealt with merge conflict.

    @ruowan ruowan merged commit 9dcd83c into Azure:main Sep 29, 2021
    This was referenced Sep 29, 2021
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 29, 2021
    [ReleasePR security] [Hub Generated] Review request for Microsoft.Sec…
    6c7cabd 
    …urity to add version preview/2021-08-01-preview (#1925)

Create to sync Azure/azure-rest-api-specs#16096
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/security?expand=1)
    zhenglaizhang added a commit that referenced this pull request Sep 30, 2021
    @ericshape @JackTn
    @zhenglaizhang @leni-msft @najian @raych1 @idear1203 @msyyc @AriZavala2 @PingZhu2232 @markcowl @Mohit-Chakraborty @roslynlu @Alancere @edwin-msft @dochollidayxx @yifan-zhou922 @parvsaxena @hvermis @xuepingd @laxmankumar12 @hjhhh3000vitae @RAY-316 @kangsun-ctrl @brpanask @rebecca337 @xunsun-commits @wanyang7 @soma-ms
    Sync sql 2021 05 01 with main branch (#16236)
    71fa9f5 
    * Update comment.yml for publish pr (#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (#16170)

* bump avocado

* bump mocha

* remove submodule (#16171)

* add azure-resource-manager-schema to servicelinker (#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (#16164)

Merging the change to have accurate Swagger

* Remove requirement of identity field in the request for TURN. (#15966)

* Remove requirement of identity field in the request.

* Update PR

* Address comment

* change api version in readme for sdk release (#16187)

* Add blockchain to latest profile

* Add additional types

* api version change

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>

* [Search] Rename types for better SDK code (#16039)

* Rename types for better SDK code

* Rename Speller and Captions search options

* Reorder parameters to have consistency across APIs

* Remove 'SearchIndexer' prefix from projection selectors

Remove 'global' prefix from default flags on custom entities

* Change enum name AdlsGen2->AzureDataLakeStorageGen2

Change property name storageContainer->storageContainerName

* move additional .NET SDK renames to the REST spec

* Revert changes in KnowledgeStore which has GAed

* Revert changes in CustomEntityLookupSkill which has GAed

* Revert changes in SIKSBlobProjectionSelector which has GAed

* Revert changes in SearchIndexerDataSourceType which has GAed

* Rename ignoreResetRequirements->skipIndexerResetRequirementForCache

* fix validStreamingUnits (#16143)

Co-authored-by: Roslyn Lu <[email protected]>

* Fix schemas readme files (#16207)

* Fix schemas readme files

* fix ref

* add resourcemanager in module-name (#16206)

* add resourcemanager in module-name

* add go track2 repo in readme.md

* fix

* Minor description update for createorupdate & update slot (#15457)

* add scmMinTlsVersion

* modify description for createorupdate & update slot for all API versions

Co-authored-by: Edwin Diaz <[email protected]>

* [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (#16096)

* Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* First pass at Microsoft.Security/standards for review/preview

* Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type

* First pass for Microsoft.Security\standardComponents

* Changes to fix a typo in an example spec

* Added Microsoft.Security/standardAssignments

* Fix naming convention issue

* Removed types based on Hila's feedback

* Changes to data model for both API calls

* Fix example errors and typos

* Add systemData to Microsoft.Security/standards

* Changes to fix systemData linting

* un-nest systemData fields in examples

* More systemData placement

* Naming convention name to assignments from standardAssignment

* Additional example added

* Changes to address descriptive comments on field types

* Add systemData readOnly

* prettier-fix against examples

* Cleaned types to ref standard v2 common-types entry similar to securityForIoT

* Re-added v2 folder?

* Missed a change here?

* Cleanup of v2 type completely, updated readme.md

* Adds suppression to readme

* Adds suppression to readme

* Change modification to suppress operations linting

Co-authored-by: Adam Holliday <[email protected]>

* Yifanzhou/api version change (#16191)

* remove Catalog

* update 2021-05-01-preview

* delete 2021-09-01

* Update readme.md

* Update purviewcatalog.json

* change read-only property (#16209)

Co-authored-by: Parv Saxena <[email protected]>

* Update account.json - make CollectionReferece type writable (#16208)

* Update account.json

Updating the CollectionReference to be writeable to unblock the customers.

* Update account.json

Need the default set in the client SDK

* Fixed an event name typo in its description. (#16227)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (#15723)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview

* Add PrivateResourceProviderConfigurations

* Add PrivateRP examples

* Fix enum type.

* Fix enum again

* Prettier

* Fix prettier error

* Add readme.md + prettier

* Fix

* Fix avocado error

* Modify interface

* Fix issue

* Make it private preview

* Remove private RP changes

* Update SKU settings

Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>

* fluidrelay_readme_config (#16192)

fluidrelay_readme_config

* Add community gallery proxy resource (#16043)

* [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (#16152)

* Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01

* Updates readme

* Updates API version in new specs and examples

* 2021-09-01 API

* Fix LintDiff

Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (#15946)

* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

* Change enum first letter to lower case

* Change to upper case

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs

* Add email reminder when PR makes changes in Synapse (#16116)

* add email reminder to synapse

* fix for comment

* ServiceBus add batch tag (#16229)

* add code owner to synapse (#16230)

* [Datafactory] Power Query model changes for multiple queries (#16158)

* [Synapse] Add release tag for management SDK Oct. release (#16213)

* update release tag

* fix for avocado

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>
    @RamyasreeChakka
    Copy link
    Member

    RamyasreeChakka commented Oct 4, 2021 •
    edited
    Loading

    @ruowan I noticed this PR has label 'WaitForARMFeedback' but got merged without ARM sign off. Is this intentional? I am wondering if any of the merge checks break.

    I reviewed the PR just now and it looks good to me. Adding ARMSignedOff label now.

    @RamyasreeChakka RamyasreeChakka added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 4, 2021
    zhenglaizhang added a commit that referenced this pull request Oct 6, 2021
    @ericshape @JackTn
    @zhenglaizhang @leni-msft @najian @raych1 @idear1203 @msyyc @AriZavala2 @PingZhu2232 @markcowl @Mohit-Chakraborty @roslynlu @Alancere @edwin-msft @dochollidayxx @yifan-zhou922 @parvsaxena @hvermis @xuepingd @laxmankumar12 @hjhhh3000vitae @RAY-316 @kangsun-ctrl @brpanask @rebecca337 @xunsun-commits @wanyang7 @soma-ms
    Dev sql microsoft.sql 2021 05 01 preview release (#16289)
    50aff77 
    * add base for Microsoft.sql

* Update Readme.md

* update version in swagger example files

* remove ss

* update swagger files

* update readme.md

* add missing json files

* update custom-words.txt to address the spelling check

* remove 201 define in ServerUpdate.json

* Sync sql 2021 05 01 with main branch (#16236)

* Update comment.yml for publish pr (#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (#16170)

* bump avocado

* bump mocha

* remove submodule (#16171)

* add azure-resource-manager-schema to servicelinker (#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (#16164)

Merging the change to have accurate Swagger

* Remove requirement of identity field in the request for TURN. (#15966)

* Remove requirement of identity field in the request.

* Update PR

* Address comment

* change api version in readme for sdk release (#16187)

* Add blockchain to latest profile

* Add additional types

* api version change

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>

* [Search] Rename types for better SDK code (#16039)

* Rename types for better SDK code

* Rename Speller and Captions search options

* Reorder parameters to have consistency across APIs

* Remove 'SearchIndexer' prefix from projection selectors

Remove 'global' prefix from default flags on custom entities

* Change enum name AdlsGen2->AzureDataLakeStorageGen2

Change property name storageContainer->storageContainerName

* move additional .NET SDK renames to the REST spec

* Revert changes in KnowledgeStore which has GAed

* Revert changes in CustomEntityLookupSkill which has GAed

* Revert changes in SIKSBlobProjectionSelector which has GAed

* Revert changes in SearchIndexerDataSourceType which has GAed

* Rename ignoreResetRequirements->skipIndexerResetRequirementForCache

* fix validStreamingUnits (#16143)

Co-authored-by: Roslyn Lu <[email protected]>

* Fix schemas readme files (#16207)

* Fix schemas readme files

* fix ref

* add resourcemanager in module-name (#16206)

* add resourcemanager in module-name

* add go track2 repo in readme.md

* fix

* Minor description update for createorupdate & update slot (#15457)

* add scmMinTlsVersion

* modify description for createorupdate & update slot for all API versions

Co-authored-by: Edwin Diaz <[email protected]>

* [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (#16096)

* Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* First pass at Microsoft.Security/standards for review/preview

* Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type

* First pass for Microsoft.Security\standardComponents

* Changes to fix a typo in an example spec

* Added Microsoft.Security/standardAssignments

* Fix naming convention issue

* Removed types based on Hila's feedback

* Changes to data model for both API calls

* Fix example errors and typos

* Add systemData to Microsoft.Security/standards

* Changes to fix systemData linting

* un-nest systemData fields in examples

* More systemData placement

* Naming convention name to assignments from standardAssignment

* Additional example added

* Changes to address descriptive comments on field types

* Add systemData readOnly

* prettier-fix against examples

* Cleaned types to ref standard v2 common-types entry similar to securityForIoT

* Re-added v2 folder?

* Missed a change here?

* Cleanup of v2 type completely, updated readme.md

* Adds suppression to readme

* Adds suppression to readme

* Change modification to suppress operations linting

Co-authored-by: Adam Holliday <[email protected]>

* Yifanzhou/api version change (#16191)

* remove Catalog

* update 2021-05-01-preview

* delete 2021-09-01

* Update readme.md

* Update purviewcatalog.json

* change read-only property (#16209)

Co-authored-by: Parv Saxena <[email protected]>

* Update account.json - make CollectionReferece type writable (#16208)

* Update account.json

Updating the CollectionReference to be writeable to unblock the customers.

* Update account.json

Need the default set in the client SDK

* Fixed an event name typo in its description. (#16227)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (#15723)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview

* Add PrivateResourceProviderConfigurations

* Add PrivateRP examples

* Fix enum type.

* Fix enum again

* Prettier

* Fix prettier error

* Add readme.md + prettier

* Fix

* Fix avocado error

* Modify interface

* Fix issue

* Make it private preview

* Remove private RP changes

* Update SKU settings

Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>

* fluidrelay_readme_config (#16192)

fluidrelay_readme_config

* Add community gallery proxy resource (#16043)

* [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (#16152)

* Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01

* Updates readme

* Updates API version in new specs and examples

* 2021-09-01 API

* Fix LintDiff

Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (#15946)

* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

* Change enum first letter to lower case

* Change to upper case

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs

* Add email reminder when PR makes changes in Synapse (#16116)

* add email reminder to synapse

* fix for comment

* ServiceBus add batch tag (#16229)

* add code owner to synapse (#16230)

* [Datafactory] Power Query model changes for multiple queries (#16158)

* [Synapse] Add release tag for management SDK Oct. release (#16213)

* update release tag

* fix for avocado

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>

* remove blank line

* address comments

* address the description comment

* update the swagger

* remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance

* Update from microsoft.sql 2021-05-01-preview to base branch (#16184)

* Update comment.yml for publish pr (#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (#16170)

* bump avocado

* bump mocha

* remove submodule (#16171)

* add azure-resource-manager-schema to servicelinker (#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (#16164)

Merging the change to have accurate Swagger

* update swagger files

* update readme.md

* add missing json files

* update custom-words.txt to address the spelling check

* remove 201 define in ServerUpdate.json

* remove blank line

* address comments

* address the description comment

* update the swagger

* remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>
    @ArcturusZhang ArcturusZhang mentioned this pull request Oct 14, 2021
    Merged
    25 tasks
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @dochollidayxx @LeiWang3
    [Hub Generated] Review request for Microsoft.Security to add version …
    b6a3dd7 
    …preview/2021-08-01-preview (Azure#16096)

* Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* First pass at Microsoft.Security/standards for review/preview

* Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type

* First pass for Microsoft.Security\standardComponents

* Changes to fix a typo in an example spec

* Added Microsoft.Security/standardAssignments

* Fix naming convention issue

* Removed types based on Hila's feedback

* Changes to data model for both API calls

* Fix example errors and typos

* Add systemData to Microsoft.Security/standards

* Changes to fix systemData linting

* un-nest systemData fields in examples

* More systemData placement

* Naming convention name to assignments from standardAssignment

* Additional example added

* Changes to address descriptive comments on field types

* Add systemData readOnly

* prettier-fix against examples

* Cleaned types to ref standard v2 common-types entry similar to securityForIoT

* Re-added v2 folder?

* Missed a change here?

* Cleanup of v2 type completely, updated readme.md

* Adds suppression to readme

* Adds suppression to readme

* Change modification to suppress operations linting

Co-authored-by: Adam Holliday <[email protected]>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @ericshape @JackTn
    @zhenglaizhang @leni-msft @najian @raych1 @idear1203 @msyyc @AriZavala2 @PingZhu2232 @markcowl @Mohit-Chakraborty @roslynlu @Alancere @edwin-msft @dochollidayxx @yifan-zhou922 @parvsaxena @hvermis @xuepingd @laxmankumar12 @hjhhh3000vitae @RAY-316 @kangsun-ctrl @brpanask @rebecca337 @xunsun-commits @wanyang7 @soma-ms @LeiWang3
    Dev sql microsoft.sql 2021 05 01 preview release (Azure#16289)
    4807a3d 
    * add base for Microsoft.sql

* Update Readme.md

* update version in swagger example files

* remove ss

* update swagger files

* update readme.md

* add missing json files

* update custom-words.txt to address the spelling check

* remove 201 define in ServerUpdate.json

* Sync sql 2021 05 01 with main branch (Azure#16236)

* Update comment.yml for publish pr (Azure#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (Azure#16170)

* bump avocado

* bump mocha

* remove submodule (Azure#16171)

* add azure-resource-manager-schema to servicelinker (Azure#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (Azure#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (Azure#16164)

Merging the change to have accurate Swagger

* Remove requirement of identity field in the request for TURN. (Azure#15966)

* Remove requirement of identity field in the request.

* Update PR

* Address comment

* change api version in readme for sdk release (Azure#16187)

* Add blockchain to latest profile

* Add additional types

* api version change

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>

* [Search] Rename types for better SDK code (Azure#16039)

* Rename types for better SDK code

* Rename Speller and Captions search options

* Reorder parameters to have consistency across APIs

* Remove 'SearchIndexer' prefix from projection selectors

Remove 'global' prefix from default flags on custom entities

* Change enum name AdlsGen2->AzureDataLakeStorageGen2

Change property name storageContainer->storageContainerName

* move additional .NET SDK renames to the REST spec

* Revert changes in KnowledgeStore which has GAed

* Revert changes in CustomEntityLookupSkill which has GAed

* Revert changes in SIKSBlobProjectionSelector which has GAed

* Revert changes in SearchIndexerDataSourceType which has GAed

* Rename ignoreResetRequirements->skipIndexerResetRequirementForCache

* fix validStreamingUnits (Azure#16143)

Co-authored-by: Roslyn Lu <[email protected]>

* Fix schemas readme files (Azure#16207)

* Fix schemas readme files

* fix ref

* add resourcemanager in module-name (Azure#16206)

* add resourcemanager in module-name

* add go track2 repo in readme.md

* fix

* Minor description update for createorupdate & update slot (Azure#15457)

* add scmMinTlsVersion

* modify description for createorupdate & update slot for all API versions

Co-authored-by: Edwin Diaz <[email protected]>

* [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (Azure#16096)

* Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* First pass at Microsoft.Security/standards for review/preview

* Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type

* First pass for Microsoft.Security\standardComponents

* Changes to fix a typo in an example spec

* Added Microsoft.Security/standardAssignments

* Fix naming convention issue

* Removed types based on Hila's feedback

* Changes to data model for both API calls

* Fix example errors and typos

* Add systemData to Microsoft.Security/standards

* Changes to fix systemData linting

* un-nest systemData fields in examples

* More systemData placement

* Naming convention name to assignments from standardAssignment

* Additional example added

* Changes to address descriptive comments on field types

* Add systemData readOnly

* prettier-fix against examples

* Cleaned types to ref standard v2 common-types entry similar to securityForIoT

* Re-added v2 folder?

* Missed a change here?

* Cleanup of v2 type completely, updated readme.md

* Adds suppression to readme

* Adds suppression to readme

* Change modification to suppress operations linting

Co-authored-by: Adam Holliday <[email protected]>

* Yifanzhou/api version change (Azure#16191)

* remove Catalog

* update 2021-05-01-preview

* delete 2021-09-01

* Update readme.md

* Update purviewcatalog.json

* change read-only property (Azure#16209)

Co-authored-by: Parv Saxena <[email protected]>

* Update account.json - make CollectionReferece type writable (Azure#16208)

* Update account.json

Updating the CollectionReference to be writeable to unblock the customers.

* Update account.json

Need the default set in the client SDK

* Fixed an event name typo in its description. (Azure#16227)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (Azure#15723)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview

* Add PrivateResourceProviderConfigurations

* Add PrivateRP examples

* Fix enum type.

* Fix enum again

* Prettier

* Fix prettier error

* Add readme.md + prettier

* Fix

* Fix avocado error

* Modify interface

* Fix issue

* Make it private preview

* Remove private RP changes

* Update SKU settings

Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>

* fluidrelay_readme_config (Azure#16192)

fluidrelay_readme_config

* Add community gallery proxy resource (Azure#16043)

* [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (Azure#16152)

* Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01

* Updates readme

* Updates API version in new specs and examples

* 2021-09-01 API

* Fix LintDiff

Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (Azure#15946)

* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

* Change enum first letter to lower case

* Change to upper case

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs

* Add email reminder when PR makes changes in Synapse (Azure#16116)

* add email reminder to synapse

* fix for comment

* ServiceBus add batch tag (Azure#16229)

* add code owner to synapse (Azure#16230)

* [Datafactory] Power Query model changes for multiple queries (Azure#16158)

* [Synapse] Add release tag for management SDK Oct. release (Azure#16213)

* update release tag

* fix for avocado

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>

* remove blank line

* address comments

* address the description comment

* update the swagger

* remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance

* Update from microsoft.sql 2021-05-01-preview to base branch (Azure#16184)

* Update comment.yml for publish pr (Azure#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (Azure#16170)

* bump avocado

* bump mocha

* remove submodule (Azure#16171)

* add azure-resource-manager-schema to servicelinker (Azure#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (Azure#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (Azure#16164)

Merging the change to have accurate Swagger

* update swagger files

* update readme.md

* add missing json files

* update custom-words.txt to address the spelling check

* remove 201 define in ServerUpdate.json

* remove blank line

* address comments

* address the description comment

* update the swagger

* remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ruowan ruowan ruowan approved these changes

    Assignees

    @ruowan ruowan

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @dochollidayxx @RamyasreeChakka @ruowan