Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview #15723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @laxmankumar12 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3880 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3904 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: origin Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3857 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: actionType Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3873 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2492 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3853 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4419 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowNoncompliantCollectionResponse Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4938 |
|
| 'ProvisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2199 |
|
| 'expeditedRollout' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2501 |
|
| 'endpointType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2919 |
|
| 'readiness' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3044 |
|
| 'LocalizedOperationDisplayDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3690 |
|
| 'LocalizedOperationDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3842 |
|
| 'origin' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3857 |
|
| 'actionType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3873 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3880 |
|
| 'OperationsContentProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3883 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3904 |
|
| 'endpointType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4296 |
|
| 'ResourceConcurrencyControlOption' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4400 |
|
| 'policy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4403 |
|
| 'ResourceGraphConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4416 |
|
| 'enabled' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4419 |
|
| 'apiVersion' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4422 |
|
| 'resourceConcurrencyControlOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4625 |
|
| 'resourceGraphConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4631 |
|
| 'management' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4638 |
|
| 'OpenApiConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4927 |
|
| 'OpenApiValidation' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4935 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2373 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2641 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3580 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3670 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4186 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4658 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4898 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: marketplaceType Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3218 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: resourceAccessPolicy Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3339 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: origin Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3647 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: actionType Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3663 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: marketplaceType Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4473 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4746 |
|
| 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'ProviderRegistrations_CreateOrUpdate', Response code: '201' Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L941 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2884 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3389 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isCheckedIn Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3499 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L3643 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: preflightSupported Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4048 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4258 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableDefaultValidation Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4375 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationRequired Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4389 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: crossResourceGroupMoveEnabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4392 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: crossSubscriptionMoveEnabled Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4395 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAsyncOperation Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4534 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableThirdPartyS2S Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4541 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPureProxy Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L4551 |
|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L7 |
|
| 'TrafficRegions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2221 |
|
| 'CustomRolloutSpecification' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#L2232 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 7 Errors, 10 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2021-09-01-preview/providerhub.json compared with base:stable/2020-11-20/providerhub.json
- current:preview/2021-09-01-preview/providerhub.json compared with base:preview/2021-06-01-preview/providerhub.json
The following breaking changes are detected by comparison with latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 1 Errors, 6 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"Error: Plugin pre-namer reported failure." |
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"The schema 'ResourceProviderManagement-resourceAccessRolesItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#/components/schemas/ResourceProviderManagement-resourceAccessRolesItem" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"The schema 'ResourceProviderManifestProperties-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#/components/schemas/ResourceProviderManifestProperties-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"The schema 'ResourceType-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#/components/schemas/ResourceType-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"The schema 'ResourceProviderManifest-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#/components/schemas/ResourceProviderManifest-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"The schema 'OperationsDefinition-properties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#/components/schemas/OperationsDefinition-properties" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"The schema 'LocalizedOperationDefinition-properties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-09-01-preview/providerhub.json#/components/schemas/LocalizedOperationDefinition-properties" |
|
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2021-09-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @laxmankumar12, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 20, 2021
Add PrivateResourceProviderConfigurations
|
@laxmankumar12 please help fix the avocado and prettier check issues #15723 (comment) |
Update PrivateRP interface
@zhenglaizhang There is no breaking change from 2021-06-01-preview which was the previous preview version that was introduced. There has been breaking changes from the previous stable version of course. Does this still need the breaking change review process? The reason I ask this is because my team is expecting to release a monthly -preview version and if we are needed to get the breaking change review done for each of these versions, it might be too time consuming both for the reviewers and us. @sanjaiganesh - FYI. |
|
@laxmankumar12 the stable version is still live and takes the traffic, and also you are public the new API version since you are sending PR to the public spec repo, you need to do breaking change review. |
|
Hi @laxmankumar12, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@laxmankumar12 , can you attach the previous PR link so that we can approve this PR? |
@raych1 @zhenglaizhang Please check this PR. It was to add 2021-06-01-preview and got approval for breaking change. #14650 |
@raych1 @zhenglaizhang Could someone please check this PR? |
|
Hi @hjhhh3000vitae @laxmankumar12 |
Update SKU settings
Hello @zhenglaizhang Thank you for pointing out. This was due to a new change we did not pick up in this PR. I've updated this PR. Now there is only |
Kindly ping. @zhenglaizhang @raych1 |
Kingly ping. @zhenglaizhang @raych1 |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @laxmankumar12 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
mentat9
added
ARMSignedOff
|
Signing off from ARM side. |
zhenglaizhang
approved these changes
Sep 30, 2021
This was referenced Sep 30, 2021
Closed
zhenglaizhang
added a commit
that referenced
this pull request
Sep 30, 2021
* Update comment.yml for publish pr (#16166) * Update comment.yml * Update comment.yml * Bump dependencies (#16170) * bump avocado * bump mocha * remove submodule (#16171) * add azure-resource-manager-schema to servicelinker (#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (#16164) Merging the change to have accurate Swagger * Remove requirement of identity field in the request for TURN. (#15966) * Remove requirement of identity field in the request. * Update PR * Address comment * change api version in readme for sdk release (#16187) * Add blockchain to latest profile * Add additional types * api version change Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> * [Search] Rename types for better SDK code (#16039) * Rename types for better SDK code * Rename Speller and Captions search options * Reorder parameters to have consistency across APIs * Remove 'SearchIndexer' prefix from projection selectors Remove 'global' prefix from default flags on custom entities * Change enum name AdlsGen2->AzureDataLakeStorageGen2 Change property name storageContainer->storageContainerName * move additional .NET SDK renames to the REST spec * Revert changes in KnowledgeStore which has GAed * Revert changes in CustomEntityLookupSkill which has GAed * Revert changes in SIKSBlobProjectionSelector which has GAed * Revert changes in SearchIndexerDataSourceType which has GAed * Rename ignoreResetRequirements->skipIndexerResetRequirementForCache * fix validStreamingUnits (#16143) Co-authored-by: Roslyn Lu <[email protected]> * Fix schemas readme files (#16207) * Fix schemas readme files * fix ref * add resourcemanager in module-name (#16206) * add resourcemanager in module-name * add go track2 repo in readme.md * fix * Minor description update for createorupdate & update slot (#15457) * add scmMinTlsVersion * modify description for createorupdate & update slot for all API versions Co-authored-by: Edwin Diaz <[email protected]> * [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (#16096) * Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview * Updates readme * Updates API version in new specs and examples * First pass at Microsoft.Security/standards for review/preview * Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type * First pass for Microsoft.Security\standardComponents * Changes to fix a typo in an example spec * Added Microsoft.Security/standardAssignments * Fix naming convention issue * Removed types based on Hila's feedback * Changes to data model for both API calls * Fix example errors and typos * Add systemData to Microsoft.Security/standards * Changes to fix systemData linting * un-nest systemData fields in examples * More systemData placement * Naming convention name to assignments from standardAssignment * Additional example added * Changes to address descriptive comments on field types * Add systemData readOnly * prettier-fix against examples * Cleaned types to ref standard v2 common-types entry similar to securityForIoT * Re-added v2 folder? * Missed a change here? * Cleanup of v2 type completely, updated readme.md * Adds suppression to readme * Adds suppression to readme * Change modification to suppress operations linting Co-authored-by: Adam Holliday <[email protected]> * Yifanzhou/api version change (#16191) * remove Catalog * update 2021-05-01-preview * delete 2021-09-01 * Update readme.md * Update purviewcatalog.json * change read-only property (#16209) Co-authored-by: Parv Saxena <[email protected]> * Update account.json - make CollectionReferece type writable (#16208) * Update account.json Updating the CollectionReference to be writeable to unblock the customers. * Update account.json Need the default set in the client SDK * Fixed an event name typo in its description. (#16227) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (#15723) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview * Add PrivateResourceProviderConfigurations * Add PrivateRP examples * Fix enum type. * Fix enum again * Prettier * Fix prettier error * Add readme.md + prettier * Fix * Fix avocado error * Modify interface * Fix issue * Make it private preview * Remove private RP changes * Update SKU settings Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> * fluidrelay_readme_config (#16192) fluidrelay_readme_config * Add community gallery proxy resource (#16043) * [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (#16152) * Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * 2021-09-01 API * Fix LintDiff Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (#15946) * Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview * Change enum first letter to lower case * Change to upper case * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs * Add email reminder when PR makes changes in Synapse (#16116) * add email reminder to synapse * fix for comment * ServiceBus add batch tag (#16229) * add code owner to synapse (#16230) * [Datafactory] Power Query model changes for multiple queries (#16158) * [Synapse] Add release tag for management SDK Oct. release (#16213) * update release tag * fix for avocado Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]>
zhenglaizhang
added a commit
that referenced
this pull request
Oct 6, 2021
* add base for Microsoft.sql * Update Readme.md * update version in swagger example files * remove ss * update swagger files * update readme.md * add missing json files * update custom-words.txt to address the spelling check * remove 201 define in ServerUpdate.json * Sync sql 2021 05 01 with main branch (#16236) * Update comment.yml for publish pr (#16166) * Update comment.yml * Update comment.yml * Bump dependencies (#16170) * bump avocado * bump mocha * remove submodule (#16171) * add azure-resource-manager-schema to servicelinker (#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (#16164) Merging the change to have accurate Swagger * Remove requirement of identity field in the request for TURN. (#15966) * Remove requirement of identity field in the request. * Update PR * Address comment * change api version in readme for sdk release (#16187) * Add blockchain to latest profile * Add additional types * api version change Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> * [Search] Rename types for better SDK code (#16039) * Rename types for better SDK code * Rename Speller and Captions search options * Reorder parameters to have consistency across APIs * Remove 'SearchIndexer' prefix from projection selectors Remove 'global' prefix from default flags on custom entities * Change enum name AdlsGen2->AzureDataLakeStorageGen2 Change property name storageContainer->storageContainerName * move additional .NET SDK renames to the REST spec * Revert changes in KnowledgeStore which has GAed * Revert changes in CustomEntityLookupSkill which has GAed * Revert changes in SIKSBlobProjectionSelector which has GAed * Revert changes in SearchIndexerDataSourceType which has GAed * Rename ignoreResetRequirements->skipIndexerResetRequirementForCache * fix validStreamingUnits (#16143) Co-authored-by: Roslyn Lu <[email protected]> * Fix schemas readme files (#16207) * Fix schemas readme files * fix ref * add resourcemanager in module-name (#16206) * add resourcemanager in module-name * add go track2 repo in readme.md * fix * Minor description update for createorupdate & update slot (#15457) * add scmMinTlsVersion * modify description for createorupdate & update slot for all API versions Co-authored-by: Edwin Diaz <[email protected]> * [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (#16096) * Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview * Updates readme * Updates API version in new specs and examples * First pass at Microsoft.Security/standards for review/preview * Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type * First pass for Microsoft.Security\standardComponents * Changes to fix a typo in an example spec * Added Microsoft.Security/standardAssignments * Fix naming convention issue * Removed types based on Hila's feedback * Changes to data model for both API calls * Fix example errors and typos * Add systemData to Microsoft.Security/standards * Changes to fix systemData linting * un-nest systemData fields in examples * More systemData placement * Naming convention name to assignments from standardAssignment * Additional example added * Changes to address descriptive comments on field types * Add systemData readOnly * prettier-fix against examples * Cleaned types to ref standard v2 common-types entry similar to securityForIoT * Re-added v2 folder? * Missed a change here? * Cleanup of v2 type completely, updated readme.md * Adds suppression to readme * Adds suppression to readme * Change modification to suppress operations linting Co-authored-by: Adam Holliday <[email protected]> * Yifanzhou/api version change (#16191) * remove Catalog * update 2021-05-01-preview * delete 2021-09-01 * Update readme.md * Update purviewcatalog.json * change read-only property (#16209) Co-authored-by: Parv Saxena <[email protected]> * Update account.json - make CollectionReferece type writable (#16208) * Update account.json Updating the CollectionReference to be writeable to unblock the customers. * Update account.json Need the default set in the client SDK * Fixed an event name typo in its description. (#16227) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (#15723) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview * Add PrivateResourceProviderConfigurations * Add PrivateRP examples * Fix enum type. * Fix enum again * Prettier * Fix prettier error * Add readme.md + prettier * Fix * Fix avocado error * Modify interface * Fix issue * Make it private preview * Remove private RP changes * Update SKU settings Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> * fluidrelay_readme_config (#16192) fluidrelay_readme_config * Add community gallery proxy resource (#16043) * [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (#16152) * Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * 2021-09-01 API * Fix LintDiff Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (#15946) * Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview * Change enum first letter to lower case * Change to upper case * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs * Add email reminder when PR makes changes in Synapse (#16116) * add email reminder to synapse * fix for comment * ServiceBus add batch tag (#16229) * add code owner to synapse (#16230) * [Datafactory] Power Query model changes for multiple queries (#16158) * [Synapse] Add release tag for management SDK Oct. release (#16213) * update release tag * fix for avocado Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]> * remove blank line * address comments * address the description comment * update the swagger * remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance * Update from microsoft.sql 2021-05-01-preview to base branch (#16184) * Update comment.yml for publish pr (#16166) * Update comment.yml * Update comment.yml * Bump dependencies (#16170) * bump avocado * bump mocha * remove submodule (#16171) * add azure-resource-manager-schema to servicelinker (#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (#16164) Merging the change to have accurate Swagger * update swagger files * update readme.md * add missing json files * update custom-words.txt to address the spelling check * remove 201 define in ServerUpdate.json * remove blank line * address comments * address the description comment * update the swagger * remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
Azure#15723) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview * Add PrivateResourceProviderConfigurations * Add PrivateRP examples * Fix enum type. * Fix enum again * Prettier * Fix prettier error * Add readme.md + prettier * Fix * Fix avocado error * Modify interface * Fix issue * Make it private preview * Remove private RP changes * Update SKU settings Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* add base for Microsoft.sql * Update Readme.md * update version in swagger example files * remove ss * update swagger files * update readme.md * add missing json files * update custom-words.txt to address the spelling check * remove 201 define in ServerUpdate.json * Sync sql 2021 05 01 with main branch (Azure#16236) * Update comment.yml for publish pr (Azure#16166) * Update comment.yml * Update comment.yml * Bump dependencies (Azure#16170) * bump avocado * bump mocha * remove submodule (Azure#16171) * add azure-resource-manager-schema to servicelinker (Azure#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (Azure#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (Azure#16164) Merging the change to have accurate Swagger * Remove requirement of identity field in the request for TURN. (Azure#15966) * Remove requirement of identity field in the request. * Update PR * Address comment * change api version in readme for sdk release (Azure#16187) * Add blockchain to latest profile * Add additional types * api version change Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> * [Search] Rename types for better SDK code (Azure#16039) * Rename types for better SDK code * Rename Speller and Captions search options * Reorder parameters to have consistency across APIs * Remove 'SearchIndexer' prefix from projection selectors Remove 'global' prefix from default flags on custom entities * Change enum name AdlsGen2->AzureDataLakeStorageGen2 Change property name storageContainer->storageContainerName * move additional .NET SDK renames to the REST spec * Revert changes in KnowledgeStore which has GAed * Revert changes in CustomEntityLookupSkill which has GAed * Revert changes in SIKSBlobProjectionSelector which has GAed * Revert changes in SearchIndexerDataSourceType which has GAed * Rename ignoreResetRequirements->skipIndexerResetRequirementForCache * fix validStreamingUnits (Azure#16143) Co-authored-by: Roslyn Lu <[email protected]> * Fix schemas readme files (Azure#16207) * Fix schemas readme files * fix ref * add resourcemanager in module-name (Azure#16206) * add resourcemanager in module-name * add go track2 repo in readme.md * fix * Minor description update for createorupdate & update slot (Azure#15457) * add scmMinTlsVersion * modify description for createorupdate & update slot for all API versions Co-authored-by: Edwin Diaz <[email protected]> * [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (Azure#16096) * Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview * Updates readme * Updates API version in new specs and examples * First pass at Microsoft.Security/standards for review/preview * Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type * First pass for Microsoft.Security\standardComponents * Changes to fix a typo in an example spec * Added Microsoft.Security/standardAssignments * Fix naming convention issue * Removed types based on Hila's feedback * Changes to data model for both API calls * Fix example errors and typos * Add systemData to Microsoft.Security/standards * Changes to fix systemData linting * un-nest systemData fields in examples * More systemData placement * Naming convention name to assignments from standardAssignment * Additional example added * Changes to address descriptive comments on field types * Add systemData readOnly * prettier-fix against examples * Cleaned types to ref standard v2 common-types entry similar to securityForIoT * Re-added v2 folder? * Missed a change here? * Cleanup of v2 type completely, updated readme.md * Adds suppression to readme * Adds suppression to readme * Change modification to suppress operations linting Co-authored-by: Adam Holliday <[email protected]> * Yifanzhou/api version change (Azure#16191) * remove Catalog * update 2021-05-01-preview * delete 2021-09-01 * Update readme.md * Update purviewcatalog.json * change read-only property (Azure#16209) Co-authored-by: Parv Saxena <[email protected]> * Update account.json - make CollectionReferece type writable (Azure#16208) * Update account.json Updating the CollectionReference to be writeable to unblock the customers. * Update account.json Need the default set in the client SDK * Fixed an event name typo in its description. (Azure#16227) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (Azure#15723) * Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview * Add PrivateResourceProviderConfigurations * Add PrivateRP examples * Fix enum type. * Fix enum again * Prettier * Fix prettier error * Add readme.md + prettier * Fix * Fix avocado error * Modify interface * Fix issue * Make it private preview * Remove private RP changes * Update SKU settings Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> * fluidrelay_readme_config (Azure#16192) fluidrelay_readme_config * Add community gallery proxy resource (Azure#16043) * [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (Azure#16152) * Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * 2021-09-01 API * Fix LintDiff Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (Azure#15946) * Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview * Change enum first letter to lower case * Change to upper case * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs * Add email reminder when PR makes changes in Synapse (Azure#16116) * add email reminder to synapse * fix for comment * ServiceBus add batch tag (Azure#16229) * add code owner to synapse (Azure#16230) * [Datafactory] Power Query model changes for multiple queries (Azure#16158) * [Synapse] Add release tag for management SDK Oct. release (Azure#16213) * update release tag * fix for avocado Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]> * remove blank line * address comments * address the description comment * update the swagger * remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance * Update from microsoft.sql 2021-05-01-preview to base branch (Azure#16184) * Update comment.yml for publish pr (Azure#16166) * Update comment.yml * Update comment.yml * Bump dependencies (Azure#16170) * bump avocado * bump mocha * remove submodule (Azure#16171) * add azure-resource-manager-schema to servicelinker (Azure#16176) Co-authored-by: Nan Jiang <[email protected]> * Update pr assignment config (Azure#16175) * [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035) * [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script * Update dataset, linked service and pipeline * Update release tag for october release * Correct type of result limit * Add arguments for SynapseSparkJobActivityTypeProperties Co-authored-by: Dongwei Wang <[email protected]> * fix (Azure#16164) Merging the change to have accurate Swagger * update swagger files * update readme.md * add missing json files * update custom-words.txt to address the spelling check * remove 201 define in ServerUpdate.json * remove blank line * address comments * address the description comment * update the swagger * remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Tianen <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: najian <[email protected]> Co-authored-by: Nan Jiang <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: Dongwei Wang <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: PingZhu2232 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Ping Zhu <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: Roslyn Lu <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: edwin-msft <[email protected]> Co-authored-by: Edwin Diaz <[email protected]> Co-authored-by: dochollidayxx <[email protected]> Co-authored-by: Adam Holliday <[email protected]> Co-authored-by: yifan-zhou922 <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: Parv Saxena <[email protected]> Co-authored-by: hvermis <[email protected]> Co-authored-by: xuepingd <[email protected]> Co-authored-by: laxmankumar12 <[email protected]> Co-authored-by: REDMOND\lakshv <[email protected]> Co-authored-by: He Huang <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: brpanask <[email protected]> Co-authored-by: rebecca337 <[email protected]> Co-authored-by: Rebecca Dupuis <[email protected]> Co-authored-by: xunsun-commits <[email protected]> Co-authored-by: Wan Yang <[email protected]> Co-authored-by: soma-ms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.