-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SRP] Introduce 2020-08-01-preview version. #10570
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
ed27235
to
d07a301
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
d07a301
to
d302db0
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
d302db0
to
2047ff1
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
2047ff1
to
28bb1ef
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
28bb1ef
to
824a269
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
353761f
to
f770b9a
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
f770b9a
to
821d4b3
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/deletedAccounts/{deletedAccountName}": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't represent the deletedaccounts as if they exist in a resource group. You won't be able to route this to the correct location and most of the time the resource group the storage account was originally in probably doesn't exist anymore. Please follow the keyVault design of using a locationbased subscription API to get individual accounts (this is also what is in your manifest PR btw). specification\keyvault\resource-manager\Microsoft.KeyVault\preview\2020-04-01-preview\keyvault.json
The resource IDs returned in the GET /deletedAccounts collection call should be the location based ID, not a resource group based ID as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chris! Will fix.
821d4b3
to
f694dfa
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
f694dfa
to
fea12fc
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
- tag: package-2016-05 | ||
- tag: package-2016-01 | ||
- tag: package-2015-06 | ||
- tag: package-2015-05-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leni-msft to review as this file is not need change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huizlAzure Please run npm run multiapi
to update this readme.azureresourceschema.md file. (may need sync your work branch with master first)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leni-msft I verified running npm run multiapi and it didn't changes any file locally.
[email protected] multiapi E:\Code\Swagger\James-Repo\azure-rest-api-specs
ts-node ./scripts/multiapi.ts
Why do you think this file need not change? I see all the api-versions are listed in this file and this new api-version needs to be added as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @priyapansrp, this file do need to be updated, by adding new schema-storage-{APIVersion}
tag, but not using the package-*
tags. I pushed the commit fd84668 to this PR. Let's see the automation - sdk (SDK Schema)
result.
Hi @blueww, are you aware of .Net failures? If you are fine, please let me know. |
The .net SDK failure seems caused by some auto rest issue, but not for the swagger
I have rerun the .net SDK test, and it pass now. |
Azure Pipelines successfully started running 1 pipeline(s). |
* [SRP] Introduce 2020-08-01-preview version. * Change versions in example files as well * Introduce list deletedAccounts API. * Fix default error message schema to conform to OData v4 * Address CR comments * Support GetDeletedAccount * prettier * Update readme.azureresourceschema.md Co-authored-by: Lei Ni <[email protected]>
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10653) [SRP] Introduce 2020-08-01-preview version. (Azure#10570) Update Readmes for Python for Automanage (Azure#10633) Incident entities (Azure#10648) Fix Billing Swagger (Azure#10276) Connected machine az cli (Azure#10640) [Azure Stack] Updates to Azs.AzureBridge.Admin spec (Azure#9035)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.