Add On Premise Sql Resource Details #10041
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,7 +169,8 @@ | |
| "description": "The platform where the assessed resource resides", | ||
| "enum": [ | ||
| "Azure", | ||
| "OnPremise", | ||
| "OnPremiseSql" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "source", | ||
|
|
@@ -182,6 +183,10 @@ | |
| { | ||
| "value": "OnPremise", | ||
| "description": "Resource in an on premise machine connected to Azure cloud" | ||
| }, | ||
| { | ||
| "value": "OnPremiseSql", | ||
| "description": "SQL Resource in an on premise machine connected to Azure cloud" | ||
| } | ||
| ] | ||
| } | ||
|
|
@@ -242,6 +247,30 @@ | |
| "machineName" | ||
| ] | ||
| }, | ||
| "OnPremiseSqlResourceDetails": { | ||
| "type": "object", | ||
| "description": "Details of the On Premise Sql resource that was assessed", | ||
| "x-ms-discriminator-value": "OnPremiseSql", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/OnPremiseResourceDetails" | ||
|
There was a problem hiding this comment. Make sure this inherits correctly, and doesn't just defaults to base type There was a problem hiding this comment. I implemented it this way after seeing similar examples, for example : The SDK that generated from the swagger - |
||
| } | ||
| ], | ||
| "properties": { | ||
| "serverName": { | ||
| "type": "string", | ||
| "description": "The Sql server name installed on the machine" | ||
| }, | ||
| "databaseName": { | ||
| "type": "string", | ||
| "description": "The Sql database name installed on the machine" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "serverName", | ||
| "databaseName" | ||
| ] | ||
| }, | ||
| "AzureResourceLinks": { | ||
| "description": "array of azure resource IDs", | ||
| "readOnly": true, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR appears to be modifying some definitions shared across security swaggers. Which API versions will this affect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft.Security/subassessments 2019-01-01-preview and 2020-01-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change would effectively alter the behavior of 2 API versions. As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md, this is not allowed. You should bump the API version and only allow the new enum values in that API version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My change doesn’t affect the API behavior – I didn’t change any of the current fields (not rename any field and not removed any field) I only added a new option for a new value that field can get, this field already exists.