Add On Premise Sql Resource Details #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jul 6, 2020
|
Can one of the admins verify this patch? |
|
Hi @chlahav , @leni-msft , |
majastrz
reviewed
Jul 7, 2020
| @@ -169,7 +169,8 @@ | |||
| "description": "The platform where the assessed resource resides", | |||
| "enum": [ | |||
| "Azure", | |||
| "OnPremise" | |||
| "OnPremise", | |||
| "OnPremiseSql" | |||
There was a problem hiding this comment.
OnPremiseSql [](start = 13, length = 12)
The PR appears to be modifying some definitions shared across security swaggers. Which API versions will this affect?
There was a problem hiding this comment.
Microsoft.Security/subassessments 2019-01-01-preview and 2020-01-01
There was a problem hiding this comment.
Your change would effectively alter the behavior of 2 API versions. As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md, this is not allowed. You should bump the API version and only allow the new enum values in that API version.
There was a problem hiding this comment.
My change doesn’t affect the API behavior – I didn’t change any of the current fields (not rename any field and not removed any field) I only added a new option for a new value that field can get, this field already exists.
Eitan-Lev
reviewed
Jul 8, 2020
| "x-ms-discriminator-value": "OnPremiseSql", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/OnPremiseResourceDetails" |
There was a problem hiding this comment.
Make sure this inherits correctly, and doesn't just defaults to base type
There was a problem hiding this comment.
I implemented it this way after seeing similar examples, for example :
Take a look at resource AllowlistCustomAlertRule that inherited from ListCustomAlertRule that inherited from CustomAlertRule at file:
The SDK that generated from the swagger -
https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/securitycenter/Microsoft.Azure.Management.SecurityCenter/src/Generated/Models/ListCustomAlertRule.cs
https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/securitycenter/Microsoft.Azure.Management.SecurityCenter/src/Generated/Models/AllowlistCustomAlertRule.cs
majastrz
added
the
ARMChangesRequested
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Changed the version type to stable
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
add new version to ruby.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 16, 2020
|
Signing off from ARM side (modelAsString: true is set to make it an extensible enum) |
ravbhatnagar
added
ARMSignedOff
PhoenixHe-NV
approved these changes
Jul 29, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Add On Premise Sql Resource Details * Create new API version * Remove OnPremiseSql for old version * Add changes to readme file * Add API Example * Add new ResourceDetails type for subassessment * Add examples Changed the version type to stable * Changed readme file * fixed object defintion probleam. add new version to ruby. * Removed the new version * removed files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add On Premise Sql Resource Details