[Synapse] Update notebook and spark job definition cmdlets to support folder path #16269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonner
reviewed
Oct 29, 2021
| @@ -540,5 +540,9 @@ public static class HelpMessages | |||
| public const string DefaultResultLimit = "The default resultLimit is 5000"; | |||
|
|
|||
| public const string SqlFilePath = "The SQL file path."; | |||
|
|
|||
| public const string SparkConfigurationFolderPath = "The folder that this Spark job definition is in. If not specified, this Spark job definition will appear at the root level."; | |||
There was a problem hiding this comment.
Add an example to describe how to specify multi-level folder path.
BethanyZhou
reviewed
Oct 29, 2021
src/Synapse/Synapse/ChangeLog.md
Outdated
| @@ -31,6 +31,7 @@ | |||
| - Added `Remove-AzSynapseSqlScript` cmdlet | |||
| - Added `Export-AzSynapseSqlScript` cmdlet | |||
| - Added `Set-AzSynapseSqlScript` cmdlet | |||
| * Updated `Set-AzSynapseNoteBook` and `Set-AzSynapseSparkJobDefinition` to support new parameter [-FolderPath] | |||
There was a problem hiding this comment.
Please move change message to the top of upcoming release section
-update change log -add example for specifying multi-level folder path -update FolderName to FolderPath as PowerShell Team suggested -update foldername description in help doc -resolve some comments in code review -update change log -add new parameter foldername
yanjungao718
force-pushed
the
synapse-add-foldername
branch
from
3bbbae6 to
b9daab3
Compare
8 tasks
BethanyZhou
approved these changes
Oct 29, 2021
BethanyZhou
added a commit
that referenced
this pull request
Oct 29, 2021
* Update ci config to add tools/GeneratedModuleList.txt to skip list (#16216) Co-authored-by: wyunchi-ms <[email protected]> * Fix an issue in checking if we need to prompt survey. (#16232) * Fix FirewallRuleName wildcard filtering in Get-AzSqlServerFirewallRule (#16237) * Add Wildcard helper * Fix wildcard filtering in Get-AzSqlServerFirewallRule * Update src/Sql/Sql/ChangeLog.md Co-authored-by: Beisi Zhou <[email protected]> * [Storage] Add example for move datalakegen2 item with Sas (#16256) * Update Invoke-AzVMRunCommand.md (#16000) * Update Invoke-AzVMRunCommand.md #15704 * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: Beisi Zhou <[email protected]> * Update notebook and spark job definition cmdlets to support folder path (#16269) -update change log -add example for specifying multi-level folder path -update FolderName to FolderPath as PowerShell Team suggested -update foldername description in help doc -resolve some comments in code review -update change log -add new parameter foldername Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: wyunchi-ms <[email protected]> Co-authored-by: kceiw <[email protected]> Co-authored-by: Reggie Gibson <[email protected]> Co-authored-by: Wei Wei <[email protected]> Co-authored-by: Micah McKittrick <[email protected]> Co-authored-by: YanjunGao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 'Set-AzSynapseNoteBook' and 'Set-AzSynapseSparkJobDefinition' cmdlet to support new parameter [-FolderPath], if this parameter is specified, the notebook/spark job definition will be placed in it.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added-https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1061