Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in checking if we need to prompt survey. #16232

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

kceiw
Copy link
Contributor

@kceiw kceiw commented Oct 26, 2021

Description

There is a bug in the previous check in that we always return true when checking if we need to show the survey. That was to make testing easier. It shouldn't be in production. The fix is to return false in that case.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Copy link
Contributor

@jjaguirre394 jjaguirre394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@BethanyZhou BethanyZhou merged commit 68872e7 into Azure:main Oct 27, 2021
BethanyZhou added a commit that referenced this pull request Oct 29, 2021
* Update ci config to add tools/GeneratedModuleList.txt to skip list (#16216)

Co-authored-by: wyunchi-ms <[email protected]>

* Fix an issue in checking if we need to prompt survey. (#16232)

* Fix FirewallRuleName wildcard filtering in Get-AzSqlServerFirewallRule (#16237)

* Add Wildcard helper

* Fix wildcard filtering in Get-AzSqlServerFirewallRule

* Update src/Sql/Sql/ChangeLog.md

Co-authored-by: Beisi Zhou <[email protected]>

* [Storage] Add example for move datalakegen2 item with Sas (#16256)

* Update Invoke-AzVMRunCommand.md (#16000)

* Update Invoke-AzVMRunCommand.md

#15704

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

* Update Invoke-AzVMRunCommand.md

Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>

* Update notebook and spark job definition cmdlets to support folder path (#16269)

-update change log

-add example for specifying multi-level folder path

-update FolderName to FolderPath as PowerShell Team suggested

-update foldername description in help doc

-resolve some comments in code review

-update change log

-add new parameter foldername

Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: wyunchi-ms <[email protected]>
Co-authored-by: kceiw <[email protected]>
Co-authored-by: Reggie Gibson <[email protected]>
Co-authored-by: Wei Wei <[email protected]>
Co-authored-by: Micah McKittrick <[email protected]>
Co-authored-by: YanjunGao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants