Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking changes warnings in preparation for October 27th milestone PR #12683

Merged
merged 4 commits into from
Aug 18, 2020

Conversation

skayani
Copy link
Contributor

@skayani skayani commented Aug 17, 2020

Description

This PR is to be submitted in advance of of this one to warn users of the upcoming parameter naming convention changes.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@skayani skayani requested a review from dramuy August 17, 2020 20:53
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skayani Please add the description of current change to ChangeLog.md

@msJinLei
Copy link
Contributor

@skayani We will add changelog for you since we want to freeze the code. Please remember to modify changelog next time.

@msJinLei msJinLei merged commit ef6a2ae into Azure:master Aug 18, 2020
@skayani
Copy link
Contributor Author

skayani commented Aug 18, 2020

Thanks @msJinLei , will keep in mind for next time. Just to be clear, the version won't change right?

@skayani skayani mentioned this pull request Oct 12, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants