-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed services cmdlet changes #12105
Conversation
Can one of the admins verify this patch? |
src/ManagedServices/ManagedServices/Commands/GetAzureRmManagedServicesAssignment.cs
Show resolved
Hide resolved
src/ManagedServices/ManagedServices/Commands/GetAzureRmManagedServicesDefinition.cs
Show resolved
Hide resolved
src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesAssignment.cs
Show resolved
Hide resolved
src/ManagedServices/ManagedServices/Commands/NewAzureRmManagedServicesDefinition.cs
Show resolved
Hide resolved
src/ManagedServices/ManagedServices/Commands/RemoveAzureRmManagedServcicesAssignment.cs
Show resolved
Hide resolved
src/ManagedServices/ManagedServices/Commands/RemoveAzureRmManagedServicesDefinition.cs
Show resolved
Hide resolved
close this PR now, you can reopen it if needed or you have any further questions. |
…and parameter bound issues calling through cmdlet execute
…to remove cmdlets
Please add breaking change notification to S176 |
@msJinLei Hi, just wanted to confirm that we don't have any other pending tasks prior to the October 27th milestone? We pushed out the warnings PR and have resolved the conflicts in the PR (i.e. removed the warnings in this PR). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
You have several breaking changes here. Please check breaking changes2020-10-09T06:42:26.7565143Z Using exceptions file D:\a\1\s\artifacts\StaticAnalysis\Exceptions\BreakingChangeIssues.csv 2020-10-09T06:42:27.3142894Z Processing complete for analyzer: Breaking Change Analyzer 2020-10-09T06:42:27.3704900Z D:\a\1\s\artifacts//StaticAnalysisResults\BreakingChangeIssues.csv Errors 2020-10-09T06:42:27.3707229Z "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" 2020-10-09T06:42:27.3709171Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Scope' for cmdlet 'Get-AzManagedServicesAssignment'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Scope'." 2020-10-09T06:42:27.3712110Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","2000","The cmdlet 'Get-AzManagedServicesAssignment' no longer supports the parameter 'Id' and no alias was found for the original parameter name.","Add the parameter 'Id' back to the cmdlet 'Get-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3745020Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","2000","The cmdlet 'Get-AzManagedServicesAssignment' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Get-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3747866Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","1050","The parameter set 'ById' for cmdlet 'Get-AzManagedServicesAssignment' has been removed.","Add parameter set 'ById' back to cmdlet 'Get-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3752540Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","1050","The parameter set 'ByResourceId' for cmdlet 'Get-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Get-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3756238Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesDefinition","Get-AzManagedServicesDefinition","0","3010","The property 'Name' of type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.PSRegistrationDefinitionProperties' has been removed.","Add the property 'Name' back to type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.PSRegistrationDefinitionProperties'." 2020-10-09T06:42:27.3759168Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesDefinition","Get-AzManagedServicesDefinition","0","2000","The cmdlet 'Get-AzManagedServicesDefinition' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Get-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3761804Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesDefinition","Get-AzManagedServicesDefinition","0","1050","The parameter set 'ByResourceId' for cmdlet 'Get-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Get-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3764583Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Scope' for cmdlet 'New-AzManagedServicesAssignment'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Scope'." 2020-10-09T06:42:27.3767071Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","2000","The cmdlet 'New-AzManagedServicesAssignment' no longer supports the parameter 'RegistrationDefinitionName' and no alias was found for the original parameter name.","Add the parameter 'RegistrationDefinitionName' back to the cmdlet 'New-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3770246Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","2000","The cmdlet 'New-AzManagedServicesAssignment' no longer supports the parameter 'RegistrationDefinitionResourceId' and no alias was found for the original parameter name.","Add the parameter 'RegistrationDefinitionResourceId' back to the cmdlet 'New-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3773020Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","1050","The parameter set 'Default' for cmdlet 'New-AzManagedServicesAssignment' has been removed.","Add parameter set 'Default' back to cmdlet 'New-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3775346Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","1050","The parameter set 'ByResourceId' for cmdlet 'New-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'New-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3777973Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","1050","The parameter set 'ByInputObject' for cmdlet 'New-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByInputObject' back to cmdlet 'New-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3780681Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Name' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Name'." 2020-10-09T06:42:27.3782734Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'ManagedByTenantId' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'ManagedByTenantId'." 2020-10-09T06:42:27.3784872Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'PrincipalId' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'PrincipalId'." 2020-10-09T06:42:27.3787024Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'RoleDefinitionId' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'RoleDefinitionId'." 2020-10-09T06:42:27.3789034Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Description' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Description'." 2020-10-09T06:42:27.3790982Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","1050","The parameter set 'Default' for cmdlet 'New-AzManagedServicesDefinition' has been removed.","Add parameter set 'Default' back to cmdlet 'New-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3792673Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","1050","The parameter set 'ByPlan' for cmdlet 'New-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByPlan' back to cmdlet 'New-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3794431Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Scope' for cmdlet 'Remove-AzManagedServicesAssignment'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Scope'." 2020-10-09T06:42:27.3796284Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","2000","The cmdlet 'Remove-AzManagedServicesAssignment' no longer supports the parameter 'Id' and no alias was found for the original parameter name.","Add the parameter 'Id' back to the cmdlet 'Remove-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3798276Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","2000","The cmdlet 'Remove-AzManagedServicesAssignment' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Remove-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3800191Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","1050","The parameter set 'Default' for cmdlet 'Remove-AzManagedServicesAssignment' has been removed.","Add parameter set 'Default' back to cmdlet 'Remove-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3801841Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","1050","The parameter set 'ByResourceId' for cmdlet 'Remove-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Remove-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3804469Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","2000","The cmdlet 'Remove-AzManagedServicesDefinition' no longer supports the parameter 'Id' and no alias was found for the original parameter name.","Add the parameter 'Id' back to the cmdlet 'Remove-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3806466Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","2000","The cmdlet 'Remove-AzManagedServicesDefinition' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Remove-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3808500Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","2000","The cmdlet 'Remove-AzManagedServicesDefinition' no longer supports the parameter 'AsJob' and no alias was found for the original parameter name.","Add the parameter 'AsJob' back to the cmdlet 'Remove-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3810308Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set 'Default' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set 'Default' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3811959Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set 'ByResourceId' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3813670Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set 'ByInputObject' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByInputObject' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3815527Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3816524Z 2020-10-09T06:42:27.3816702Z 2020-10-09T06:42:27.3817018Z D:\a\1\s\artifacts//StaticAnalysisResults\BreakingChangeIssues.csv: 2020-10-09T06:42:27.3817554Z "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" 2020-10-09T06:42:27.3818692Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Scope' for cmdlet 'Get-AzManagedServicesAssignment'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Scope'." 2020-10-09T06:42:27.3820492Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","2000","The cmdlet 'Get-AzManagedServicesAssignment' no longer supports the parameter 'Id' and no alias was found for the original parameter name.","Add the parameter 'Id' back to the cmdlet 'Get-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3822404Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","2000","The cmdlet 'Get-AzManagedServicesAssignment' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Get-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3824052Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","1050","The parameter set 'ById' for cmdlet 'Get-AzManagedServicesAssignment' has been removed.","Add parameter set 'ById' back to cmdlet 'Get-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3825522Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesAssignment","Get-AzManagedServicesAssignment","0","1050","The parameter set 'ByResourceId' for cmdlet 'Get-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Get-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3827203Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesDefinition","Get-AzManagedServicesDefinition","0","3010","The property 'Name' of type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.PSRegistrationDefinitionProperties' has been removed.","Add the property 'Name' back to type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.PSRegistrationDefinitionProperties'." 2020-10-09T06:42:27.3829070Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesDefinition","Get-AzManagedServicesDefinition","0","2000","The cmdlet 'Get-AzManagedServicesDefinition' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Get-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3831332Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.GetAzureRmManagedServicesDefinition","Get-AzManagedServicesDefinition","0","1050","The parameter set 'ByResourceId' for cmdlet 'Get-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Get-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3833001Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Scope' for cmdlet 'New-AzManagedServicesAssignment'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Scope'." 2020-10-09T06:42:27.3834760Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","2000","The cmdlet 'New-AzManagedServicesAssignment' no longer supports the parameter 'RegistrationDefinitionName' and no alias was found for the original parameter name.","Add the parameter 'RegistrationDefinitionName' back to the cmdlet 'New-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3851351Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","2000","The cmdlet 'New-AzManagedServicesAssignment' no longer supports the parameter 'RegistrationDefinitionResourceId' and no alias was found for the original parameter name.","Add the parameter 'RegistrationDefinitionResourceId' back to the cmdlet 'New-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3856923Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","1050","The parameter set 'Default' for cmdlet 'New-AzManagedServicesAssignment' has been removed.","Add parameter set 'Default' back to cmdlet 'New-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3860376Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","1050","The parameter set 'ByResourceId' for cmdlet 'New-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'New-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3863957Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesAssignment","New-AzManagedServicesAssignment","0","1050","The parameter set 'ByInputObject' for cmdlet 'New-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByInputObject' back to cmdlet 'New-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3874584Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Name' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Name'." 2020-10-09T06:42:27.3877103Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'ManagedByTenantId' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'ManagedByTenantId'." 2020-10-09T06:42:27.3878945Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'PrincipalId' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'PrincipalId'." 2020-10-09T06:42:27.3881089Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'RoleDefinitionId' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'RoleDefinitionId'." 2020-10-09T06:42:27.3883158Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Description' for cmdlet 'New-AzManagedServicesDefinition'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Description'." 2020-10-09T06:42:27.3885148Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","1050","The parameter set 'Default' for cmdlet 'New-AzManagedServicesDefinition' has been removed.","Add parameter set 'Default' back to cmdlet 'New-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3887333Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.NewAzureRmManagedServicesDefinition","New-AzManagedServicesDefinition","0","1050","The parameter set 'ByPlan' for cmdlet 'New-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByPlan' back to cmdlet 'New-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3889047Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Scope' for cmdlet 'Remove-AzManagedServicesAssignment'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Scope'." 2020-10-09T06:42:27.3891104Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","2000","The cmdlet 'Remove-AzManagedServicesAssignment' no longer supports the parameter 'Id' and no alias was found for the original parameter name.","Add the parameter 'Id' back to the cmdlet 'Remove-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3893413Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","2000","The cmdlet 'Remove-AzManagedServicesAssignment' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Remove-AzManagedServicesAssignment', or add an alias to the original parameter name." 2020-10-09T06:42:27.3895437Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","1050","The parameter set 'Default' for cmdlet 'Remove-AzManagedServicesAssignment' has been removed.","Add parameter set 'Default' back to cmdlet 'Remove-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3897276Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServcicesAssignment","Remove-AzManagedServicesAssignment","0","1050","The parameter set 'ByResourceId' for cmdlet 'Remove-AzManagedServicesAssignment' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Remove-AzManagedServicesAssignment'." 2020-10-09T06:42:27.3899302Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","2000","The cmdlet 'Remove-AzManagedServicesDefinition' no longer supports the parameter 'Id' and no alias was found for the original parameter name.","Add the parameter 'Id' back to the cmdlet 'Remove-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3901313Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","2000","The cmdlet 'Remove-AzManagedServicesDefinition' no longer supports the parameter 'ResourceId' and no alias was found for the original parameter name.","Add the parameter 'ResourceId' back to the cmdlet 'Remove-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3904587Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","2000","The cmdlet 'Remove-AzManagedServicesDefinition' no longer supports the parameter 'AsJob' and no alias was found for the original parameter name.","Add the parameter 'AsJob' back to the cmdlet 'Remove-AzManagedServicesDefinition', or add an alias to the original parameter name." 2020-10-09T06:42:27.3906712Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set 'Default' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set 'Default' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3908669Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set 'ByResourceId' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByResourceId' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3910660Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set 'ByInputObject' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set 'ByInputObject' back to cmdlet 'Remove-AzManagedServicesDefinition'." 2020-10-09T06:42:27.3912958Z "Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.dll","Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Commands.RemoveAzureRmManagedServicesDefinition","Remove-AzManagedServicesDefinition","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Remove-AzManagedServicesDefinition' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Remove-AzManagedServicesDefinition'." |
@msJinLei We are aware of those breaking changes and they are intentional to improve our cmdlets (during our cmdlet review we were instructed to use the Oct. 27th milestone as that is for breaking changes). I have two questions: 1) Since this PR is set for the Oct. 27th breaking changes milestone, can you tell us if we are good to be merged for Oct 27th or do we need to do anything else? 2) What will the new Managed services cmdlet version number be after these changes are committed? |
@skayani I find more cmdlets of breaking changes in the PR than what you refer in #13027. Can you check all these cmdlets's change? Breaking change cmdlets in this PR
Confirm and then suppress the breaking warnings.
Will be 2.0.0 in 10.27 release |
@msJinLei That PR you linked is just the update to the existing warnings from the original PR. The original PR for the warnings is #12683 where we cover the warnings for the remaining user-facing cmdlet breaking changes. I can confirm but how do we suppress the warnings? The only documentation I see is for suppressing warnings within Powershell. |
@skayan |
@msJinLei Thank you for the link. I have suppressed the warnings and locally static analysis succeeds now, though I see static analysis is failing in the above checks. Is this normal? If so, are we good to merge? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@skayani Please rename ./StaticAnalysis/Exceptions/Az.ManagedServices/BreakingChangesIssues.csv to ./StaticAnalysis/Exceptions/Az.ManagedServices/BreakingChangeIssues.csv and try again. |
@msJinLei Sorry about that, I was getting static analysis error locally and fixed it locally but it seems I did not push the name change. Looks like we're good now after the name change commit? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Various parameter name changes were made to better reflect the API. Also resource ids were removed due to being unneeded. Although this PR was created, I realize, according to the open issue here, that the changes will be part of the October milestone.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added