-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appgw: validate cert only if certificateFile is specified in set ssl cert command #10991
Conversation
...Network/ApplicationGateway/SslCertificate/SetAzureApplicationGatewaySslCertificateCommand.cs
Show resolved
Hide resolved
Hi @akshaysngupta , Could you please also update the changelog.md? |
6ea9eb6
to
39b19ea
Compare
13d9496
to
499b4d3
Compare
c049166
to
60689b5
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @akshaysngupta, changes from |
@akshaysngupta please re-create PR using |
Any idea what release this will be in? |
Description
This PR majorly is to fix #9488
But as a part of this PR, we add a test in Network project using a KeyVault dataplane cmdlets. To make these cmdlets work, I am have made additional changes to Network Test Runner and KeyVault project. These changes help to mock the keyvault client in the Network project.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added