Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appgw: validate cert only if certificateFile is specified in set ssl cert command #10991

Closed

Conversation

akshaysngupta
Copy link
Member

@akshaysngupta akshaysngupta commented Jan 29, 2020

Description

This PR majorly is to fix #9488

But as a part of this PR, we add a test in Network project using a KeyVault dataplane cmdlets. To make these cmdlets work, I am have made additional changes to Network Test Runner and KeyVault project. These changes help to mock the keyvault client in the Network project.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@akshaysngupta akshaysngupta changed the title appgw: add check for certificate file in set ssl cert command appgw: validate cert only if certificateFile is specified in set ssl cert command Jan 29, 2020
@VeryEarly
Copy link
Contributor

Hi @akshaysngupta ,

Could you please also update the changelog.md?

@akshaysngupta akshaysngupta changed the base branch from master to network-march March 30, 2020 18:46
@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@anton-evseev
Copy link
Contributor

Hi @akshaysngupta, changes from network-march were merged into master. Please retarget your PR to master as well to make the release. Please also note that master was rebased due to credentials leaking into it so it's basically incompatible with network-march. My suggestion is to create a new branch from master and copy your changes there.

@anton-evseev
Copy link
Contributor

@akshaysngupta please re-create PR using master as base

@RustyF
Copy link

RustyF commented Jun 29, 2020

Any idea what release this will be in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-AzApplicationGatewaySSLCertificate KeyVaultSecretId wrongly requires fileName
6 participants