Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add incorrect test case to .gitignore
- Loading branch information
1 parent
5dcd3c7
commit 17f811c
17f811cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dingmeng-xue This commit has completely re-written history for the repository. Was that at all intentional?
17f811cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnduhart , Due to an incorrect commit recently, we had scanned all commits and force pushed to all branches and tags. To avoid people add it again, this change is asked by our safeguards team.
I'm not expert on GitHub. Could you explain your concern if any?
17f811cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14b2975
Rewriting all history doesn't remove the commit or files from existence, it just makes it more difficult for people to contribute because their git history is broken. PRs showing up with 10K+ commits isn't right.
17f811cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm suffering this problem too. You know what, I was asked to do change according to this instruction https://help.github.com/en/github/authenticating-to-github/removing-sensitive-data-from-a-repository. before this commit, I force push change to all branches and tags. It's the first time that our repo was asked to do this job. We didn't know the real impact. Given it happened, is there way to mitigate this problem now? In addition, introduction told me incorrect commit should be removed but seems not. I will ask our security team. Is there any suggestion too?
17f811cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure PowerShell is contributed by many service teams. We cannot ask them to drop their change and rebase seems big effort too. I guess it is the reason their pull request still contains issue commit after local merge. We have disabled "Allow merge commits" option on repo. So the PR will be squashed during merge. The issue will disappear after while.