Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVD Alerts v2.2.0 update - docs, sub opt for LAW & AzFiles, bug fixes #315 and #457 #466

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

JCoreMS
Copy link
Contributor

@JCoreMS JCoreMS commented Dec 18, 2024

Overview/Summary

Update to v2.2.0 includes documentation updates and bug fixes for issues #289, #315 and #457 as well as a feature update to allow alternate subscription selection for Log Analytics and Azure Files resources.

This PR fixes/adds/changes/removes

  1. Issue [Question/Feedback]: Handling multiple subscriptions in AVD pattern runbook #289 runbook for storage updated to handle multiple subscriptions. Host Pools runbook unchanged as it is intended to be configured for Host Pools on a per subscription basis but with storage resources across others being a common scenario.
  2. Issue [Question/Feedback]: How to enable AVD Pattern for multiple Host Pools and different Actions Groups? #315 resolved by appending the Action Group name with a random unique 13 characters to allow for subsequent deployments to not fail due to an existing Action Group with the same name.
  3. Issue AVD pattern: deployment wizard bug with the "VM in Separate Resource Group" checked #457 resolved by ensuring UI Definition does not hide the AVD Resources Resource Group Selection when checking the option for VMs in separate Resource Groups.
  4. Added Warning text on first deployment page outlining the prerequisite permissions required.
  5. Additional Subscription selector for Log Analytics Workspace and Azure Files selection and created titled section for Log Analytics in UI

Breaking Changes

  1. N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@judyer28 judyer28 self-requested a review December 18, 2024 19:01
Copy link
Contributor

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @JCoreMS!

@judyer28 judyer28 merged commit 1609c07 into Azure:main Dec 18, 2024
2 of 4 checks passed
@JCoreMS JCoreMS deleted the JCore-AVD_Alerts_Fix_Dec2024 branch December 18, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants