Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK files to setup.py for EventGrid #4221

Merged
merged 7 commits into from
Aug 15, 2017
Merged

Add SDK files to setup.py for EventGrid #4221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2e92c7
First version of Azure EventGrid CLI
kalyanaj Aug 10, 2017
ee406c9
Added azure_bdist_wheel.py, setup.cfg, and manifest.in files.
kalyanaj Aug 10, 2017
dfd1b9d
Added license headers in 34 files, updated an example in the help fil…
kalyanaj Aug 10, 2017
5bd1b8f
Aliased --is-subject-case-sensitive to --subject-case-sensitive.
kalyanaj Aug 10, 2017
42a9712
Merge remote-tracking branch 'upstream/master'
kalyanaj Aug 15, 2017
bf95f09
Add SDK, models and operations to setup.py
kalyanaj Aug 15, 2017
a4653bd
Updated history to account for this change.
kalyanaj Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/command_modules/azure-cli-eventgrid/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release History
===============

unreleased
++++++++++++++++++

* Added SDK dependencies.

0.1.1 (2017-08-11)
++++++++++++++++++

Expand Down
5 changes: 4 additions & 1 deletion src/command_modules/azure-cli-eventgrid/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@
'azure',
'azure.cli',
'azure.cli.command_modules',
'azure.cli.command_modules.eventgrid'
'azure.cli.command_modules.eventgrid',
'azure.cli.command_modules.eventgrid.sdk',
'azure.cli.command_modules.eventgrid.sdk.models',
'azure.cli.command_modules.eventgrid.sdk.operations'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekbekoe out of curiosity, why didn't the CI catch this? Doesn't it verify each command package can be installed successfully?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes so it was installed successfully.
Since the imports don't happen until runtime, it didn't catch it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... if the module installation step ran "az eventgrid -h" instead of "az -h" would that have triggered the imports? If so, perhaps we should beef up our CI script to do that.

],
install_requires=DEPENDENCIES,
cmdclass=cmdclass
Expand Down