Add SDK files to setup.py for EventGrid #4221
Conversation
…e to include additional info.
# Conflicts: # src/command_modules/azure-cli-eventgrid/HISTORY.rst # src/command_modules/azure-cli-eventgrid/setup.py
|
@kalyanaj, |
Codecov Report
@@ Coverage Diff @@
## master #4221 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 475 475
Lines 29603 29603
Branches 4539 4539
=======================================
Hits 20749 20749
- Misses 7405 7409 +4
+ Partials 1449 1445 -4
Continue to review full report at Codecov.
|
| 'azure.cli.command_modules.eventgrid', | ||
| 'azure.cli.command_modules.eventgrid.sdk', | ||
| 'azure.cli.command_modules.eventgrid.sdk.models', | ||
| 'azure.cli.command_modules.eventgrid.sdk.operations' |
There was a problem hiding this comment.
@derekbekoe out of curiosity, why didn't the CI catch this? Doesn't it verify each command package can be installed successfully?
There was a problem hiding this comment.
Yes so it was installed successfully.
Since the imports don't happen until runtime, it didn't catch it.
There was a problem hiding this comment.
Hmm... if the module installation step ran "az eventgrid -h" instead of "az -h" would that have triggered the imports? If so, perhaps we should beef up our CI script to do that.
| 'azure.cli.command_modules.eventgrid', | ||
| 'azure.cli.command_modules.eventgrid.sdk', | ||
| 'azure.cli.command_modules.eventgrid.sdk.models', | ||
| 'azure.cli.command_modules.eventgrid.sdk.operations' |
There was a problem hiding this comment.
Yes so it was installed successfully.
Since the imports don't happen until runtime, it didn't catch it.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)