Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fx maintenanceconfiguration option name for error msg #5799

Merged
merged 1 commit into from
Jan 28, 2023
Merged

[AKS] Fx maintenanceconfiguration option name for error msg #5799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

0.5.128
+++++++
* Fix option name `--duration` for command group `az aks maintenanceconfiguration`

0.5.127
+++++++
* Add `--node-os-upgrade-channel <node os upgrade channel>` option for specifying the manner in which the OS on your nodes is updated in `aks create` and `aks update`
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/azext_aks_preview/maintenanceconfiguration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def constructMaintenanceWindow(cmd, raw_parameters):
if start_time is None:
raise RequiredArgumentMissingError('Please specify --start-time for maintenance window.')
if duration_hours is None:
raise RequiredArgumentMissingError('Please specify --duration-hours for maintenance window.')
raise RequiredArgumentMissingError('Please specify --duration for maintenance window.')

MaintenanceWindow = cmd.get_models('MaintenanceWindow', resource_type=CUSTOM_MGMT_AKS_PREVIEW, operation_group='maintenance_configurations')
maintenanceWindow = MaintenanceWindow(
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/azext_aks_preview/tests/latest/test_maintenanceconfiguration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def test_add_dedicated_schedule_with_missing_options(self):
"start_time": "00:00",
}

err = ("Please specify --duration-hours for maintenance window.")
err = ("Please specify --duration for maintenance window.")
with self.assertRaises(RequiredArgumentMissingError) as cm:
mc.aks_maintenanceconfiguration_update_internal(cmd, None, raw_parameters)
self.assertEqual(str(cm.exception), err)
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import setup, find_packages

VERSION = "0.5.127"
VERSION = "0.5.128"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down