Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fx maintenanceconfiguration option name for error msg #5799

Merged
merged 1 commit into from
Jan 28, 2023
Merged

[AKS] Fx maintenanceconfiguration option name for error msg #5799

merged 1 commit into from
Jan 28, 2023

Conversation

wenxuan0923
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks maintenanceconfiguration add and az aks maintenanceconfiguration update.
Fix error message for validation error - should be '--duration' instead of '--duration-hours'

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and yanzhudd January 24, 2023 01:38
@ghost ghost assigned zhoxing-ms Jan 24, 2023
@ghost ghost added this to the Jan 2023 (2023-02-07) milestone Jan 24, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Jan 24, 2023
@ghost ghost requested a review from yonzhan January 24, 2023 01:38
@ghost ghost added the AKS label Jan 24, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 24, 2023

AKS

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit ebc11c6 into Azure:main Jan 28, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=28600&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants