-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} add support for updating kube-proxy configuration #5545
{AKS} add support for updating kube-proxy configuration #5545
Conversation
AKS |
4fc6461
to
938a8b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, queued a pipeline to validate newly added tests.
@FumingZhang may need to rerun pipeline after |
@mattstam Could you please resolve the conflict? |
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
f54b8c4
to
67b0c9e
Compare
Queued a new pipeline to verify these 2 cases
All passed. Please commit the new recording files, may find them from pipeline artifact. |
Support updating kube-proxy configuration with 'az aks update --kube-proxy-config file.json'
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.