Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} add support for updating kube-proxy configuration #5545

Merged
merged 6 commits into from
Nov 29, 2022

Conversation

mattstam
Copy link
Contributor

Support updating kube-proxy configuration with 'az aks update --kube-proxy-config file.json'


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 November 14, 2022 22:40
@ghost ghost assigned zhoxing-ms Nov 14, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 14, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 14, 2022
@ghost ghost requested a review from yonzhan November 14, 2022 22:40
@ghost ghost added the AKS label Nov 14, 2022
@mattstam mattstam changed the title Support updating kube-proxy configuration with 'az aks update --kube-proxy-config file.json' {AKS} add support for updating kube-proxy configuration Nov 14, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 15, 2022

AKS

@mattstam mattstam force-pushed the mattstam/kubeproxyconfig-update branch from 4fc6461 to 938a8b3 Compare November 16, 2022 08:17
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, queued a pipeline to validate newly added tests.

@mattstam
Copy link
Contributor Author

@FumingZhang may need to rerun pipeline after @live_only is now included.

@zhoxing-ms
Copy link
Contributor

@mattstam Could you please resolve the conflict?

@mattstam mattstam force-pushed the mattstam/kubeproxyconfig-update branch from f54b8c4 to 67b0c9e Compare November 28, 2022 19:30
@FumingZhang
Copy link
Member

Queued a new pipeline to verify these 2 cases

  • test_aks_create_with_kube_proxy_config
  • test_aks_update_with_kube_proxy_config

All passed.

Please commit the new recording files, may find them from pipeline artifact.

image

@zhoxing-ms zhoxing-ms merged commit bae75f7 into Azure:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants