Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview flag --kube-proxy-config unrecognized on az aks update #5551

Closed
mateuszdrab opened this issue Nov 15, 2022 · 11 comments
Closed

preview flag --kube-proxy-config unrecognized on az aks update #5551

mateuszdrab opened this issue Nov 15, 2022 · 11 comments
Assignees
Labels
AKS Auto-Assign Auto assign by bot CXP Attention This issue is handled by CXP team. issue-addressed This issue is addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@mateuszdrab
Copy link

mateuszdrab commented Nov 15, 2022

  • If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Related command

az aks update -n=clustername -g=clustergroup --kube-proxy-config=proxy.json

Extension name (the extension in question)

aks-preview

Description of issue (in as much detail as possible)

unrecognized arguments: --kube-proxy-config

Customer raised a case asking for support on the in-preview IPVS feature in AKS documented here

I've realized that the article mentions that the command az aks update can be used with the new --kube-proxy-config flag to reconfigure and existing cluster; however, the flag is not recognized and upon inspecting the source code of the addon, I can see that indeed the flag is not defined for the aks_update command in the file https://github.com/Azure/azure-cli-extensions/blob/main/src/aks-preview/azext_aks_preview/custom.py and is only present for 'az aks create'

Can this issue be addressed?

This issue was reproduced on az cli version:
{ "azure-cli": "2.42.0", "azure-cli-core": "2.42.0", "azure-cli-telemetry": "1.0.8", "extensions": { "aks-preview": "0.5.115", "connectedk8s": "1.2.7", "interactive": "0.4.5" } }


@ghost ghost added AKS CXP Attention This issue is handled by CXP team. Auto-Assign Auto assign by bot labels Nov 15, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 15, 2022

route to CXP team

@RakeshMohanMSFT RakeshMohanMSFT self-assigned this Nov 16, 2022
@RakeshMohanMSFT
Copy link
Contributor

@mateuszdrab Thank you for reaching out to us, we are looking into it.

@RakeshMohanMSFT RakeshMohanMSFT added the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Nov 16, 2022
@RakeshMohanMSFT
Copy link
Contributor

RakeshMohanMSFT commented Nov 18, 2022

@mateuszdrab I believe its possible that the proxy settings are allowed only during cluster creation as mentioned here, Though its for http-proxy, should be applicable to kube-config as well. I will check further.

The following scenarios are not supported:
Updating proxy settings post cluster creation

@RakeshMohanMSFT RakeshMohanMSFT added the issue-addressed This issue is addressed and ready to close. label Nov 18, 2022
@ghost
Copy link

ghost commented Nov 18, 2022

Hi @mateuszdrab. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@mateuszdrab
Copy link
Author

Hi @RakeshMohanMSFT

The documentation explicitly states that it is possible for existing clusters here

Perhaps, the documentation needs to be corrected to explicitly state that it is not.

@mateuszdrab
Copy link
Author

/unresolve

@ghost ghost added needs-team-attention This issue needs attention from Azure service team or SDK team and removed issue-addressed This issue is addressed and ready to close. labels Nov 18, 2022
@mateuszdrab
Copy link
Author

I've been able to enable the feature on my cluster using a direct API PUT request, so the above is definitely possible.

Can we involve someone from the right team to look into this?

@FumingZhang
Copy link
Member

PR #5545 will add this option.

@RakeshMohanMSFT
Copy link
Contributor

Thank you @FumingZhang

@RakeshMohanMSFT RakeshMohanMSFT added issue-addressed This issue is addressed and ready to close. and removed needs-team-attention This issue needs attention from Azure service team or SDK team labels Nov 24, 2022
@ghost
Copy link

ghost commented Nov 24, 2022

Hi @mateuszdrab. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@mateuszdrab
Copy link
Author

PR #5545 will add this option.

Thanks for the update @FumingZhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot CXP Attention This issue is handled by CXP team. issue-addressed This issue is addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

4 participants