Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Module Proposal]: avm/ptn/azd/container-apps-stack #1225

Closed
2 tasks done
Menghua1 opened this issue Jul 24, 2024 · 8 comments · Fixed by Azure/bicep-registry-modules#3158
Closed
2 tasks done

[Module Proposal]: avm/ptn/azd/container-apps-stack #1225

Menghua1 opened this issue Jul 24, 2024 · 8 comments · Fixed by Azure/bicep-registry-modules#3158
Assignees
@jongio
Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@Menghua1
Copy link
Member

Menghua1 commented Jul 24, 2024 •
edited by matebarabas
Loading

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/azd/container-apps-stack

Module Details

Please add a Pattern Module named avm/ptn/azd/container-apps-stack, this module will create the following two resources:

  1. Container App Environment.
  2. Azure Container Registry (ACR).

For details, please refer to azd:
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/host/container-apps.bicep

CC: @jongio

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

jongio

(Optional) Secondary Module Owner's GitHub Username (handle)

No response
@Menghua1 Menghua1 added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jul 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Jul 24, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Pattern Module 📦 This is a pattern module labels Aug 2, 2024
@matebarabas
Copy link
Contributor

@Menghua1, thank you for proposing this module and thank you for your patience on triaging it! Many of us on the AVM core team have been OOF in the last couple of weeks, but we're back now! 😊

As this is categorized as a pattern module, its approval will require a more thorough assessment. We'll reach out to @jongio internally for more context and details as this proposal may require some adjustments to fit AVM's pattern definition and intent. The AVM core team will get back to you soon. Thank you for your patience!

@matebarabas matebarabas added the AZD 🧑‍💻 These modules are requested/used by the AZD team. label Aug 7, 2024
@Menghua1 Menghua1 changed the title [Module Proposal]: avm/ptn/app/container-apps [Module Proposal]: avm/ptn/azd/container-apps Aug 22, 2024
@matebarabas
Copy link
Contributor

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Status: No Recent Activity 💤 When an issue/PR has not been modified for X amount of days labels Aug 22, 2024
@matebarabas matebarabas removed the Status: No Recent Activity 💤 When an issue/PR has not been modified for X amount of days label Aug 27, 2024
@jongio
Copy link
Member

jongio commented Aug 28, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Aug 28, 2024
@matebarabas
Copy link
Contributor

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Aug 28, 2024
@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Needs: Triage 🔍 Maintainers need to triage still Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Aug 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Aug 28, 2024
@NanaXiong00 NanaXiong00 mentioned this issue Sep 3, 2024
Merged
11 tasks
@github-project-automation github-project-automation bot moved this from Proposed to Done in AVM - Module Triage Sep 4, 2024
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.
  • NOTE: the MAR manifest file is not yet updated with a record for this module. Until then, this module cannot be published.

Thank you for your work @NanaXiong00!

CC: @jongio

@matebarabas matebarabas reopened this Sep 4, 2024
jianingwang123 pushed a commit to jianingwang123/bicep-registry-modules that referenced this issue Sep 12, 2024
@NanaXiong00 @jianingwang123
feat: Add new ptn modules azd/container-apps (Azure#3158)
fcd3988 
## Description
Fixes Azure/Azure-Verified-Modules#1225
<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.azd.container-apps](https://github.com/NanaXiong00/bicep-registry-modules/actions/workflows/avm.ptn.azd.container-apps.yml/badge.svg?branch=fix%2F1225)](https://github.com/NanaXiong00/bicep-registry-modules/actions/workflows/avm.ptn.azd.container-apps.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@jongio for notification.
@jerryshia jerryshia mentioned this issue Sep 12, 2024
Merged
11 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Sep 25, 2024
@matebarabas matebarabas changed the title [Module Proposal]: avm/ptn/azd/container-apps [Module Proposal]: avm/ptn/azd/container-apps-stack Oct 7, 2024
@matebarabas
Copy link
Contributor

As agreed here, this module has been renamed to avm/ptn/azd/container-apps-stack (formerly, it was avm/ptn/azd/container-apps).

@Menghua1
Copy link
Member Author

This issue has been fixed by PR3158 . I will close this issue.

@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.
  • Issue template file updated.

Thank you for your work @NanaXiong00! I'm closing this issue now.

@matebarabas matebarabas added Status: Module Available 🟢 The module is published and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongio jongio

Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
AVM - Module Triage
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add new ptn modules azd/container-apps NanaXiong00/bicep-registry-modules
3 participants
@jongio @matebarabas @Menghua1