This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
Removing ACR credentials from variables #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc/ @hepsi204 |
@allantargino this approach is great! Getting the credentials at runtime reduces a lot the complexity of managing and configuring Key Vault. LGTM 👍 |
fedeoliv
previously approved these changes
Sep 4, 2020
I have to say, this approach is really great and much cleaner than maintaining a key vault. Nice work. 🙂 |
Thanks @fernandoBRS! |
fedeoliv
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #33 introduced Azure Key Vault and Service Connections as a way to remove secrets from group variables in AzDO. This heavily increases security - but the setup also becomes more complicated, given the additional infrastructure requirements that Key Vault introduces. The service connection already all the information we needed to store the service principal credentials, while we were mainly using Key Vault to store ACR credentials.
Main changes:
data.azurerm_container_registry
provider to get credentials at runtime - allowing us to remove Key Vault.Breaking/variables changes:
TF_VAR_JMETER_IMAGE_REGISTRY_NAME
toTF_VAR_JMETER_ACR_NAME
TF_VAR_SERVICE_CONNECTION_NAME
toAZURE_SERVICE_CONNECTION_NAME
AZURE_SUBSCRIPTION_ID
TF_VAR_JMETER_ACR_RESOURCE_GROUP_NAME
TF_VAR_JMETER_IMAGE_REGISTRY_USERNAME
TF_VAR_JMETER_IMAGE_REGISTRY_PASSWORD
Other changes:
azurerm
provider (fix Upgrade azurerm provider version to 2.26.0 #44)