panic: not a collection type (regression between 13.1 and 13.0) #26011

michsco · 2020-08-26T22:23:08Z

Terraform Version

Terraform v0.13.1
+ provider registry.terraform.io/hashicorp/azurerm v2.24.0

Terraform Configuration Files

terraform {
  backend "azurerm" {}
}
provider "azurerm" {
  version = "~>2"
  features {}
  subscription_id = var.subscription_id
}
data "azurerm_client_config" "current" {}
data "terraform_remote_state" "geography" {
  for_each = var.geos
  backend = "azurerm"
  config = {
    resource_group_name = var.backend_state.resource_group_name
    storage_account_name = var.backend_state.account_name
    container_name = var.backend_state.container_name
    key = "infra-setup-${each.value}.tfstate"
  }
}
data "terraform_remote_state" "locust" {
  count = var.locust_supported ? 1 : 0
  backend = "azurerm"
  config = {
    resource_group_name = var.backend_state.resource_group_name
    storage_account_name = var.backend_state.account_name
    container_name = var.backend_state.container_name
    key = "infra-locust.tfstate"
  }
}
locals {
  app_gateway_object_ids = flatten(values({
    for item in flatten([
      for geo in var.geos : [
        for object_id in values(data.terraform_remote_state.geography[geo].outputs.app_gateway_msi_objectids) : {
          key = "${geo}_${object_id}"
          policy = {
            object_id = object_id
            key_permissions = [ ]
            secret_permissions = [ "get" ]
            certificate_permissions = [ ]
          }
        }
      ]
    ]) : item.key => item.policy
  }))
  locust_app_gateway_policies = flatten(values({
    for item in flatten([
      for num in range(var.locust_supported ? 1 : 0) :[
        for object_id in values(data.terraform_remote_state.locust[num].outputs.app_gateway_msi_objectids) : {
          key = "${num}_${object_id}"
          policy = {
            object_id = object_id
            key_permissions = [ ]
            secret_permissions = [ "get" ]
            certificate_permissions = [ ]
          }
        }
      ]
    ]) : item.key => item.policy
  }))
}
resource "azurerm_resource_group" "rg" {
  name = var.resource_group_name
  location = "westus2"
}
resource "azurerm_user_assigned_identity" "msi" {
  resource_group_name = azurerm_resource_group.rg.name
  location = azurerm_resource_group.rg.location
  name = var.msi_name
}
resource "azurerm_role_assignment" "managed_identity_operator" {
  scope = azurerm_user_assigned_identity.msi.id
  role_definition_name = "Managed Identity Operator"
  principal_id = var.cluster_service_principal_object_id
}
module "keyvault" {
  source = "../modules/keyvault"
  resource_group_name = azurerm_resource_group.rg.name
  account_name = var.key_vault_name
  location = azurerm_resource_group.rg.location
  tenant_id = data.azurerm_client_config.current.tenant_id
  enabled_for_deployment = true
  enabled_for_template_deployment = true
  policies = concat(
    var.policies,
    [
      {
        object_id = azurerm_user_assigned_identity.msi.principal_id
        key_permissions = [ ]
        secret_permissions = [ "get", "list" ]
        certificate_permissions = [ ]
      }
    ],
    flatten(local.app_gateway_object_ids),
    flatten(local.locust_app_gateway_policies))
}
output "key_vault_id" {
  value = module.keyvault.id
}
output "key_vault_uri" {
  value = module.keyvault.vault_uri
}
output "service_msi" {
  value = {
    resource_id = azurerm_user_assigned_identity.msi.id
    client_id = azurerm_user_assigned_identity.msi.client_id
    msi_name = var.msi_name
  }
}

Debug Output

2020/08/26 14:25:52 [TRACE] Executing graph transform *terraform.OrphanResourceInstanceCountTransformer
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalSequence
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalGetProvider
2020/08/26 14:25:52 [TRACE] Completed graph transform *terraform.OrphanResourceInstanceCountTransformer (no changes)
2020/08/26 14:25:52 [TRACE] Executing graph transform *terraform.AttachStateTransformer
2020/08/26 14:25:52 [TRACE] Completed graph transform *terraform.AttachStateTransformer (no changes)
2020/08/26 14:25:52 [TRACE] Executing graph transform *terraform.TargetsTransformer
2020/08/26 14:25:52 [TRACE] Completed graph transform *terraform.TargetsTransformer (no changes)
2020/08/26 14:25:52 [TRACE] Executing graph transform *terraform.ReferenceTransformer
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalReadState
2020/08/26 14:25:52 [TRACE] EvalReadState: reading state for azurerm_resource_group.rg
2020/08/26 14:25:52 [DEBUG] ReferenceTransformer: "data.azurerm_client_config.current" references: []
2020/08/26 14:25:52 [TRACE] Completed graph transform *terraform.ReferenceTransformer (no changes)
2020/08/26 14:25:52 [TRACE] Executing graph transform *terraform.RootTransformer
2020/08/26 14:25:52 [TRACE] Completed graph transform *terraform.RootTransformer (no changes)
2020/08/26 14:25:52 [TRACE] vertex "data.azurerm_client_config.current": entering dynamic subgraph
2020/08/26 14:25:52 [TRACE] dag/walk: visiting "data.azurerm_client_config.current"
2020/08/26 14:25:52 [TRACE] vertex "data.azurerm_client_config.current": starting visit (*terraform.NodePlannableResourceInstance)
2020/08/26 14:25:52 [TRACE] vertex "data.azurerm_client_config.current": evaluating
2020/08/26 14:25:52 [TRACE] [walkPlan] Entering eval tree: data.azurerm_client_config.current
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalSequence
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalGetProvider
2020/08/26 14:25:52 [TRACE] UpgradeResourceState: schema version of azurerm_resource_group.rg is still 0; calling provider "azurerm" for any other minor fixups
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalReadState
2020/08/26 14:25:52 [TRACE] GRPCProvider: UpgradeResourceState
2020/08/26 14:25:52 [TRACE] EvalReadState: reading state for data.azurerm_client_config.current
2020/08/26 14:25:52 [TRACE] eval: *terraform.EvalValidateSelfRef
2020/08/26 14:25:52 [TRACE] eval: *terraform.evalReadDataPlan
2020/08/26 14:25:52 [TRACE] vertex "data.azurerm_client_config.current": visit complete
panic: not a collection type
...

Crash Output

2020/08/26 14:25:52 [TRACE] vertex "data.azurerm_client_config.current": visit complete
panic: not a collection type

goroutine 459 [running]:
github.com/zclconf/go-cty/cty.Type.ElementType(0x2d39220, 0xc000ff80d0, 0xc0005f59e8, 0x8)
	/home/circleci/project/project/vendor/github.com/zclconf/go-cty/cty/collection.go:25 +0xc1
github.com/hashicorp/terraform/terraform.createEmptyBlocks(0xc000f3a8a0, 0x2d39220, 0xc000ff80f0, 0x2355700, 0xc001508ed0, 0x2d39220, 0xc000ff81f0, 0x2355700, 0xc00152cd20)
	/home/circleci/project/project/terraform/eval_read_data_plan.go:242 +0x209
github.com/hashicorp/terraform/terraform.dataObjectHasChanges(0xc000f3a8a0, 0x2d39220, 0xc000ff80f0, 0x2355700, 0xc001508ed0, 0x2d39220, 0xc000ff81f0, 0x2355700, 0xc00152cd20, 0x0, ...)
	/home/circleci/project/project/terraform/eval_read_data_plan.go:211 +0x1a5
github.com/hashicorp/terraform/terraform.(*evalReadDataPlan).Eval(0xc001516000, 0x2d7b6e0, 0xc0012121a0, 0x1, 0x1, 0x0, 0x0)
	/home/circleci/project/project/terraform/eval_read_data_plan.go:107 +0x123f
github.com/hashicorp/terraform/terraform.EvalRaw(0x2cd1460, 0xc001516000, 0x2d7b6e0, 0xc0012121a0, 0x0, 0x0, 0x0, 0x0)
	/home/circleci/project/project/terraform/eval.go:49 +0xce
github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc000692580, 0x2d7b6e0, 0xc0012121a0, 0x1, 0x1, 0x6, 0xc000765550)
	/home/circleci/project/project/terraform/eval_sequence.go:20 +0x104
github.com/hashicorp/terraform/terraform.EvalRaw(0x2cd0ec0, 0xc000692580, 0x2d7b6e0, 0xc0012121a0, 0x230aac0, 0x40098a2, 0x226ae60, 0xc0012f2730)
	/home/circleci/project/project/terraform/eval.go:49 +0xce
github.com/hashicorp/terraform/terraform.Eval(0x2cd0ec0, 0xc000692580, 0x2d7b6e0, 0xc0012121a0, 0xc000692580, 0x2cd0ec0, 0xc000692580, 0x0)
	/home/circleci/project/project/terraform/eval.go:35 +0x54
github.com/hashicorp/terraform/terraform.(*Graph).walk.func1(0x2699c60, 0xc0012f2250, 0x0, 0x0, 0x0)
	/home/circleci/project/project/terraform/graph.go:73 +0xc7e
github.com/hashicorp/terraform/dag.(*Walker).walkVertex(0xc000765440, 0x2699c60, 0xc0012f2250, 0xc0014b2280)
	/home/circleci/project/project/dag/walk.go:387 +0x35e
created by github.com/hashicorp/terraform/dag.(*Walker).Update
	/home/circleci/project/project/dag/walk.go:309 +0x11de

Expected Behavior

Running the following command should succeed.

Actual Behavior

Crashes on 13.1, but doesn't on 13.0

Steps to Reproduce

az login
az account set -s <id>
terraform init -backend-config=storage_account_name=x -backend-config=container_name=state -backend-config=key=y-bootstrap.tfstate -backend-config=resource_group_name=z-state -backend-config=arm_subscription_id=subid
terraform plan --var-file ./dev.tfvars -out ./dev.tfplan

References

May be related to panic: inconsistent map element types (cty.List(cty.String) then cty.Bool) #25773

The text was updated successfully, but these errors were encountered:

lasoster · 2020-08-26T22:26:57Z

Same error here.
it doesn't happen if i don't use

data "azurerm_subscription" "current" {}

LaurentLesle · 2020-08-27T12:02:16Z

Get this error with Azure AD provider when using 13.1
data.azuread_users.users configuration is complete, so reading from provider
2020/08/27 11:42:53 [TRACE] GRPCProvider: ReadDataSource
panic: not a collection type

goroutine 5859 [running]:
github.com/zclconf/go-cty/cty.Type.ElementType(0x2ce50a0, 0xc0005860d0, 0xc0006d5330, 0x8)
/home/circleci/project/project/vendor/github.com/zclconf/go-cty/cty/collection.go:25 +0xba
github.com/hashicorp/terraform/terraform.createEmptyBlocks(0xc000a280f0, 0x2ce50a0, 0xc0005860f8, 0x2300040, 0xc0012ad170, 0x2ce50a0, 0xc0005861b0, 0x2300040, 0xc00245c420)
/home/circleci/project/project/terraform/eval_read_data_plan.go:242 +0x202
github.com/hashicorp/terraform/terraform.dataObjectHasChanges(0xc000a280f0, 0x2ce50a0, 0xc0005860f8, 0x2300040, 0xc0012ad170, 0x2ce50a0, 0xc0005861b0, 0x2300040, 0xc00245c420, 0x0, ...)
/home/circleci/project/project/terraform/eval_read_data_plan.go:211 +0x19e
github.com/hashicorp/terraform/terraform.(*evalReadDataPlan).Eval(0xc000d3bef0, 0x2d26860, 0xc001fca0d0, 0x1, 0x1, 0x0, 0x0)
/home/circleci/project/project/terraform/eval_read_data_plan.go:107 +0x1238
github.com/hashicorp/terraform/terraform.EvalRaw(0x2c7d420, 0xc000d3bef0, 0x2d26860, 0xc001fca0d0, 0x0, 0x0, 0x0, 0x0)
/home/circleci/project/project/terraform/eval.go:49 +0xc7
github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc001d2fa80, 0x2d26860, 0xc001fca0d0, 0x1, 0x1, 0x6, 0xc0004e1670)
/home/circleci/project/project/terraform/eval_sequence.go:20 +0xfd
github.com/hashicorp/terraform/terraform.EvalRaw(0x2c7ce80, 0xc001d2fa80, 0x2d26860, 0xc001fca0d0, 0x22b4bc0, 0x3fa2622, 0x2214980, 0xc001173050)
/home/circleci/project/project/terraform/eval.go:49 +0xc7
github.com/hashicorp/terraform/terraform.Eval(0x2c7ce80, 0xc001d2fa80, 0x2d26860, 0xc001fca0d0, 0xc001d2fa80, 0x2c7ce80, 0xc001d2fa80, 0x0)
/home/circleci/project/project/terraform/eval.go:35 +0x4d
github.com/hashicorp/terraform/terraform.(*Graph).walk.func1(0x2645300, 0xc001172520, 0x0, 0x0, 0x0)
/home/circleci/project/project/terraform/graph.go:73 +0xc77
github.com/hashicorp/terraform/dag.(*Walker).walkVertex(0xc0004e1320, 0x2645300, 0xc001172520, 0xc0020b1d00)
/home/circleci/project/project/dag/walk.go:387 +0x357
created by github.com/hashicorp/terraform/dag.(*Walker).Update
/home/circleci/project/project/dag/walk.go:309 +0x11d7

byserge · 2020-08-27T15:32:10Z

I can confirm that removing the following from the code and using variables instead fixes the issue in terraform 0.13.1:
data "azurerm_client_config"

knighteagle789 · 2020-08-27T19:08:35Z

It seems that any data "azurerm_*" is broken. I am trying to use data "azurerm_virtual_network" with the same error results.

rcyrus · 2020-08-27T19:21:16Z

I also have this issue on a fresh project and have additional anecdotal info.

First terraform apply on a "virgin" resource group works fine. If i run terraform plan or apply after resource creation I get this same crash.

Also, since this is a fresh project I didn't notice any problems until I added data elements to my configuration. If i remove them then everything works fine again.

My data elements use azurerm_subnet resource.

Terraform v0.13.1
hashicorp/azurerm 2.24.0

buddhamangler-cbre · 2020-08-27T19:52:48Z

Experiencing the same issue

dcrreynolds · 2020-08-27T21:47:04Z

+1 here, same error.

alisdair · 2020-08-28T00:08:27Z

Thanks for all the reports! This is the simplest config I've been able to find that reproduces this crash:

provider "azurerm" {
  version = "~>2"
  features {}
}
data "azurerm_client_config" "current" {}

az login
terraform init
terraform plan crashes

swetli · 2020-08-28T09:48:35Z

We are using remote state that was overwritten with terraform_version 0.13.1 and as a result the terraform plan and apply fails. Trying to manually downgrade to terraform 0.13.0 with terraform state pull, editing the terraform_version and bumping the serial, followed by terraform state push, does not work.

{
---cut
  "terraform_version": "0.13.0",
  "serial": 123,
---cut
}

Anyone has any ideas of workarounds since we are pretty much stuck with the state being locked to 0.13.1 ?

man0s · 2020-08-28T11:09:32Z

Revert to the latest working version(0.13.0) until this bug is fixed as a temporary solution.

PS: Fixed on the latest version(0.13.2).

alisdair · 2020-08-28T14:31:35Z

Thanks again to everyone who reported this. The bug is fixed in #26028 which will be released as part of v0.13.2.

s0lvang · 2020-08-28T17:09:39Z

We are using remote state that was overwritten with terraform_version 0.13.1 and as a result the terraform plan and apply fails. Trying to manually downgrade to terraform 0.13.0 with terraform state pull, editing the terraform_version and bumping the serial, followed by terraform state push, does not work.
{
---cut
  "terraform_version": "0.13.0",
  "serial": 123,
---cut
}
Anyone has any ideas of workarounds since we are pretty much stuck with the state being locked to 0.13.1 ?

@swetli Any luck with this? I have excactly the same problem :/

swetli · 2020-09-01T07:06:02Z

For those having my issue - just manually edit the version to 0.13.0 and increase the serial in the azure blob storage to 0.13.0.

alisdair · 2020-09-02T15:14:36Z

Terraform 0.13.2 was released today: https://www.terraform.io/downloads.html

para0056 · 2020-09-02T16:14:54Z

Terraform 0.13.2 was released today: https://www.terraform.io/downloads.html

When will the new version be available from apt?

jwshive · 2020-09-02T16:22:09Z

I managed to run a successful 0.13.2 Azure DevOps Pipeline. Previously failing on a terraform validate, now passing.

P0gChamp420 · 2020-09-07T10:55:16Z

@jwshive how did you manage to do that? I specified in my Pipeline.yaml file that terraform should use v 0.13.2 but during the run it uses v 0.13.1 and i got the error described above.

jwshive · 2020-09-07T11:33:28Z

In my build pipeline, I just have this and updated it accordingly

      - task: TerraformInstaller@0
        displayName: 'Install Terraform 0.13.2'
        inputs:
          terraformVersion: '0.13.2'

My release pipeline is as such

steps:
- task: ms-devlabs.custom-terraform-tasks.custom-terraform-installer-task.TerraformInstaller@0
  displayName: 'Install Terraform 0.13.2'
  inputs:
    terraformVersion: 0.13.2

If you're doing testing on a non-master git branch and you update the yml on the devops web ui, you're updating the master branch but may be running against a non-master branch. That's about the only thing I can think of that might be different.

Hardt-Coded · 2020-09-07T13:34:22Z

You have to mention, that you have to install the Terraform Extension (the first one!) in order to get the task to work.

jwshive · 2020-09-07T13:35:34Z

Correct. I assumed that since they were getting the error for 0.13.1 that they had the extension installed.

Hardt-Coded · 2020-09-07T14:35:50Z

The wrong version is now default on the agent in azure devops. We run into this error today. Thanks to you, we could solve it. So thank you!

ghost · 2020-10-13T01:55:50Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

michsco added bug new new issue not yet triaged labels Aug 26, 2020

alisdair mentioned this issue Aug 27, 2020

panic: not a collection type - on azurerm cognitive services #26023

Closed

alisdair added confirmed a Terraform Core team member has reproduced this issue and removed new new issue not yet triaged labels Aug 28, 2020

alisdair self-assigned this Aug 28, 2020

alisdair mentioned this issue Aug 28, 2020

terraform: Fix createEmptyBlocks NestingSingle bug #26028

Merged

sonic1981 mentioned this issue Aug 28, 2020

Terraform 0.13.1 Provider Problem terraform.io/builtin/terraform" #26031

Closed

alisdair closed this as completed in #26028 Aug 28, 2020

alisdair mentioned this issue Aug 28, 2020

Terraform 0.13.1 crash during plan #26040

Closed

This was referenced Aug 31, 2020

Terraform Crashing on validation (terraform plan/apply) #26048

Closed

Terraform Crash after upgrading to v0.13.1 in mac machine #26046

Closed

andrei-dascalu mentioned this issue Sep 1, 2020

Crash while running plan (0.13.1) #26073

Closed

This was referenced Sep 1, 2020

"panic: not a collection type" terraform crash on plan #26081

Closed

Terraform crash while running "plan" from Visual Studio Studio Code #26097

Closed

jbardin mentioned this issue Sep 2, 2020

Crash when evaluating plan of azurerm_monitor_diagnostic_categories #26095

Closed

alisdair mentioned this issue Sep 3, 2020

Panic: not a collection type #26120

Closed

allantargino mentioned this issue Sep 4, 2020

Removing ACR credentials from variables Azure-Samples/jmeter-aci-terraform#45

Merged

njuCZ mentioned this issue Sep 8, 2020

Terraform plan is getting crashed with the error: "panic: not a collection type" hashicorp/terraform-provider-azurerm#8379

Closed

ghost locked as resolved and limited conversation to collaborators Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

panic: not a collection type (regression between 13.1 and 13.0) #26011

panic: not a collection type (regression between 13.1 and 13.0) #26011

michsco commented Aug 26, 2020

lasoster commented Aug 26, 2020

LaurentLesle commented Aug 27, 2020 •

edited

Loading

byserge commented Aug 27, 2020

knighteagle789 commented Aug 27, 2020

rcyrus commented Aug 27, 2020 •

edited

Loading

buddhamangler-cbre commented Aug 27, 2020

dcrreynolds commented Aug 27, 2020

alisdair commented Aug 28, 2020

swetli commented Aug 28, 2020 •

edited

Loading

man0s commented Aug 28, 2020 •

edited

Loading

alisdair commented Aug 28, 2020

s0lvang commented Aug 28, 2020 •

edited

Loading

swetli commented Sep 1, 2020

alisdair commented Sep 2, 2020

para0056 commented Sep 2, 2020

jwshive commented Sep 2, 2020

P0gChamp420 commented Sep 7, 2020

jwshive commented Sep 7, 2020

Hardt-Coded commented Sep 7, 2020

jwshive commented Sep 7, 2020

Hardt-Coded commented Sep 7, 2020

ghost commented Oct 13, 2020

panic: not a collection type (regression between 13.1 and 13.0) #26011

panic: not a collection type (regression between 13.1 and 13.0) #26011

Comments

michsco commented Aug 26, 2020

Terraform Version

Terraform Configuration Files

Debug Output

Crash Output

Expected Behavior

Actual Behavior

Steps to Reproduce

References

lasoster commented Aug 26, 2020

LaurentLesle commented Aug 27, 2020 • edited Loading

byserge commented Aug 27, 2020

knighteagle789 commented Aug 27, 2020

rcyrus commented Aug 27, 2020 • edited Loading

buddhamangler-cbre commented Aug 27, 2020

dcrreynolds commented Aug 27, 2020

alisdair commented Aug 28, 2020

swetli commented Aug 28, 2020 • edited Loading

man0s commented Aug 28, 2020 • edited Loading

alisdair commented Aug 28, 2020

s0lvang commented Aug 28, 2020 • edited Loading

swetli commented Sep 1, 2020

alisdair commented Sep 2, 2020

para0056 commented Sep 2, 2020

jwshive commented Sep 2, 2020

P0gChamp420 commented Sep 7, 2020

jwshive commented Sep 7, 2020

Hardt-Coded commented Sep 7, 2020

jwshive commented Sep 7, 2020

Hardt-Coded commented Sep 7, 2020

ghost commented Oct 13, 2020

LaurentLesle commented Aug 27, 2020 •

edited

Loading

rcyrus commented Aug 27, 2020 •

edited

Loading

swetli commented Aug 28, 2020 •

edited

Loading

man0s commented Aug 28, 2020 •

edited

Loading

s0lvang commented Aug 28, 2020 •

edited

Loading