fix: Wrap each use of filesystem library in #ifndef __wasm__
#181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround that fixes #180
As noted in the issue, the
<filesystem>
library can't be used in code that compiles to Wasm, even if we are targeting WASI. I just quickly wrapped all the usages in#ifndef __wasm__
to verify this workaround solves the problem in Nix. I think the "more correct" way to solve this would be to usemkdir
(on unix) and_mkdir
(on Windows), but that seemed to receive pushback on the internal PR.Checklist:
/markdown/specs
have been updated.@brief
describing the intended functionality.