Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or change <filesystem> usage in project #180

Closed
phated opened this issue Feb 23, 2023 · 1 comment · Fixed by #181
Closed

Remove or change <filesystem> usage in project #180

phated opened this issue Feb 23, 2023 · 1 comment · Fixed by #181
Assignees

Comments

@phated
Copy link
Contributor

phated commented Feb 23, 2023

As noted in WebAssembly/wasi-sdk#125, the <filesystem> library cannot be used in wasm/wasi. This project seems stuck on wasi-sdk 12 because it contained a bug that didn't disable loading that filesystem header, but if that code path is every taken, it'd crash.

@adr1anh noted this in an internal issue, and had fixes to use mkdir instead; this seemed to have been blocked as "not portable".

We should either #ifndef around all code using <filesystem> or switch to mkdir. It seems this can be made portable by using _mkdir on Windows.

@phated phated self-assigned this Feb 23, 2023
@phated
Copy link
Contributor Author

phated commented Feb 23, 2023

I believe this is the LLVM patch that did it: https://reviews.llvm.org/D94921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant