-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Kernel fix & test improvements/refactoring #239
feat: Kernel fix & test improvements/refactoring #239
Conversation
…nit arrays of frs
…gic in test setup for computing function/contract tree roots/siblings
// TODO: this fails intermittently, with: | ||
// bigfield multiply range check failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this TODO has been fixed, so this comment can be removed.
@@ -409,20 +364,15 @@ TEST(private_kernel_tests, test_native_deposit) | |||
|
|||
Prover mock_kernel_prover = mock_kernel_composer.create_prover(); | |||
NT::Proof mock_kernel_proof = mock_kernel_prover.construct_proof(); | |||
// info("\nmock_kernel_proof: ", mock_kernel_proof.proof_data); | |||
|
|||
std::shared_ptr<NT::VK> mock_kernel_vk = mock_kernel_composer.compute_verification_key(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iAmMichaelConnor this is the big chunk we should be able to remove once we have the special kernel version for the initial iteration. Won't need to compute the mock kernel anymore.
Description
Status
Blocked by chore: zero-initialize all structs & their members and arrays #233Needs to be rebased on master which will be some work.Need to comment helper functions in hash.hpp.Contents
std::function
type to write functions that accept any circuit function as input.Checklist:
/specs
have been updated.@brief
describing the intended functionality.