-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable rollup components #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
AggregationObject aggregate_proofs(BaseOrMergeRollupPublicInputs left, BaseOrMergeRollupPublicInputs right); | ||
|
||
template <size_t N> | ||
NT::fr iterate_through_tree_via_sibling_path(NT::fr leaf, NT::uint32 leafIndex, std::array<NT::fr, N> siblingPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to prevent putting the template files in the hpp we could create a components.tpp file with the templates. Not sure if this will be messier than declaring them inside this file though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn kinda annoying/confusing that it is already split between cpp/hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given it's quite a small file, I'd be tempted to leave them in here. If it grows, we can try to separate, perhaps?
LGTM but Ah man gonna have a few conflicts with #185 :( |
830b118
to
9e0bf01
Compare
Description
Moves components that are used in multiple rollup circuits into components such that they can be reused instead of duplicated.
Checklist:
/specs
have been updated.@brief
describing the intended functionality.