Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just use one type of public inputs for base/merge #168

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

rahul-kothari
Copy link
Contributor

@rahul-kothari rahul-kothari commented Apr 5, 2023

Description

Both structs need to be exactly the same for us to use them interchangeably in the Merge / Root rollup circuits. So just use one struct!

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

@LHerskind LHerskind merged commit fa3eb6c into rk/merge_rollup Apr 5, 2023
@LHerskind LHerskind deleted the rk/base_or_merge_pub_inputs branch April 5, 2023 15:36
LHerskind added a commit that referenced this pull request Apr 5, 2023
* initial version of merge rollup

* move previous rollup data from base to merge and update root

* fix ci

* add rollup subtree height

* add tests

* test: change expectd failure regex (#164)

* just use one type of public inputs for base/merge (#168)

* this better work and ignore wasm tests

---------

Co-authored-by: Lasse Herskind <[email protected]>
LHerskind added a commit that referenced this pull request Apr 6, 2023
* fix ci

* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: Reuse merge logic in root when possible

* fix: root enforce left -> right + test fix

* fix: unused right due to assert

* fix: fix unused computed_root

* chore: make loop bonobo friendly

* fix: use `get_sibling_path` in tree

---------

Co-authored-by: Rahul Kothari <[email protected]>
Maddiaa0 pushed a commit that referenced this pull request Apr 12, 2023
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants