-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct calls to public functions #852
Conversation
// TODO(#662): Reenable once we can create more than one account. | ||
it.skip('5.4: Should be able to create a commitment in a public function and spend in a private function', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @PhilWindle to remove skip when 662 is ready. Will require tweaking this bit as well:
aztec-packages/yarn-project/end-to-end/src/utils.ts
Lines 71 to 79 in 72524f8
if (i == 0) { | |
// TODO(#662): Let the aztec rpc server generate the keypair rather than hardcoding the private key and generate all accounts as smart accounts | |
const [txHash, newAddress] = await aztecRpcServer.createSmartAccount(privateKey); | |
const isMined = await new SentTx(aztecRpcServer, Promise.resolve(txHash)).isMined(); | |
expect(isMined).toBeTruthy(); | |
address = newAddress; | |
} else { | |
address = await aztecRpcServer.addExternallyOwnedAccount(); | |
} |
d79ac82
to
0488196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of changes but the general gist is fantastic. So much extraneous complexity ripped out. It must have been cathartic.
yarn-project/types/src/tx.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simplifications in this file alone make me much happier!
fa73770
to
ab08eaf
Compare
Summary of changes:
PrivateTx
andPublicTx
subtypes forTx
.txRequest
from aTx
, which was used to indicate a topmost public function call.SignedTx
andSignedTxRequest
types.Fixes #663